Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FF91C4338F for ; Fri, 23 Jul 2021 06:06:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FB5660E90 for ; Fri, 23 Jul 2021 06:06:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233845AbhGWF0B (ORCPT ); Fri, 23 Jul 2021 01:26:01 -0400 Received: from verein.lst.de ([213.95.11.211]:37115 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233733AbhGWF0A (ORCPT ); Fri, 23 Jul 2021 01:26:00 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 6DA4A67373; Fri, 23 Jul 2021 08:06:31 +0200 (CEST) Date: Fri, 23 Jul 2021 08:06:31 +0200 From: Christoph Hellwig To: Boris Pismenny Cc: dsahern@gmail.com, kuba@kernel.org, davem@davemloft.net, saeedm@nvidia.com, hch@lst.de, sagi@grimberg.me, axboe@fb.com, kbusch@kernel.org, viro@zeniv.linux.org.uk, edumazet@google.com, smalin@marvell.com, boris.pismenny@gmail.com, linux-nvme@lists.infradead.org, netdev@vger.kernel.org, benishay@nvidia.com, ogerlitz@nvidia.com, yorayz@nvidia.com, Boris Pismenny Subject: Re: [PATCH v5 net-next 04/36] net/tls: expose get_netdev_for_sock Message-ID: <20210723060631.GA32369@lst.de> References: <20210722110325.371-1-borisp@nvidia.com> <20210722110325.371-5-borisp@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210722110325.371-5-borisp@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jul 22, 2021 at 02:02:53PM +0300, Boris Pismenny wrote: > From: Boris Pismenny > > get_netdev_for_sock is a utility that is used to obtain > the net_device structure from a connected socket. > > Later patches will use this for nvme-tcp DDP and DDP DDGST offloads. > > Signed-off-by: Boris Pismenny > Reviewed-by: Sagi Grimberg I don't think this should be an inline. Please move it to net/core/dev.c, andd add an EXPORT_SYMBOL_GPL and a kerneldoc comment.