Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7ACDC4338F for ; Sat, 24 Jul 2021 03:25:49 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5F0860EB4 for ; Sat, 24 Jul 2021 03:25:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C5F0860EB4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A77FF82DC0; Sat, 24 Jul 2021 05:25:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="XjIuhgeK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DBD5082D96; Sat, 24 Jul 2021 05:25:43 +0200 (CEST) Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 35BF582D96 for ; Sat, 24 Jul 2021 05:25:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82b.google.com with SMTP id b1so3090537qtx.0 for ; Fri, 23 Jul 2021 20:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=tiBQEfEpq01k9TIQuH6/KC0iOw3qBHKowLsi9pNomqk=; b=XjIuhgeKPuxRE4CUd4xVJul8pMB2odF1lBRc89es6Af2N8MaIjK7n9myRvfVmg9qau SulJNgSZasWT6mSVvT+PYGdgXYUj1HYLoGbvNieyLKn28uwin2qzqpsQF3CO8p1VPaLp L0oWcy7cW8XM/UIQTsA4IfnfqpmiaAP2UbSko= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tiBQEfEpq01k9TIQuH6/KC0iOw3qBHKowLsi9pNomqk=; b=K+FUj+gFa59+h7Uf1fAg7T+4zYUi0WwlOTU1D/0MsYgtCMy66PcSlORmUeCWzxb57w nSYlKN0s9dFXXuvPPrq5d5u9AJ5VPoidvUCRoq+Ee3cVWHWmVjCTNso41zas1gzd36um jWC6SQ7+PmYHq6DBEyWzIa2VOGfNAWPbp5e3VYDdiB6CqhgPGlu3veb9IiK61i4DPOxC yFo71vS5dPJv0scgEyM/SQFsXjuiOOpNt0l3pbUOY6K2UZM+npoJzlxKEW+yCGpNmmWs DZGLlU/Djqt6is5St472tQOvHATmHUkmY4f0tFM/2o6aMJnbW/ZNTlDGRPaH2q4eMJpE A5XA== X-Gm-Message-State: AOAM531RgnVBFZGOS5ZciqgeAfO8kWVaufAerC6Gicu3C3tvxGtOLQZ2 eCRji7adS1TBEJbGGl4rbnE7uA== X-Google-Smtp-Source: ABdhPJyWVA2BexepncT23gesRYIRtRGkl3M2oDS6DMc5HWSjID21AnGfMRkHP46dizgvNX+zM4dpKg== X-Received: by 2002:ac8:7a8b:: with SMTP id x11mr6483166qtr.126.1627097138863; Fri, 23 Jul 2021 20:25:38 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-5514-7b31-784c-a4c7.res6.spectrum.com. [2603:6081:7b01:cbda:5514:7b31:784c:a4c7]) by smtp.gmail.com with ESMTPSA id l11sm15653058qke.23.2021.07.23.20.25.37 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Jul 2021 20:25:37 -0700 (PDT) Date: Fri, 23 Jul 2021 23:25:35 -0400 From: Tom Rini To: Dennis Gilmore Cc: Michal Simek , Peter Robinson , U-Boot Mailing List , T Karthik Reddy , Ashok Reddy Soma , Pratyush Yadav Subject: Re: [PATCH] Revert "spi: spi-uclass: Add support to manually relocate spi memory ops" Message-ID: <20210724032535.GL9379@bill-the-cat> References: <20210722152529.1407976-1-pbrobinson@gmail.com> <0e9e0b0d-e363-379b-d63b-e4a3c73213d1@xilinx.com> <20210722173011.GC9379@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8PwxOTgimcLqatFW" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --8PwxOTgimcLqatFW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 23, 2021 at 09:46:44PM -0500, Dennis Gilmore wrote: > removing the header is not sufficient to have the boards booting from SPI. >=20 > U-Boot TPL 2021.07-00768-g49373a3334-dirty (Jul 23 2021 - 20:42:57) > Channel 0: LPDDR4, 50MHz > BW=3D32 Col=3D10 Bk=3D8 CS0 Row=3D16/15 CS=3D1 Die BW=3D16 Size=3D2048MB > Channel 1: LPDDR4, 50MHz > BW=3D32 Col=3D10 Bk=3D8 CS0 Row=3D16/15 CS=3D1 Die BW=3D16 Size=3D2048MB > 256B stride > lpddr4_set_rate: change freq to 400000000 mhz 0, 1 > lpddr4_set_rate: change freq to 800000000 mhz 1, 0 > Trying to boot from BOOTROM > Returning to boot ROM... >=20 > U-Boot SPL 2021.07-00768-g49373a3334-dirty (Jul 23 2021 - 20:42:57 -0500) > Trying to boot from SPI >=20 > At this point u-boot hangs, with the patch reverted I get the following > U-Boot TPL 2021.07-00769-g4af8bd872c-dirty (Jul 23 2021 - 21:20:51) > Channel 0: LPDDR4, 50MHz > BW=3D32 Col=3D10 Bk=3D8 CS0 Row=3D16/15 CS=3D1 Die BW=3D16 Size=3D2048MB > Channel 1: LPDDR4, 50MHz > BW=3D32 Col=3D10 Bk=3D8 CS0 Row=3D16/15 CS=3D1 Die BW=3D16 Size=3D2048MB > 256B stride > lpddr4_set_rate: change freq to 400000000 mhz 0, 1 > lpddr4_set_rate: change freq to 800000000 mhz 1, 0 > Trying to boot from BOOTROM > Returning to boot ROM... >=20 > U-Boot SPL 2021.07-00769-g4af8bd872c-dirty (Jul 23 2021 - 21:20:51 -0500) > Trying to boot from SPI >=20 >=20 > U-Boot 2021.07-00769-g4af8bd872c-dirty (Jul 23 2021 - 21:20:51 -0500) >=20 > SoC: Rockchip rk3399 > Reset cause: RST > Model: Kobol Helios64 > Revision: 0.0 - Unknown > DRAM: 3.9 GiB > PMIC: RK808 > MMC: mmc@fe320000: 1, mmc@fe330000: 0 > Loading Environment from SPIFlash... SF: Detected w25q128 with page > size 256 Bytes, erase size 4 KiB, total 16 MiB > *** Warning - bad CRC, using default environment >=20 > In: serial@ff1a0000 > Out: serial@ff1a0000 > Err: serial@ff1a0000 > Model: Kobol Helios64 > Revision: UNKNOWN > Net: dw_dm_mdio_init: mdio node is missing, registering legacy mdio > busNo ethernet found. >=20 > starting USB... > Bus usb@fe900000: usb maximum-speed not found > Register 2000140 NbrPorts 2 > Starting the controller > USB XHCI 1.10 > scanning bus usb@fe900000 for devices... 2 USB Device(s) found > scanning usb for storage devices... 0 Storage Device(s) found > Hit any key to stop autoboot: 0 > switch to partitions #0, OK > mmc0(part 0) is current device > ** No partition table - mmc 0 ** > Couldn't find partition mmc 0:1 > switch to partitions #0, OK > mmc1 is current device > Scanning mmc 1:1... > Scanning disk mmc@fe320000.blk... > Scanning disk mmc@fe330000.blk... > ** Unrecognized filesystem type ** > Found 5 disks > dw_dm_mdio_init: mdio node is missing, registering legacy mdio > busdw_dm_mdio_init: mdio node is missing, registering legacy mdio > busLoading Boot0000 'Fedora' failed > EFI boot manager: Cannot load any image > Found EFI removable media binary efi/boot/bootaa64.efi Is LTO on, on these platforms? That code in question really should not be enabled, at all. Like, if you toss an #error in that section of code, it should still build. It does, right? --=20 Tom --8PwxOTgimcLqatFW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmD7iCwACgkQFHw5/5Y0 tyx/MAv/eRZ4K+hCB7YycQGt+AumVKuhUFvOhVIEsDQHhoTbgJbsIoNkvCQWLziJ wanCBBlAI7pOFtpVXMMCwuCmoJ+qLHCcmQjF1lfbOEGFhscrqio7y1fefqaEVvcR 4YXP/V1xe+yjLwdt/mZko96wiZl++4rQxgDCg0sb+aYq/7CNYKJVMwagosRoIRyw wHYaSMsfFFF4vbL4uIIROZ06ADiEGn57+rZAa2mUG1LoOC3gTOwQO3RRRB+8T5dE POHg08HpvTf2/7DSm4ct6yZBcm7ORTRPfethSn/tweOs4qP6nUJTKL0Ky3nXR6HL p6MuGAdVpcMB3o2YlIdjSEVMOKG5m7DbHGi0tuttL4UJpfUOz8G7+bxvehoPCSmc jj2QzibMqLilvp5MPWvfAxXXEkyQoZ3AEQBme01ZW4B09VzyN+HGi8bE3MjPnhzb jInmQ8fFtsR4BtWGyksQLEan2m0XAyEekAuKisa1oM9TbyO2HT2vXrbH7SMixo3D EjK+oTKW =57eI -----END PGP SIGNATURE----- --8PwxOTgimcLqatFW--