Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76CDFC4338F for ; Sat, 24 Jul 2021 12:57:34 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BB4B60E92 for ; Sat, 24 Jul 2021 12:57:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4BB4B60E92 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E7D4B82E3F; Sat, 24 Jul 2021 14:57:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="JtEekjYt"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EC31A82EB5; Sat, 24 Jul 2021 14:57:27 +0200 (CEST) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8A33082E02 for ; Sat, 24 Jul 2021 14:57:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x734.google.com with SMTP id b20so4179292qkj.3 for ; Sat, 24 Jul 2021 05:57:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=M/QjcmAqGt/koqGns8nr8DETKqyVbq0JHDb/AcHXe5E=; b=JtEekjYt7FMTAcqS1ELfDgr2gHMuOLKEKmV7OQxfeQZt4EeVPyOpFXDTXemi/0FMdA kYKiRhcmFThcIP/YkHNTmnCko4NTF6Fa493osUiwI4qtm520qF0Ftn2kvnYfr/kjMB8A wHmFiPSN3QZaUtsL8oEkFdnuiufpyg4wokbmU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=M/QjcmAqGt/koqGns8nr8DETKqyVbq0JHDb/AcHXe5E=; b=ToF1u0oQmFIiiqYxFlELBHtsK/Dv2OJ8HhAgFvpbsAnka8NEHXZZENVKUYuDMx5Fb8 J/90bbIKb6fEX846FUGeL6Kut2BY2sT0hbwdQlpeEw9+HTZRmyNLTMqMkPBzcX0x2xjt V8y4l3F+WPCZSLAc0F1BpRL1CAzJfZwdhIPbo9FslDdqbfJP/yQvKRbqlXo85/HkFZKZ GlfCR4i96kfy2v5ihRQGH5GE/ZI9fYaW+6enqmHywWcq0MHZFQagW/52cniJgtEg+RUv LVgzOSi0YyEL8xWZd8GL8ToISkJZsYbOjycnYR6qyZtKkzHuwYdtgAwKuJZLc9o+xuer 9aKA== X-Gm-Message-State: AOAM533PChMw/sAssuVRaSjcAeBUub7gq2yPjqVS+2FeyPxN7kscH3q9 ybKuFrS2TQrOoT83ZO4S5IFKNw== X-Google-Smtp-Source: ABdhPJzSsepExB6rjJa63uUjMuc5d768TZT6WqQAEH54PxaIyPaJ5CjeyXYzc82W/KaBH/wDtNTHQg== X-Received: by 2002:a37:aa4d:: with SMTP id t74mr9189780qke.349.1627131443276; Sat, 24 Jul 2021 05:57:23 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-5514-7b31-784c-a4c7.res6.spectrum.com. [2603:6081:7b01:cbda:5514:7b31:784c:a4c7]) by smtp.gmail.com with ESMTPSA id c1sm1082925qtj.36.2021.07.24.05.57.22 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 24 Jul 2021 05:57:22 -0700 (PDT) Date: Sat, 24 Jul 2021 08:57:20 -0400 From: Tom Rini To: Chia-Wei Wang Cc: lukma@denx.de, maxims@google.com, sjg@chromium.org, u-boot@lists.denx.de, ryan_chen@aspeedtech.com, joel@jms.id.au Subject: Re: [PATCH v3 06/14] common: fit: Use hash.c to call CRC/SHA function Message-ID: <20210724125720.GA25851@bill-the-cat> References: <20210720063839.1518-1-chiawei_wang@aspeedtech.com> <20210720063839.1518-7-chiawei_wang@aspeedtech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PEIAKu/WMn1b1Hv9" Content-Disposition: inline In-Reply-To: <20210720063839.1518-7-chiawei_wang@aspeedtech.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --PEIAKu/WMn1b1Hv9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 20, 2021 at 02:38:31PM +0800, Chia-Wei Wang wrote: > From: Joel Stanley >=20 > Currently the FIT verification calls directly into > SW implemented functions to get a CRC/SHA/MD5 hash. >=20 > This patch removes duplcated algorithm lookup and use > hash_lookup_algo to get the hashing function with HW > accelearation supported if configured. >=20 > The MD5 direct call remains as it is not included in > the hash lookup table of hash.c. >=20 > Signed-off-by: Joel Stanley > Signed-off-by: Chia-Wei Wang While this is a good idea, there's some required prep work. At least the following platforms don't compile due to this patch: ls1046ardb_qspi imx8mm_beacon imx8mn_beacon imx8mn_beacon_2g imx8mm-icore-mx8mm-ctouch2 imx8mm-icore-mx8mm-edimm2.2 imx8mm_evk imx8mn_ddr4_evk imx8mn_evk imx8mp_evk imx8mq_evk imx8mm_venice imx8mq_phanbell phycore-imx8mm phycore-imx8mp pico-imx8mq verdin-imx8mm mt8183_pumpkin mt8516_pumpkin mscc_jr2 mscc_luton mscc_ocelot mscc_serval mscc_servalt mt7620_mt7530_rfb mt7620_rfb mt7628_rfb Which is likely due to cases where HASH or SPL_HASH_SUPPORT are not being selected as it was not previously required. --=20 Tom --PEIAKu/WMn1b1Hv9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmD8Di0ACgkQFHw5/5Y0 tywJHwv+OCi+ue3DMxzySj+rVhw+mjkq4c4e4DBEpu2XBHfmob65ihjqtMGVQLfz LLVgFaxRQtkf6VcHAaVtDi1bKaAV0vf/4wkg1z5Grjx5I77IGy4wsRN8mEyvx6VL cBqPAMVtxxrTT3GcE8Qps7Kr/C1pz0JQLCmLZES3sVxFBzvIbAFnlQQpFmQ5SG/u AGnOG8KS9J5UwsRVNowdPhnwihub3MLxNbIEwunzUDOD3Atew8HeRmg4b1jjtzO+ lNUYeWrG7UYNxx5Kng1FD6F3+pZZ6g4YaRMMydmO6yPMLrDSxRbNWppaqP38cDiH gVpSLY06Df1QsiN+0vtc617I0wln5vXrtS5W0Gt4olzIZUDmixoJfSTvO8X8VmmU tgAWN2XZsrUNVarg3jTiEmVsqtgU752UWpyGwDaUhHGY6yJbNLLNWHy8/7sAAP/+ OjX1zGbY/Jarhaj/xDA8w/UfZzfcFyccsakJDgGbVpOPqECxFTDr0HBtnRLbRaos LZflCCSm =0w+y -----END PGP SIGNATURE----- --PEIAKu/WMn1b1Hv9--