Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8903C4338F for ; Sat, 24 Jul 2021 16:03:53 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C819260E91 for ; Sat, 24 Jul 2021 16:03:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C819260E91 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DCA1282EBB; Sat, 24 Jul 2021 18:03:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="bU6v37x/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 493BE82ECC; Sat, 24 Jul 2021 18:03:47 +0200 (CEST) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A689E80C8A for ; Sat, 24 Jul 2021 18:03:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82f.google.com with SMTP id t18so3809910qta.8 for ; Sat, 24 Jul 2021 09:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lfPj28R/5EB6/LA0g4mbpeB1nqWK2GizlRG2WN0p+28=; b=bU6v37x/yoSoyTzjAGVBPNxNQzUgLfa1DME7thEoMj54ELlNqUlkjt14cBfp3BG14Y doV4EzsinT+yCGnjJFc7lT0bSvssndZ1KiPuObR0Hyfbhe04PLDGuyI6ATaDhlvL+iTf //fBExiqHOE6fvpPt0SKkv301Oxp0XwMLn+3Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lfPj28R/5EB6/LA0g4mbpeB1nqWK2GizlRG2WN0p+28=; b=okZadKGdWwfmvjVdpul5sV6bvEcMwx95mp2tkY/kUPblyH7g126VRMBX2UdjCQXjue 6GWa3YHCKc6oqAuorqM0ZnISgaHqSCj3VLqZfFEJ6aVyiYZgCCUPdS6HnxKcbOxKbHnz rAGphyq0qZHfhGpof0Ip2BFqLAVoYn48tSLwmDRwZaoUeQbMwvEZXuTv3YzzSC/mPf5l UilBkcdi7thgYkiH1+HKjmWyksetyocscK6cTQLd5WkCX+Syt7qEg35fwbVQOwTJEtDX aNFk4wn1353pQnA904+zzE5NS9GsZdnlSL5HS8JCU1Gymm7qkHLDwc83aRpm/vv+tsPO T3ow== X-Gm-Message-State: AOAM533Z/4DKDN0EWUuBq7ALef14k3blBFfzI6+ODmmWcsnakW9HAPeA HY2eZ18decVMXhBeSm5h1s4cXg== X-Google-Smtp-Source: ABdhPJyMyrH+lrTv7yAKLGPSGIJcEC/+S4dNzJy03fNVzGiflC7DI0sk+x//fCHfar3cB0ipG6MbpQ== X-Received: by 2002:ac8:65c5:: with SMTP id t5mr8478056qto.157.1627142622316; Sat, 24 Jul 2021 09:03:42 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-5514-7b31-784c-a4c7.res6.spectrum.com. [2603:6081:7b01:cbda:5514:7b31:784c:a4c7]) by smtp.gmail.com with ESMTPSA id b23sm13352071qkl.113.2021.07.24.09.03.41 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 24 Jul 2021 09:03:41 -0700 (PDT) Date: Sat, 24 Jul 2021 12:03:39 -0400 From: Tom Rini To: Dennis Gilmore Cc: Michal Simek , Peter Robinson , U-Boot Mailing List , T Karthik Reddy , Ashok Reddy Soma , Pratyush Yadav Subject: Re: [PATCH] Revert "spi: spi-uclass: Add support to manually relocate spi memory ops" Message-ID: <20210724160339.GM9379@bill-the-cat> References: <20210722152529.1407976-1-pbrobinson@gmail.com> <0e9e0b0d-e363-379b-d63b-e4a3c73213d1@xilinx.com> <20210722173011.GC9379@bill-the-cat> <20210724032535.GL9379@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="S2FiTZAGpJjpxPt0" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --S2FiTZAGpJjpxPt0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 23, 2021 at 10:49:39PM -0500, Dennis Gilmore wrote: > On Fri, Jul 23, 2021 at 10:25 PM Tom Rini wrote: > > > > On Fri, Jul 23, 2021 at 09:46:44PM -0500, Dennis Gilmore wrote: > > > > > removing the header is not sufficient to have the boards booting from= SPI. > > > > > > U-Boot TPL 2021.07-00768-g49373a3334-dirty (Jul 23 2021 - 20:42:57) > > > Channel 0: LPDDR4, 50MHz > > > BW=3D32 Col=3D10 Bk=3D8 CS0 Row=3D16/15 CS=3D1 Die BW=3D16 Size=3D204= 8MB > > > Channel 1: LPDDR4, 50MHz > > > BW=3D32 Col=3D10 Bk=3D8 CS0 Row=3D16/15 CS=3D1 Die BW=3D16 Size=3D204= 8MB > > > 256B stride > > > lpddr4_set_rate: change freq to 400000000 mhz 0, 1 > > > lpddr4_set_rate: change freq to 800000000 mhz 1, 0 > > > Trying to boot from BOOTROM > > > Returning to boot ROM... > > > > > > U-Boot SPL 2021.07-00768-g49373a3334-dirty (Jul 23 2021 - 20:42:57 -0= 500) > > > Trying to boot from SPI > > > > > > At this point u-boot hangs, with the patch reverted I get the followi= ng > > > U-Boot TPL 2021.07-00769-g4af8bd872c-dirty (Jul 23 2021 - 21:20:51) > > > Channel 0: LPDDR4, 50MHz > > > BW=3D32 Col=3D10 Bk=3D8 CS0 Row=3D16/15 CS=3D1 Die BW=3D16 Size=3D204= 8MB > > > Channel 1: LPDDR4, 50MHz > > > BW=3D32 Col=3D10 Bk=3D8 CS0 Row=3D16/15 CS=3D1 Die BW=3D16 Size=3D204= 8MB > > > 256B stride > > > lpddr4_set_rate: change freq to 400000000 mhz 0, 1 > > > lpddr4_set_rate: change freq to 800000000 mhz 1, 0 > > > Trying to boot from BOOTROM > > > Returning to boot ROM... > > > > > > U-Boot SPL 2021.07-00769-g4af8bd872c-dirty (Jul 23 2021 - 21:20:51 -0= 500) > > > Trying to boot from SPI > > > > > > > > > U-Boot 2021.07-00769-g4af8bd872c-dirty (Jul 23 2021 - 21:20:51 -0500) > > > > > > SoC: Rockchip rk3399 > > > Reset cause: RST > > > Model: Kobol Helios64 > > > Revision: 0.0 - Unknown > > > DRAM: 3.9 GiB > > > PMIC: RK808 > > > MMC: mmc@fe320000: 1, mmc@fe330000: 0 > > > Loading Environment from SPIFlash... SF: Detected w25q128 with page > > > size 256 Bytes, erase size 4 KiB, total 16 MiB > > > *** Warning - bad CRC, using default environment > > > > > > In: serial@ff1a0000 > > > Out: serial@ff1a0000 > > > Err: serial@ff1a0000 > > > Model: Kobol Helios64 > > > Revision: UNKNOWN > > > Net: dw_dm_mdio_init: mdio node is missing, registering legacy mdio > > > busNo ethernet found. > > > > > > starting USB... > > > Bus usb@fe900000: usb maximum-speed not found > > > Register 2000140 NbrPorts 2 > > > Starting the controller > > > USB XHCI 1.10 > > > scanning bus usb@fe900000 for devices... 2 USB Device(s) found > > > scanning usb for storage devices... 0 Storage Device(s) found > > > Hit any key to stop autoboot: 0 > > > switch to partitions #0, OK > > > mmc0(part 0) is current device > > > ** No partition table - mmc 0 ** > > > Couldn't find partition mmc 0:1 > > > switch to partitions #0, OK > > > mmc1 is current device > > > Scanning mmc 1:1... > > > Scanning disk mmc@fe320000.blk... > > > Scanning disk mmc@fe330000.blk... > > > ** Unrecognized filesystem type ** > > > Found 5 disks > > > dw_dm_mdio_init: mdio node is missing, registering legacy mdio > > > busdw_dm_mdio_init: mdio node is missing, registering legacy mdio > > > busLoading Boot0000 'Fedora' failed > > > EFI boot manager: Cannot load any image > > > Found EFI removable media binary efi/boot/bootaa64.efi > > > > Is LTO on, on these platforms? That code in question really should not > > be enabled, at all. Like, if you toss an #error in that section of > > code, it should still build. It does, right? >=20 > It does still build if I put a #error in the middle of it >=20 > $ grep LTO .config > CONFIG_ARCH_SUPPORTS_LTO=3Dy > # CONFIG_LTO is not set >=20 >=20 > LTO is not on OK, so progress. What toolchain are you using here? And can you easily re-test with one of the kernel.org ones, or if using one already 9.2.0 (or 11.1.0) ? --=20 Tom --S2FiTZAGpJjpxPt0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmD8OdcACgkQFHw5/5Y0 tywprQv/YL+5yPt07hyEcyTedTbrSeXTlEH9vvc4hkYQ26vH6pqY8KyLiQFiXpje d5DJdw6dshKKnbNXlk2uHIJm4VuOn/5Q3VqvVTcvpCCpjCk6TD67OhVp+3QovCxl PiNO8TuIKJ4o1aPMBfFO+42WC5PcqzhpsXJ9QASJiQn1G/agS/9xTxxYFFhnlIC7 7yDFJnvmMJ9ODWpfguCJWpLxraO8h2U3JArLcRU6/FXAbo4igUZ2stmyXmVEi25N 5oWSn3UvESPWGf8Alrn730VECO38nG0s5WfI8/G3N8TCDqvjAt4xlPcOjj8FWPxP cIBJWUxGTU/JjyUOQWh/ZpQB73MyM0mr4zDeR2GOSUl4HfqW6UQG9+kSvQ10FsGM wXC8iI+qpNR22OFN5Fyd7tr/OginIwdIPH7SHaRvb7+SkdlErfquMVVJZd/99LRr pKyFjy9Kh/xCQJvS2lw4x28FzEXpVzHfxbeTv48UXdVAchK+W2iQ6bKyuRzDb62s rpaOn0/I =K5oJ -----END PGP SIGNATURE----- --S2FiTZAGpJjpxPt0--