Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54C9EC4338F for ; Sat, 24 Jul 2021 20:42:46 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B622360725 for ; Sat, 24 Jul 2021 20:42:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B622360725 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3C0DE831DD; Sat, 24 Jul 2021 22:42:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="uuO41Etg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A1364831BA; Sat, 24 Jul 2021 22:41:01 +0200 (CEST) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 81BFE831A4 for ; Sat, 24 Jul 2021 22:40:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf32.google.com with SMTP id jz6so3164628qvb.2 for ; Sat, 24 Jul 2021 13:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=keECLpuSF9jrbJDm9vrocalyrpNyXVaLYQfRi2Rj7A8=; b=uuO41EtgblFbElTSZ3l3PexuP74cKGZ8Ew15NigAo8kDJGlYFT84AA7HacMg6mnV8h 2h620FWyvbcNkiVh5g7mpzKntXEGC0R6mg57G0EylWTYen45KKc4xJo7Gg87YwEr4Vvw 7DGh5QKXof1ArztVKOHjOAj89vx+i0iJlSUOM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=keECLpuSF9jrbJDm9vrocalyrpNyXVaLYQfRi2Rj7A8=; b=J7AcFRNKQngBaJPYY0ylXyT8P2p6HNNp/l3HzXHdFQTyzZmOp/LW4jV//iiGs3/1pQ Awh6amUE0njrC/qBcrZkAJjclEcyTyuZ8r9Ug7jsfkTUNU9lL8xeA0p0ddKhBZrmppWp f9SDQrvK9eEIk0J/H+hJ/oam0qCyQAR3omrkLWqEsbW15BCJPZlInVDgWcUCSPtH46ST WwjxlZhAa/0NzS9o9h4O3OwwD6pzNMGXCMJgfiLtFzL0/sZZRkY7T+HCgnCLykviOy07 tggx9bGCxVY7dhd33A7xq672xJMNpr24Bh5cCF4kxQ5jgexbjCx7f47sdD1t1HiwlpCM rnCg== X-Gm-Message-State: AOAM531oHUQ1EgxHtyaUBQ5X2yfIQUAxXUb5rL5wRdohM65WIJQ1UhNy VZg125OIVWC7GPLW0TWKwuCkig== X-Google-Smtp-Source: ABdhPJxNpaTg+2U3tmliOMI1VHxpmOUGufzSgVFepPYD2ni8f0YYyRnWGKbbLvDNo2iacSgmasZ+5A== X-Received: by 2002:a0c:ef85:: with SMTP id w5mr8213705qvr.22.1627159251410; Sat, 24 Jul 2021 13:40:51 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-0853-2920-f0b9-3dd6.res6.spectrum.com. [2603:6081:7b01:cbda:853:2920:f0b9:3dd6]) by smtp.gmail.com with ESMTPSA id e2sm16800882qkn.69.2021.07.24.13.40.50 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 24 Jul 2021 13:40:50 -0700 (PDT) Date: Sat, 24 Jul 2021 16:40:49 -0400 From: Tom Rini To: Stephan Gerhold Cc: u-boot@lists.denx.de, Nicolas Dechesne , Ramon Fried Subject: Re: [PATCH 2/3] board: dragonboard410c: Fix fastboot Message-ID: <20210724204049.GY9379@bill-the-cat> References: <20210714085626.5961-1-stephan@gerhold.net> <20210714085626.5961-3-stephan@gerhold.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="H8by9uLkH0tJPK9x" Content-Disposition: inline In-Reply-To: <20210714085626.5961-3-stephan@gerhold.net> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --H8by9uLkH0tJPK9x Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 14, 2021 at 10:56:25AM +0200, Stephan Gerhold wrote: > At the moment pressing the volume down key does not actually launch > fastboot. This is because setting "bootdelay" to "-1" actually > disables autoboot and drops to the U-Boot console. It does not execute > the "bootcmd". >=20 > The correct value for "bootdelay" here would be "-2", which disables > the delay and key checking and would immediately execute the "bootcmd". >=20 > However, even better in this case is using "preboot" to trigger Fastboot. > The advantage is that running "fastboot continue" will actually continue > the autoboot process instead of ending up in the U-Boot shell. >=20 > Also make sure to unset "preboot" again immediately in case the user > saves the environment after triggering fastboot. >=20 > Cc: Ramon Fried > Fixes: aa043ee91a47 ("db410c: automatically launch fastboot") > Signed-off-by: Stephan Gerhold > Reviewed-by: Ramon Fried Applied to u-boot/master, thanks! --=20 Tom --H8by9uLkH0tJPK9x Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmD8etAACgkQFHw5/5Y0 tyxJNAv8CiAE4qsWUKq8GwQ4R57+mbfNpwL+ZBzunxB00KgSCZGQ8O2PCgERwAGX 4guzd6NkhnaAA5YaF7dt8kjZ4ZbDvGooS8cE28SF20G9xnQXv0cWgvStiOopHVAE gSZ/c9a1yo+75cKycjk3qDpimeVJ0uMBkYetUuNVb7Ph7gFDPbej1hlj3G8b+kfT MfajCNIRFDZwRRn7PS0dhFAsitJQQdctSyw/oUkNiLn//pU2k4ZExda5gHKsHB0Y WfEREVcMKa7eFWRL7S3VyJXt/m89AcPK3sOP97xaMdUy4nn7j4+OivL7VWEYG/LV 5u2CO3xmr4ihQd9azaPq2VTXyEN0CEsDE0SGoy3QQIGnVHU+nyMkFsZj3y+G9UII HvJCxJnqGB59/ntZ7BZHkKVO3ayawZ0SOFZtb8J6L6XvL6N6xdHvGgdh/OXKFujF M//l89l8x3RXdo50WLuc+i8hOuq5SEvLwHtKlfyNNPaHprQOsqJhnZ5FITPhFq9K MbHrWL9t =eWt0 -----END PGP SIGNATURE----- --H8by9uLkH0tJPK9x--