Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C0FDC4338F for ; Sat, 24 Jul 2021 20:43:48 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DECD60725 for ; Sat, 24 Jul 2021 20:43:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7DECD60725 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 439F4831F5; Sat, 24 Jul 2021 22:43:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="QfzAFeEG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 40DF4831BB; Sat, 24 Jul 2021 22:41:05 +0200 (CEST) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A91AC831CC for ; Sat, 24 Jul 2021 22:40:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72a.google.com with SMTP id t68so4992236qkf.8 for ; Sat, 24 Jul 2021 13:40:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ziOwH9cZpBSifY1wf59sl96ZB2vWT4HLWZRYzd/VJsM=; b=QfzAFeEGD7/9e0nECpHvX4gUK6f6NcF7APXPca8Y/zkuHbltC/+GitMB4Sk/pcTkAr +MsGXP7hvKOljWw7KplcEAujzsQYROrveaK+1/0G9IiIwxTzTdVG4AethDNOqXtPp5J7 P/jJqtgNx6DQ1m9YQrxhKHrtPU5jZmO8mUa74= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ziOwH9cZpBSifY1wf59sl96ZB2vWT4HLWZRYzd/VJsM=; b=iE3r/7gza2zUgEIZJypztL/psfIxZEl2u1Jtl+DZxYdRxTCfDBwMietQGJUMz/PC+o QX0UCLVFQVNuYefxW7xIMGpXboCd+0ug0b0vKaAHf4ADII7uz27FGx9pedpOgV7O49u0 vB6YqXv1pIh7WVfBeZLWHx5hsuRESrTLUSvgat74QOhRYwIKyArAX434YaVSHF/yp4BZ mNyNJVd4h51TIvPZO6DGdqKnw0RDI9lCbakaA7rImD9+xjGdppWE7XxQB8ONFqRXcACH AMQQwx1sTyMeIN9jlRFgig1Uhfa3BcQpsO8dcfUD0MvcYy9qoWBbl7CC/e4ARgtNA3b5 XgCA== X-Gm-Message-State: AOAM531lBjqZ5I++yDqw2LxIwBgs4cMOVivCSZcMMctA4j2zkkHZ8lJ0 06XTbc+32RYFwARSss2fofPzeg== X-Google-Smtp-Source: ABdhPJxldg3IQfm9Zum0Kr1cIu7n8p0UzBMUVKw7rSJNxjfw44b3uVIyeVu98REpE9fEDY02tosW/A== X-Received: by 2002:ae9:e60a:: with SMTP id z10mr10889539qkf.258.1627159255578; Sat, 24 Jul 2021 13:40:55 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-0853-2920-f0b9-3dd6.res6.spectrum.com. [2603:6081:7b01:cbda:853:2920:f0b9:3dd6]) by smtp.gmail.com with ESMTPSA id d25sm12993283qtq.55.2021.07.24.13.40.54 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 24 Jul 2021 13:40:55 -0700 (PDT) Date: Sat, 24 Jul 2021 16:40:53 -0400 From: Tom Rini To: Stephan Gerhold Cc: u-boot@lists.denx.de, Nicolas Dechesne , Ramon Fried Subject: Re: [PATCH 3/3] serial: serial_msm: Delay initialization to let pins stabilize Message-ID: <20210724204053.GZ9379@bill-the-cat> References: <20210714085626.5961-1-stephan@gerhold.net> <20210714085626.5961-4-stephan@gerhold.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aEj7SNOwuMqsAi92" Content-Disposition: inline In-Reply-To: <20210714085626.5961-4-stephan@gerhold.net> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --aEj7SNOwuMqsAi92 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 14, 2021 at 10:56:26AM +0200, Stephan Gerhold wrote: > For some reason, the DragonBoard 410c aborts autoboot immediately if > U-Boot is started without LK. It looks like it picks up a single broken > character via serial and therefore believes a key was pressed to abort > autoboot. >=20 > After some debugging, it seems like adding some delay after pinctrl > setup but before UART initialization fixes the issue. It's also worth > mentioning that unlike when booting from LK, the pinctrl setup is > actually necessary when booting U-Boot without LK since UART is broken > if the pinctrl line is removed. >=20 > I suspect that reconfiguring the pins might take some time to stabilize > and if the UART controller is enabled too quickly it will pick up some > random noise. Adding a few milliseconds of delay fixes the issue and > shouldn't have any other negative side effects. >=20 > 3ms seems to be the minimum delay required in my tests, use 5ms instead > just to be sure. >=20 > Signed-off-by: Stephan Gerhold Applied to u-boot/master, thanks! --=20 Tom --aEj7SNOwuMqsAi92 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmD8etUACgkQFHw5/5Y0 tyylawwAiKUjPUO08itPcNSx2vtdzMSQ/XOntLDwiOsdPyBQrrfWy2nx36VHAZue 78GEjp4pwLn+ikn2qGUwFuTIbzqYuFN6oJ0pxld80zCO9LdsKXSUFcskBZ7q5SBi DcopQGWl6BmpsRATueGdUnDFtAje0xt2CeJE8qSM3o58meaapYAgiVrGTaKn1tyR LvL3D1eIZ6awnozgA8VUQ4GzbT3rErnVhiC2jKQeb26Pr8/Zs04NW1vK6gbYPJf4 pAG+Cm2Z2EWtr/cVxXNasqRwyMyohHxnrKEnCicxzy8MJU256KPspCvD76fs1kCE mhCWuAD+jFZ31E9s6vcLJACApjBrC6wYLrPZiJc4+H3DI0B1/aZ5dxJrHCBYaKM/ ihF/5EXfCZtOadV43Ite+TN4Ttoz5N6fNW25tYnZmpt56qgEy1zVBzrrd/69EpxP 50q1QG4n2q2ezB19fQAWZWcFWAnX+yvn3+vszPheiCo3jAo3sauRkuGBTJt2x1rE Id1vfdiM =BNid -----END PGP SIGNATURE----- --aEj7SNOwuMqsAi92--