Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9B91C4338F for ; Mon, 26 Jul 2021 02:02:09 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2EFC60720 for ; Mon, 26 Jul 2021 02:02:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B2EFC60720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A76FE8325E; Mon, 26 Jul 2021 04:02:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="HDuGRQ2k"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E992783260; Mon, 26 Jul 2021 04:02:03 +0200 (CEST) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D853E8325E for ; Mon, 26 Jul 2021 04:01:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72b.google.com with SMTP id c18so7509322qke.2 for ; Sun, 25 Jul 2021 19:01:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RR3bsox9SsPVnscKZC3JttnC+EIxmWfvywhK0kLCtyk=; b=HDuGRQ2kKWfNy3o9TOazfJInhxo7GuC3tiKkqGuTKCpalFHfUSKwSZ2k7mmJf4CiIC qdcDljbEdpVH2kwfzpqhUdlSduejcf7GH6+Gc42aa025CAA21B0zDQhSZB1bSwl07Aj8 9tOljZXEMdczK92nM+k2ARtZN/JyH+i4YXTkk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RR3bsox9SsPVnscKZC3JttnC+EIxmWfvywhK0kLCtyk=; b=rO+3sg3lE8fVXM/naVBo8d7kl514DBjJOJORqgGltBQaTrWvGSGItq1y5QR/dPpBeb sMI6CQhZ3ahCE5QErgzvDBMcoTYHmggV36k/xkEAmifXJ5IOXznDuTyG1M0ABvee4ldL jEysY9ejIO8pHYswUd7xR1/7r9RcIn1sYhmaFTr0Ufi/S6EAPnHB6IAuezZlCkCfYwFA JM6JB+mUNpgFmMeJGjtDgmvdVjVG4ZMg2nHoeeyAMnlydtF2LHS+srVxIuIhxqvRkBH/ 2PlK9HOhhaTi0RdKh3Ju6qDYD6Lqf/kLUn6EyRMEr2BIILjMn18FtQXZlXRNgGs/I1wm kVxA== X-Gm-Message-State: AOAM5302TFgZB9DfIvZ6FrO+Pjk4lETxmgOgAkTPq3qFsxy1bPy78w5O go/ewK9IfisJgNMvI54Q8owazA== X-Google-Smtp-Source: ABdhPJwLPyhjCnFUiGZN6rTTQZehMZsJF5lbW3L8MVwCMQsmB69U5RqNdpZ2mpCT576NjNSUmcaayg== X-Received: by 2002:a37:858:: with SMTP id 85mr15555711qki.70.1627264917430; Sun, 25 Jul 2021 19:01:57 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-5449-b89b-3de4-1412.res6.spectrum.com. [2603:6081:7b01:cbda:5449:b89b:3de4:1412]) by smtp.gmail.com with ESMTPSA id q4sm1974484qtr.20.2021.07.25.19.01.56 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 25 Jul 2021 19:01:56 -0700 (PDT) Date: Sun, 25 Jul 2021 22:01:54 -0400 From: Tom Rini To: ChiaWei Wang Cc: "lukma@denx.de" , "maxims@google.com" , "sjg@chromium.org" , "u-boot@lists.denx.de" , Ryan Chen , "joel@jms.id.au" Subject: Re: [PATCH v3 06/14] common: fit: Use hash.c to call CRC/SHA function Message-ID: <20210726020154.GI9379@bill-the-cat> References: <20210720063839.1518-1-chiawei_wang@aspeedtech.com> <20210720063839.1518-7-chiawei_wang@aspeedtech.com> <20210724125720.GA25851@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IyX+qZsYMJ8Y4LOh" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --IyX+qZsYMJ8Y4LOh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 26, 2021 at 12:06:28AM +0000, ChiaWei Wang wrote: > Hi Tom, >=20 > > From: Tom Rini > > Sent: Saturday, July 24, 2021 8:57 PM > >=20 > > On Tue, Jul 20, 2021 at 02:38:31PM +0800, Chia-Wei Wang wrote: > >=20 > > > From: Joel Stanley > > > > > > Currently the FIT verification calls directly into SW implemented > > > functions to get a CRC/SHA/MD5 hash. > > > > > > This patch removes duplcated algorithm lookup and use hash_lookup_algo > > > to get the hashing function with HW accelearation supported if > > > configured. > > > > > > The MD5 direct call remains as it is not included in the hash lookup > > > table of hash.c. > > > > > > Signed-off-by: Joel Stanley > > > Signed-off-by: Chia-Wei Wang > >=20 > > While this is a good idea, there's some required prep work. At least t= he > > following platforms don't compile due to this patch: > > ls1046ardb_qspi imx8mm_beacon imx8mn_beacon imx8mn_beacon_2g > > imx8mm-icore-mx8mm-ctouch2 imx8mm-icore-mx8mm-edimm2.2 > > imx8mm_evk imx8mn_ddr4_evk imx8mn_evk imx8mp_evk imx8mq_evk > > imx8mm_venice imx8mq_phanbell phycore-imx8mm phycore-imx8mp > > pico-imx8mq verdin-imx8mm mt8183_pumpkin mt8516_pumpkin mscc_jr2 > > mscc_luton mscc_ocelot mscc_serval mscc_servalt mt7620_mt7530_rfb > > mt7620_rfb mt7628_rfb > >=20 > > Which is likely due to cases where HASH or SPL_HASH_SUPPORT are not bei= ng > > selected as it was not previously required. > >=20 >=20 > Thanks for the notification of this error. I will examine the code flow t= o figure out the root cause on these platforms. >=20 > Meanwhile, Simon also suggested the need to add a new UCLASS_HASH to refa= ctor the hash structure. > http://patchwork.ozlabs.org/project/uboot/patch/20210720063839.1518-4-chi= awei_wang@aspeedtech.com/ >=20 > I was wondering if I can prepare another leading patch for UCLASS_HASH an= d also to make sure the current codebase works fine? > After that, we can restart this patch series for Aspeed FIT booting. OK, sounds like a good plan, thanks! --=20 Tom --IyX+qZsYMJ8Y4LOh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmD+F48ACgkQFHw5/5Y0 tyzUngv+Mm6Sxvegsev1vR7MTrmk++NuZXGUQTQ99KCkIU8C3Qz+OFsyvWVJCIq8 DKo1iAxHmsUXAkY34bAbkpI1bZNfc1HXrbi593zLCaTPdHjKrhP6mtt0hnlE0yaq nMa6plm2IQ6tLVJlFNALaOBJVDHR11MOQZ2thiqJF90XOUoElCsjEDqLDQ+RmE9g /2I92puUpaN9wBtrBy6JmAGoD3uVwpteRNG1CZyW3r6tePACvGJvKOK/FoKMEZ0t VUD+vkmfsDv63ia86jOzWFG7sFYPNQw/cHrG9Zmk/kRGyfJlqNAKTus4TdJ0IxcT x4p4QZxgkvPKW9DlKZrZ3P3vPEoXPRzkT8c+z72lstS/aV30C6FSnshIwQkAHd+Y ZDvKxuRl8b5up0oYxzqZNE2/qWsGw6pFvrVZGUThoNBszDgBny4gSx7Jfgyf8ot1 YrVOCMZZ1Edy/eCPDgjOV4iAuxQ9AVJ99lD6PUvscmt8p4qitJmqzRB7N6N3Ksjm q1cupeGh =Wzuz -----END PGP SIGNATURE----- --IyX+qZsYMJ8Y4LOh--