Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF26AC4338F for ; Mon, 26 Jul 2021 13:30:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99FF260F02 for ; Mon, 26 Jul 2021 13:30:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233521AbhGZMtm (ORCPT ); Mon, 26 Jul 2021 08:49:42 -0400 Received: from verein.lst.de ([213.95.11.211]:45205 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233194AbhGZMtm (ORCPT ); Mon, 26 Jul 2021 08:49:42 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 49D6767373; Mon, 26 Jul 2021 15:30:07 +0200 (CEST) Date: Mon, 26 Jul 2021 15:30:06 +0200 From: Christoph Hellwig To: Andreas Gruenbacher , Matthew Wilcox , Christoph Hellwig , "Darrick J . Wong" , Huang Jianan , linux-erofs@lists.ozlabs.org, linux-fsdevel , LKML , Andreas Gruenbacher Subject: Re: [PATCH v7] iomap: make inline data support more flexible Message-ID: <20210726133006.GB6535@lst.de> References: <20210723174131.180813-1-hsiangkao@linux.alibaba.com> <20210725221639.426565-1-agruenba@redhat.com> <20210726110611.459173-1-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jul 26, 2021 at 09:12:44PM +0800, Gao Xiang wrote: > I tend to leave it as another new story and can be resolved with > another patch to improve it (or I will stuck in this, I need to do > my own development stuff instead of spinning with this iomap patch > since I can see this already work well for gfs2 and erofs), I will > update the patch Andreas posted with Christoph's comments. Yes, let's do the minimal work for erofs needs in a first step. After that I hope I can get the iomap_iter change in and then we can start the next projects. That being said moving the copy back to the inline data to writepage does seem very useful, as does the "small" blocksize support from Matthew.