Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54F2AC4338F for ; Tue, 27 Jul 2021 03:52:00 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D48660F9E for ; Tue, 27 Jul 2021 03:51:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9D48660F9E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 460BC832DC; Tue, 27 Jul 2021 05:51:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="H1ToacIJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A847D832DC; Tue, 27 Jul 2021 05:51:55 +0200 (CEST) Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EEE9083358 for ; Tue, 27 Jul 2021 05:51:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf29.google.com with SMTP id x12so2757827qvo.12 for ; Mon, 26 Jul 2021 20:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0RO9Qj+feYxKJhIMiF6BY7XJAybF43IxFxBkbYSx4xc=; b=H1ToacIJSgiEVKYME3IsZGP2AArA1TFFz/+KoIj3DieQTchAFk2XsGyzL/x85h6js1 xeEX+BhV6DOyAugt9gcPf46cPU6j+TuifTYmVqpHtSFlWbMdJZdsSEseDCtytB6UZUi2 +HF5OSjegQhsij8trPg4/TaZ5U2X1op/BPxGS+bT4+kVfK+VMEcioSZ6zBGN9L60pTS/ H8urmY50L3TVxN85TGTaeyFPf6jo9+Gm/TOSobZnL0j9WSKyb+c157BGNlV8efa58UH2 wKLR6rYpx1D7YNNsB5z+Gaus1oOEH+8Hd8fThFaKfmXVPDoDyHwxkC0WxPhVSPrv9Tx2 gU0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0RO9Qj+feYxKJhIMiF6BY7XJAybF43IxFxBkbYSx4xc=; b=huyRAwxPstb5SO46AX59+Ond8lq4BCAJYwkTca9zkGXG7wGI6pO6+St9lTc1Of1F03 iYDpfAhJK6i+7TnObz/XB3AeS01jDwxtXQbnGNoDxMJp4B1d7UoGlXVuv5b6FuJC1/H+ sDiltsrRcGbb8UeE92gJ364GwoQlkXk6bMOoxt5QWvAajEBIIs/84EaQxdOPF3SPQitA 5wUQ0YZ77/Wi7BeaH/6OqKPkxyyHoUVVgl+k2eFnaVly+6lp8PUIE8zoA0ircRJj7zAz SPn9RPhrs4D9G9etW0AUVuH0vDeK/pvZ1KpOTGaU+CGWhS2XyPNlk1LxAr1N2+/yMF83 Fdpw== X-Gm-Message-State: AOAM530QkNyd1aATO2F905NshnYeZtT6zxgi6cEMh1RKMUe9BGQ7g9ZX 6kYmpaiR8q3tYsapoqgICa8zK7Qn27Y= X-Google-Smtp-Source: ABdhPJxhBxJLCagaaF/6leM4PUs761XMgasjtC/jb5ecv3LFIOcDZWXIAUIxSBqU5DNfo8lRwRO9fQ== X-Received: by 2002:a05:6214:1303:: with SMTP id a3mr21065140qvv.49.1627357908485; Mon, 26 Jul 2021 20:51:48 -0700 (PDT) Received: from godwin.fios-router.home (pool-74-96-87-9.washdc.fios.verizon.net. [74.96.87.9]) by smtp.gmail.com with ESMTPSA id y67sm1096211qkd.58.2021.07.26.20.51.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 20:51:48 -0700 (PDT) From: Sean Anderson To: u-boot@lists.denx.de, Leo Liang Cc: Lukasz Majewski , Damien Le Moal , Sean Anderson , Coverity Scan Subject: [PATCH 1/4] clk: k210: Fix checking if ulongs are less than 0 Date: Mon, 26 Jul 2021 23:51:41 -0400 Message-Id: <20210727035144.298277-1-seanga2@gmail.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Some clock functions return ulong but still have "negative" errors. To deal with this, cast the relevant arguments to long. Fixes: 609bd60b94 ("clk: k210: Rewrite to remove CCF") Reported-by: Coverity Scan Signed-off-by: Sean Anderson --- drivers/clk/clk_kendryte.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/clk_kendryte.c b/drivers/clk/clk_kendryte.c index 3148756968..37bd624eca 100644 --- a/drivers/clk/clk_kendryte.c +++ b/drivers/clk/clk_kendryte.c @@ -439,7 +439,7 @@ static const struct k210_clk_params k210_clks[] = { #ifdef CONFIG_CLK_K210_SET_RATE static int k210_pll_enable(struct k210_clk_priv *priv, int id); static int k210_pll_disable(struct k210_clk_priv *priv, int id); -static ulong k210_pll_get_rate(struct k210_clk_priv *priv, int id, ulong rate_in); +static ulong k210_pll_get_rate(struct k210_clk_priv *priv, int id, long rate_in); /* * The PLL included with the Kendryte K210 appears to be a True Circuits, Inc. @@ -841,7 +841,7 @@ TEST_STATIC int k210_pll_calc_config(u32 rate, u32 rate_in, } static ulong k210_pll_set_rate(struct k210_clk_priv *priv, int id, ulong rate, - ulong rate_in) + long rate_in) { int err; const struct k210_pll_params *pll = &k210_plls[id]; @@ -890,7 +890,7 @@ static ulong k210_pll_set_rate(struct k210_clk_priv *priv, int id, ulong rate, #endif /* CONFIG_CLK_K210_SET_RATE */ static ulong k210_pll_get_rate(struct k210_clk_priv *priv, int id, - ulong rate_in) + long rate_in) { u64 r, f, od; u32 reg = readl(priv->base + k210_plls[id].off); -- 2.32.0