Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2007CC4338F for ; Wed, 28 Jul 2021 23:44:05 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 109EA6103E for ; Wed, 28 Jul 2021 23:44:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 109EA6103E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DD11182D82; Thu, 29 Jul 2021 01:44:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="MER02j/n"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2010782DB0; Thu, 29 Jul 2021 01:43:59 +0200 (CEST) Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A7C9182D73 for ; Thu, 29 Jul 2021 01:43:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x736.google.com with SMTP id z24so4071892qkz.7 for ; Wed, 28 Jul 2021 16:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hux2weOGW463nhsJ8NsxgtAB+s/Pskl8Zfffug7dAT4=; b=MER02j/nMHfdnNKmwqAklxQrjguigBFouNjyLEImThsMFZudKfP+rUjPvPrTM0oPX+ hIybpdt0QBAajMmamgjeM8qE5P8Q+MLnVo8fVhF9J+uCOXXBpTQl1kJbZQX3Cj9z1ebR XvPCZjAd03iB4lyZ6CNW9fft0H5AMHxaE6pio= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hux2weOGW463nhsJ8NsxgtAB+s/Pskl8Zfffug7dAT4=; b=Nq9hHiUtoi4TgfdQINtX9nDr9mEVfLH6HIpernY/4Qi1IJuANY9dV/HtPEg064MA5v qia2pPM5+BkvhUKkWto33t+nqcpxlHRHBtF/ULYgiI0tIQz8wp4UZF4NDKOzMAHU9oES KrnUtEdNGJWwGVuWpvR7uIAStvUjAZfjf5pLO9lZQmtxFJDyC9NLboz1JhYZwNYX/ebF FBndSqbQblX5ZQHOx1u86zzHaKYQsW+JKZqK/5VZ25vq27IMfx4loTFy/a1nZGsNtrPP h8JaFTxsvjDh9MZhlXlrHs+Paa9xHn8l2+bfnztlUWuorSbi0HDzTeMFIDZfc4PJ+h1f QREg== X-Gm-Message-State: AOAM530BLkLstj86v0xHEJm4XjkF1C8UPvN/VOidRxTapL2iBchu9QI5 e6KbVeQtb+GABk9ZZGPMPfaWIA== X-Google-Smtp-Source: ABdhPJzZuGzITNC3BKaSFx7Vj5AXrjRv6BCwShwB7CP9BL1m+UvnxlMYdgvs4bwPzLn3AVN4Oa/s8g== X-Received: by 2002:a37:9085:: with SMTP id s127mr2222857qkd.215.1627515834523; Wed, 28 Jul 2021 16:43:54 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-3037-3a3d-435c-0707.res6.spectrum.com. [2603:6081:7b01:cbda:3037:3a3d:435c:707]) by smtp.gmail.com with ESMTPSA id z29sm858891qkg.9.2021.07.28.16.43.53 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Jul 2021 16:43:53 -0700 (PDT) Date: Wed, 28 Jul 2021 19:43:51 -0400 From: Tom Rini To: Artem Panfilov Cc: "Alex G." , "u-boot@lists.denx.de" Subject: Re: [PATCH 1/1] lib/ecdsa: Fix LibreSSL before v2.7.0 Message-ID: <20210728234351.GI9379@bill-the-cat> References: <20210728181023.25067-1-panfilov.artyom@gmail.com> <21fa035a-7ab5-7045-dd47-90670eb8be14@gmail.com> <20210728200701.GY9379@bill-the-cat> <34cdf0ed-c97d-e5ec-31ff-24e4ca085c4d@gmail.com> <20210728225619.GB9379@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zBuBUmsEsxAzMXHf" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --zBuBUmsEsxAzMXHf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 29, 2021 at 02:37:10AM +0300, Artem Panfilov wrote: >=20 > On 29.07.2021 01:56, Tom Rini wrote: > > Part of the question is then, were you enabling the SSL-related parts > > before this change? Or did the way the code is now being > > enabled/disabled trigger this now being enabled when it wasn't before? > > > This commit broke the build: > https://gitlab.com/u-boot/u-boot/-/commit/cb9faa6f98ae56d70d59505dad290dd= 3d381cb7b OK. How? Or rather, what part of that is causing previously unbuilt code to now be built? > Our testing board defconfig: > https://gitlab.com/u-boot/u-boot/-/blob/master/configs/hsdk_defconfig OK. > I also found this patch that was committed 4 months ago. > It includes OpenSSL compatibility for old versions: > https://gitlab.com/u-boot/u-boot/-/commit/fbc777429fa35312a9ea5f106692172= d3153e659 Yes, true. And that's two 1-line if/else. That's a reasonable to me level of effort to keep supporting older hosts. Your patch is adding in 60 lines. I really do want to dig a bit more here. And honestly, part of my concerns also go around "who is going to maintain / test this area?". We don't have these older versions in CI (or we would have seen the problem before merging). Are you volunteering to support the relevant code areas here but on older openssl/libressl ? --=20 Tom --zBuBUmsEsxAzMXHf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEB67AACgkQFHw5/5Y0 tyyK4wv8Cjh5CRRxtb3AruHlYTdmRGbRjU2yeuwatyQ/ooWyWcx8QzEhxEcEfYZm QCg6COk519dBMdK9Sg6Uw/MCHU7w/K8W2yddC26FrjkLdOPO1OB5b8AwDSH8MMCy CUn+AujWtUbA43F2AL5TFCKHUqeZiZACgyOorlrctKJrHh2WtTB6bA5cx54PGY4u GPBzRNKnEO8m81RE1R1NpJEOS3g/w5ADBhmfBL5RM8LScFMdy8knjGUtgKsaObMb ikEuNFJtD202QGAA6Ggb7C3hiTJPA+bzpErQ7Jqm4m684AZoQwnhI5jmPaX6fvjL yBV0UJAGFFi1Do/2m0Rg5fh0aV26P3N+CazvHp82Uq+cezX0sbSPua69MlKBIzMu KXcuIE04Is5f8ZBLqzm2KHDLlwa6XTtKmSpGuBOD9rWPmgFQtdmQZJRxYl1N4sJv ueiNGcsn27e8WoYhJmbNXNG1MvQTnyXuq/Q0hCGCj6dbWcbgIE/hdPxraWEyYd9y jTciYbOL =/CRc -----END PGP SIGNATURE----- --zBuBUmsEsxAzMXHf--