Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9388C4338F for ; Sun, 1 Aug 2021 23:47:03 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C051560F90 for ; Sun, 1 Aug 2021 23:47:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C051560F90 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4DE60831D6; Mon, 2 Aug 2021 01:47:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="inpxFKjQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BCAC7831CC; Mon, 2 Aug 2021 01:46:57 +0200 (CEST) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 42818829C6 for ; Mon, 2 Aug 2021 01:46:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72e.google.com with SMTP id 184so15112966qkh.1 for ; Sun, 01 Aug 2021 16:46:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YBC5hYbAYzmWelYkhIV5XrY76hJQuTslRvlaQV/8hxg=; b=inpxFKjQPQUA76tY4BAcmeemw8sM3+7u7uSWqXYGodHZWHpHiIxHibKDVOFrKLyVMG tddl3JlICvZxOznyks0mUzm5nuSOv5BWc0j0leVl4qJzUMec55mFazlCE0rwc00zBWkl ZFp98zcTc7a04DjbFw1mg/wUcLFye/BrKWiYY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YBC5hYbAYzmWelYkhIV5XrY76hJQuTslRvlaQV/8hxg=; b=THUfVf6mlZWOlhzsGNJm46N8b0f1n9SbC+kJSCKKFuGKxlVxUOcyHIenZAL/TO2I5H SV0YfIJ7GMeEvWHohQtukEPzRK5dMzwANPhuxB7IxiMqZr0U+jBDziJQQVEQ6TBLgYQt Ykal352OtNn9OlSlRcWN1rLLntgO4hstWd6Sq/mPdEOy4dcLU3hbOiMbeBjWtWOqqzT2 Ljitij/ul2PajwB2CPcJGrPVD02B1z4ZFKqWAK/GkbVXNBv4hBNTmOQxG+G1cUYpTi/r aFnqr9zKxGOR7SyRz2u0NGdgVsxQdgKXiIAlr+ICZut92Ho2rPV4/rzxkTpX52FyxFEt +O1w== X-Gm-Message-State: AOAM532EIvwVoCJ5nUmYS02OWvG+5JOWWL/tf95kQjWQLlc2nxHJxm20 osGdI0TQajsgKfYWT8EU0ue8uA== X-Google-Smtp-Source: ABdhPJw4YmLCoz2XHRzfeOkGhtks0bHLwmOSus4BCFf2rTzWhER1jQ0FHBQMpkYfgFlOfsExuKWEfg== X-Received: by 2002:a37:a992:: with SMTP id s140mr13110276qke.392.1627861612990; Sun, 01 Aug 2021 16:46:52 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-ed77-66b8-7f0a-3b78.res6.spectrum.com. [2603:6081:7b01:cbda:ed77:66b8:7f0a:3b78]) by smtp.gmail.com with ESMTPSA id x14sm3851783qts.13.2021.08.01.16.46.51 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 01 Aug 2021 16:46:52 -0700 (PDT) Date: Sun, 1 Aug 2021 19:46:49 -0400 From: Tom Rini To: Simon Glass Cc: Heinrich Schuchardt , U-Boot Mailing List , Alexander Graf , Ilias Apalodimas Subject: Re: [PATCH v2 4/5] efi: Use 16-bit unicode strings Message-ID: <20210801234649.GP9379@bill-the-cat> References: <20210718201426.759240-1-sjg@chromium.org> <20210718201426.759240-5-sjg@chromium.org> <20210719010144.GF9379@bill-the-cat> <4838b1ef-8ad1-a4da-e3ee-d3daa21ff520@gmx.de> <20210719013642.GH9379@bill-the-cat> <20210801032836.GI9379@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YBvFKvyrw8Qeqs3/" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --YBvFKvyrw8Qeqs3/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 01, 2021 at 04:54:49PM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Sat, 31 Jul 2021 at 21:28, Tom Rini wrote: > > > > On Sun, Jul 18, 2021 at 09:36:42PM -0400, Tom Rini wrote: > > > On Mon, Jul 19, 2021 at 03:07:50AM +0200, Heinrich Schuchardt wrote: > > > > On 7/19/21 3:01 AM, Tom Rini wrote: > > > > > On Mon, Jul 19, 2021 at 02:41:46AM +0200, Heinrich Schuchardt wro= te: > > > > > > On 7/18/21 10:14 PM, Simon Glass wrote: > > > > > > > At present we use wide characters for unicode but this is not= necessary. > > > > > > > Change the code to use the 'u' literal instead. This helps to= fix build > > > > > > > warnings for sandbox on rpi. > > > > > > > > > > > > > > Signed-off-by: Simon Glass > > > > > > > Suggested-by: Heinrich Schuchardt > > > > > > > > > > > > According to https://en.cppreference.com/w/c/language/string_li= teral u"" > > > > > > literals are supported since C11. In our Makefile we have CSTD_= FLAG :=3D > > > > > > -std=3Dgnu11. > > > > > > > > > > > > Once we have changed all u"" to L"" we can remove -fshort-wchar= from our > > > > > > Makefiles. > > > > > > > > Sorry, I meant 'change4 all L"" to u""'. > > > > > > > > -fshort-wchar interpretes all L"" as 16bit strings. > > > > > > Ah, OK. So, still, time for an spatch? > > > > So to be clear here, I would like to see this fixed with an spatch as > > the way to solve this tree-wide. >=20 > Can you please explain what you want done with spatch? So far as i can > tell, I changed all L strings to u strings. What else is needed? It was unclear to me that you fixed the problem tree-wide here. If this was all of them, tree-wide, please follow-up dropping -fshort-wchar from the Makefile please. --=20 Tom --YBvFKvyrw8Qeqs3/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEHMmMACgkQFHw5/5Y0 tyyhKgv/W9a5Xc/wBf7tT4D9OxzqhB1Esi4Dksx+qMhMp9p81X6v7GBj7ErirBaX l95TAEEpbTSK7t59l6stcrpcp/cmBAuWVv6EqijRVh9++2GasBgc7tMlo032dorK gHxp+36zagzs5uwUmF4H4v+3B87/UReLvnTGgMUN3kNf/1UKjTmMM5+GQuI6FB5p xZqi9Tn3fDUeiVLx08gXWv4NeXJRatT/8tiobFjNicJ+gW0b23PJejGmddtc8muV yqEc4CoXHVsfA3jHPo+tEwt0jXHwmCdouV/YUq8jykd0hNXnowbY6Pjsc5ZUs8bB EsVrJbVv79GFfAqPjZd/JLKWSokek4mly5ZmnjKi7Gc/FzCWDv9H3Mvtgh4aJcnT FwRKGNw9To8ZKmQEG/cL2V8KKOMAk9gr77KP0WTt9YfCJK7W0moaFEg67LxLxQ5I v28rzGbos5JV8iw2ukg7cqGr+yPBU+L4EeOmR/YI/rrHR9Kq75jPIxIFhGaWL1vz NlKLiwsa =Vyjs -----END PGP SIGNATURE----- --YBvFKvyrw8Qeqs3/--