Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF3EFC4338F for ; Mon, 2 Aug 2021 15:56:09 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3022A60EB2 for ; Mon, 2 Aug 2021 15:56:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3022A60EB2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4785982CDC; Mon, 2 Aug 2021 17:56:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="oIswaaI8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 69D92833E6; Mon, 2 Aug 2021 17:56:05 +0200 (CEST) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 06B0C82BCE for ; Mon, 2 Aug 2021 17:56:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x831.google.com with SMTP id a12so11952744qtb.2 for ; Mon, 02 Aug 2021 08:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ioZDk/RrPVkY4h016kdnicVdieSSlM6QVdqCFwa3fgs=; b=oIswaaI8cp9088I+2m26xuG681JZx3PfvhyByABy19T2R71DfXEgxhuOVcpxVQAShm 8PwCstDQF+jdYOStsUPyQ0TXZFmeF4PO1x9W8wXMpxWyZNeRSY9FagvutcAnbLcaFjoT n2dypPGvADgwoFHAtPNRpzXyY/lw+k7VlpAS0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ioZDk/RrPVkY4h016kdnicVdieSSlM6QVdqCFwa3fgs=; b=geJuD6W2zIImAC72DBZI1fcgBXi9xTnaCjFJ3kkVT0z/WPjydFsI/2CrFOOioPYMNW dsbKjtEnprNw3bMuAqaU+RhUubItuYSAvRAPpN4ihzg6cIlRtknToDZJsFh/pstavCaM kAEkHQGf9vTiIuJgvpznv+34K+quvdQsGvahWzoeQA9iNleZUmQ76dbB6UJgDZEqsW8z lsWTdcT+vaorF7PprDhHMtxo+apeoRfxPARIwg/YGcJ0c2jeG+rUquo+PziFymy7z9Dc Fy3TJgqyfEUM9c7B/U185UMt9OgXXWrZDf4PsSS7Q9W3lWpzFU/k6xAgOx7mCwbXoksl qJxw== X-Gm-Message-State: AOAM533YW7jGHucqtpgnRwwrWu62ZdbeMzigwv7v0So1IF9Xwm8SFSJu PoRsxZuUxuOUIeGILDw3172myA== X-Google-Smtp-Source: ABdhPJxTnWONb9A3Z6QFKVZ7s/fCI/RrHtDvQvPv6AbQyJYSwZeSpCjsvkYm8vSwhon3o8A/bEzZPw== X-Received: by 2002:ac8:5a96:: with SMTP id c22mr14299778qtc.229.1627919760776; Mon, 02 Aug 2021 08:56:00 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-a0a3-ef76-0712-405d.res6.spectrum.com. [2603:6081:7b01:cbda:a0a3:ef76:712:405d]) by smtp.gmail.com with ESMTPSA id a20sm4797364qtp.19.2021.08.02.08.55.59 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Aug 2021 08:55:59 -0700 (PDT) Date: Mon, 2 Aug 2021 11:55:58 -0400 From: Tom Rini To: Jan Kiszka Cc: U-Boot Mailing List , Le Jin , Bao Cheng Su , Nian Gao , Chao Zeng , Lokesh Vutla Subject: Re: [PATCH v5 2/5] board: siemens: Add support for SIMATIC IOT2050 devices Message-ID: <20210802155557.GJ9379@bill-the-cat> References: <20210802154739.GI9379@bill-the-cat> <6760c396-c85a-dd0d-f5e0-ad78ce4e6a2d@siemens.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GS4hgKuWjO35gvSO" Content-Disposition: inline In-Reply-To: <6760c396-c85a-dd0d-f5e0-ad78ce4e6a2d@siemens.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --GS4hgKuWjO35gvSO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 02, 2021 at 05:52:22PM +0200, Jan Kiszka wrote: > On 02.08.21 17:47, Tom Rini wrote: > > On Mon, Aug 02, 2021 at 05:21:13PM +0200, Jan Kiszka wrote: > >=20 > >> From: Jan Kiszka > >> > >> This adds support for the IOT2050 Basic and Advanced devices. The Basic > >> used the dual-core AM6528 GP processor, the Advanced one the AM6548 HS > >> quad-core version. > >> > >> Both variants are booted via a Siemens-provided FSBL that runs on the = R5 > >> cores. Consequently, U-Boot support is targeting the A53 cores. U-Boot > >> SPL, ATF and TEE have to reside in SPI flash. > >> > >> Full integration into a bootable image can be found on > >> https://github.com/siemens/meta-iot2050 > >> > >> Based on original board support by Le Jin, Gao Nian and Chao Zeng. > >> > >> Signed-off-by: Jan Kiszka > >> --- > >> arch/arm/mach-k3/Kconfig | 1 + > >> board/siemens/iot2050/Kconfig | 32 ++++ > >> board/siemens/iot2050/MAINTAINERS | 8 + > >> board/siemens/iot2050/Makefile | 10 ++ > >> board/siemens/iot2050/README | 65 +++++++ > >=20 > > This needs to be an rST and under doc/board/ now. > >=20 >=20 > Okay. >=20 > Anything else before rolling out v6? >=20 > > [snip] > >> diff --git a/board/siemens/iot2050/config.mk b/board/siemens/iot2050/c= onfig.mk > >> new file mode 100644 > >> index 0000000000..267ec76c4e > >> --- /dev/null > >> +++ b/board/siemens/iot2050/config.mk > >> @@ -0,0 +1,8 @@ > >> +# SPDX-License-Identifier: GPL-2.0+ > >> +# > >> +# Copyright (c) Siemens AG, 2020-2021 > >> +# > >> +# Authors: > >> +# Jan Kiszka > >> + > >> +flash.bin: all > >=20 > > Do we need this file? Thanks! > >=20 >=20 > Yes, this ensured building the required flash.bin image by default. > Other artifacts are not useful on the board. OK, that's it from my end, thanks! --=20 Tom --GS4hgKuWjO35gvSO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEIFY0ACgkQFHw5/5Y0 tyxitgv9FwEfsZZVLIbbW9ibqRB66MoHYlqx+KaYw8zKS/xr8yKAU/3zUu4baxkz lm6ufUdIjSSKubH1RATk9Tq+ukFEFKtQSNUFmNxlLapGBoYFwYDnIUjukPuxLQt2 5RI1TC1DXojNTPE7+bl36JLxpAgd0jLVNN4PWe218YqiWJsRl+yw+AZx4X86fegC DE0EegVOldS+SnSXkP9RGalFy2DxkCOiNgfoOvt5rW38rUJKjB3diaSQ8j/PMHLr WDIcjh52mpXxSGD9/G7o4aq2fBRmsxswGQDUJ5TgjYuQEoNAZKyvVnfgBSoNAwZK mPQLFICF1mz1euA/6scH66fxV+fhGtOMmNjmV1AYb4PLYyQi/XoR7gBe13rxZ5ji UEzJiDtX1Eb8ZyNyfc2xJpSs2DyaasyCNsvTe0Y75ph9jBLTtYtU6HIa5t2BnYmM FY975V9AN2KMbQkCnOO+qEgBkditm+6jcfADAj9FS9HZa+dj2ZT/fQN64ygT2jjv 1KAKzFIY =Qdka -----END PGP SIGNATURE----- --GS4hgKuWjO35gvSO--