Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BFB0C4338F for ; Mon, 2 Aug 2021 17:51:40 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 735F66101D for ; Mon, 2 Aug 2021 17:51:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 735F66101D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C4A5F833EF; Mon, 2 Aug 2021 19:51:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="sGWXoFsf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 47E48833EF; Mon, 2 Aug 2021 19:51:33 +0200 (CEST) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 979D5833E0 for ; Mon, 2 Aug 2021 19:51:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82d.google.com with SMTP id h10so12209667qth.5 for ; Mon, 02 Aug 2021 10:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=M0FgqMFxVfTXWnnrDFnYnAfTaFrU8ES8sa7vt7GOn5A=; b=sGWXoFsfF4JksNwhtKhl3xR6ifHOEvZjg4AyMDTJjA19pB0cWJjDiIsC6XY2t1kms5 ftMoGb1jR9wsbDGatP6AkVctHoGFbYoG6vjEPF18pIrx530nwZQ2u1Yvf3+/sKm7lP8k YQeyMb58mzMhfj7rdM8Qd6PX55+5s2oO3/feo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=M0FgqMFxVfTXWnnrDFnYnAfTaFrU8ES8sa7vt7GOn5A=; b=IMEhqSj7e8jYPcDdyOpFg4ajEBuIU9q/U+ILC4IPmqEf07Zc1OmZS/9RANmgzA+Uk/ Clno5qYV9IhWOaTXW+stKel8ms5DVXL8vodtDMHIJiV906TgANfXAL+N2kgGgt7kzZGK ybw4TXIqNVfexYtQmT3NtdYbeLW5BjRdqc8JfX0DxZBRrBtYHF53LGfDXJJcVpMg+JHl 0loYj4ZIpdJeUkhv7oMgRuGpjrnbmVPmrZ7Sz5zcwWcHiARu7jWgBffykNn9AXg/U4YC zV065N7SBMe5t4WUhlssT6cjEQ32+iURuedR7KDa0JgwwbM8pYqP3r953RcuBRk9HugI SziA== X-Gm-Message-State: AOAM531SXqNv7TS2n01JO8ylocaOFTXc9OtLK+9Q85MbUn88stIXY73W hDX504qx8g54X1uaoowdqEW/eg== X-Google-Smtp-Source: ABdhPJzmmBnPi8zY7kqdJE9CNuMgtk7FFqW0if5QYLPKwdwyOu2QtYsODi7eingxxfh1VCNlSgXMFg== X-Received: by 2002:ac8:51ca:: with SMTP id d10mr15190477qtn.97.1627926688349; Mon, 02 Aug 2021 10:51:28 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-a0a3-ef76-0712-405d.res6.spectrum.com. [2603:6081:7b01:cbda:a0a3:ef76:712:405d]) by smtp.gmail.com with ESMTPSA id o186sm6402753qke.44.2021.08.02.10.51.26 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Aug 2021 10:51:27 -0700 (PDT) Date: Mon, 2 Aug 2021 13:51:25 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , "Jonathan A . Kollasch" , Marek Vasut , Heinrich Schuchardt , Marek =?iso-8859-1?Q?Beh=FAn?= , Eugeniu Rosca , Roland Gaudig , Stefan Herbrechtsmeier , Sean Anderson Subject: Re: [PATCH v2 02/14] global: Convert simple_strtoul() with hex to hextoul() Message-ID: <20210802175125.GQ9379@bill-the-cat> References: <20210724150341.243074-1-sjg@chromium.org> <20210724150341.243074-3-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="niSs4pOX6NtZ/XiO" Content-Disposition: inline In-Reply-To: <20210724150341.243074-3-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --niSs4pOX6NtZ/XiO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 24, 2021 at 09:03:29AM -0600, Simon Glass wrote: > It is a pain to have to specify the value 16 in each call. Add a new > hextoul() function and update the code to use it. >=20 > Add a proper comment to simple_strtoul() while we are here. >=20 > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --niSs4pOX6NtZ/XiO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEIMJwACgkQFHw5/5Y0 tywg9QwAub6Yu3UqFpJPldOYnPauCO13icXSqr/ToYIoWgRnNH0CGHpG5FrLZLbu pyHdkw5Uk3kthiBwFYcYOkOLeiIBMoHX949mhG0i6auHUI52JE+OPVTteJpZ8y9X NGBf44cdiVMLKj2DEp4LaFJU7q6uJpJCwC4gWAHAZOJgm2ogNsi2xe7xvNiif1nd kd0DQhF8rXH8hmtzebuYBJDoslz/IDbTgAWRUbs7k2kLwMF5Cpgm3M+pm44I5pr7 12wmzFJcFTXEyPE+FovOKDBiiGCqrgFUMV4CiEqXPHeJ5pTDzxJjfp+/rrECOcXT JL5MLlngjplKuGZ60U+HWbG3Y33rGLg1/ssgGKSJ2Iv2HtEnPgB0P7437BiJeV8B VpbYlR+G5OgtQct1RZ+torhoPZ55NMtHjZNv+UwSM9xheC/C8dsvPUITmfWN1w1J 1Ht7BfT+SUjKdpViQ6Nl6TvvH7RGIYZk4fLiDuKYMFmWfFK/jK6KB8u0nh+yPM/j 6Fyu+RSl =b8w4 -----END PGP SIGNATURE----- --niSs4pOX6NtZ/XiO--