Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F38C2C4338F for ; Mon, 2 Aug 2021 17:52:09 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7113D60243 for ; Mon, 2 Aug 2021 17:52:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7113D60243 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 421B78341E; Mon, 2 Aug 2021 19:51:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="YuKyZQMa"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D6BA683404; Mon, 2 Aug 2021 19:51:51 +0200 (CEST) Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 21DD4833E3 for ; Mon, 2 Aug 2021 19:51:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82b.google.com with SMTP id h27so12178714qtu.9 for ; Mon, 02 Aug 2021 10:51:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=v5LKiRjf4GzztaH6R1sUcm8T+KgxGqrNiXdtwsOZ/yI=; b=YuKyZQMasPN9gWNE3ErTT5uweI4hcOBk+6Q+MCvyjIKh5tLqj2OX5YGQFmx89yFF99 WXM1oYEsGJuWpKEsRaHdLm8ug29Q5ln7kraexxBTZacQ3RJ55NkTvUVnxUN+a7HEf2AN rQcrKVXFoeEhtv8YNRotWANG7KTT4kZ1szGqA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=v5LKiRjf4GzztaH6R1sUcm8T+KgxGqrNiXdtwsOZ/yI=; b=V2c/IHJA5Qr5zIeQnct9MkRBPC/h8RMp7zQwZZ7SlM6inPHHk9Ml4XzjxkBqK1s3+i fVo2w6h87mOyNyf1bbWg9SiRzydHoPo7uk5kvI32xRbD37Ezm+N+y/qf1zIVBDloYeyg nKG8f+trRPZoz4/ycSATaXCqG/L4sR0Cw5P8Y7afdfyPP7dKTAWg3XW5glK9QLrUynwD DmUbcrhwnxm14k5gbfTzKnvK0O6JvMitD4mUuuwu8qnZoRXaRYOz7G34rmmdBa54/qwt /L6fAOPUY40vmetuoEATy5utMnFeyqGV+4IPpmgn3x8ZHOo9lpMD78Wlukt5bngjNVED LSqg== X-Gm-Message-State: AOAM5336u45rQoYdV0zgdM2u+pYi+jtB5MyO6fiRswsl0g8HBUn14cCH U6gaKEXN/3VafIQIR6hs0WU31g== X-Google-Smtp-Source: ABdhPJx/zEEfFS/urz9FUyJh6mTtDuNsOsAGxLxJac0PPC7zGQbZRoH0dwkMBGTZpTN5gb7I2zw61w== X-Received: by 2002:a05:622a:610:: with SMTP id z16mr15375197qta.99.1627926705968; Mon, 02 Aug 2021 10:51:45 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-a0a3-ef76-0712-405d.res6.spectrum.com. [2603:6081:7b01:cbda:a0a3:ef76:712:405d]) by smtp.gmail.com with ESMTPSA id j16sm6154850qkk.132.2021.08.02.10.51.44 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Aug 2021 10:51:45 -0700 (PDT) Date: Mon, 2 Aug 2021 13:51:43 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , "Jonathan A . Kollasch" , Marek Vasut , Heinrich Schuchardt , Marek =?iso-8859-1?Q?Beh=FAn?= , Eugeniu Rosca , Roland Gaudig , Stefan Herbrechtsmeier , Sean Anderson Subject: Re: [PATCH v2 05/14] lib: Drop unnecessary check for hex digit Message-ID: <20210802175143.GT9379@bill-the-cat> References: <20210724150341.243074-1-sjg@chromium.org> <20210724150341.243074-6-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PTbjmSzuGrv/yTje" Content-Disposition: inline In-Reply-To: <20210724150341.243074-6-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --PTbjmSzuGrv/yTje Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 24, 2021 at 09:03:32AM -0600, Simon Glass wrote: > If we see 0x then we can assume this is the start of a hex value. It > does not seem necessary to check for a hex digit after that since it will > happen when parsing the value anyway. >=20 > Drop this check to simplify the code and reduce size. Add a few more test > cases for when a 0x prefix is used. >=20 > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --PTbjmSzuGrv/yTje Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEIMK4ACgkQFHw5/5Y0 tyyCvwv/QPVe69zBuGLtQmMVy9ZB9K9QJTiVz7ZO1t7k1BfXkCmoy9zZYI5oZimx EaQY0iw8xbNFgfe4S5gP5yagiowTkaqNTSQgeYf+Lve0NH0SHqt/h43DilC3jw4E YLQt4EGcrTOx8wWxNjq7+g/K+/Ayl6R5Yl4y9k047gkFbzeaitx0YfF5stO2hlMu POJHO9xZcvZE9Yt/DFHk73zHYvXWFxcaqOvvx+2ylb60Enautu3B1AfSRdmsCDrZ dWlgsEfdmcrsQXJZyuvLsfDPJ+4SjzjsiIBTm6EtHiTSLLHTJ56GAHZfDUfVD6iy OVPKy5K0Khn6S5aE4FCL3CVjAdzLd+sNZ9j/YMALc92A8kg99gwqTAVLq5bHG7Ai UP8hwXdTIWWv6wPRqQpdpgpAp1j3ETe1C4IMUedcTjI3RS50jJAPLs6up15mnshu Bg37HgLHnjquIn8p85Nch3Dp6bZ4eTnFtD6oDq2BNp4S5mZrqmNtOPcqg03u0coP Jxo7goOy =gHS+ -----END PGP SIGNATURE----- --PTbjmSzuGrv/yTje--