Received: by 2002:a19:c144:0:0:0:0:0 with SMTP id r65csp613021lff; Thu, 5 Aug 2021 14:47:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpple+GEF5h/ztEWCHsI8nZsxovJWcCvpMU/j+lMOttt+f8IVPCANL38OWJS8o78iE6j/A X-Received: by 2002:a92:b108:: with SMTP id t8mr16070ilh.6.1628200075345; Thu, 05 Aug 2021 14:47:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1628200075; cv=none; d=google.com; s=arc-20160816; b=Xd5utzzvjQgsA2jCbeLYP4nm/OboC4kCdvuNtMcPeNmOX7wQ+8O8lWYeokkMnjblsV fuk5o1TkbekAhWNWWfDGqkVViKHQyS5O5HHyyrx2sV6yZSORaj7d/eUT4itUMSlmDt1t /vx/PIauaBVJno8yl0iw9jpmgYCXb9zYwZ66Fk71mWjQ/Xsx9B3EazEA+spp8lWx93Jv /WZOFP8RSGs/7SGqE3BEg6A5jRuHXodYquTeU+C8esa573LNRUIbJJV9hhXu2PaMVIhm 1+XdRaj+X0T6bgO/pceWmgSHk0ycUlD+h2n7WKaflr7F0ylOejp18dhbip8/6dO72ApZ Tqhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature; bh=vdxTM4C0KO7pi9l+swDUMHkW24uAfawxkVhRlCdFyjU=; b=xKJek4PGLLE+KVjMTcidWSizp3cGD8zRhj9n+n3a+BIPdn4DnGA2HFfwrzNMB/N5w9 BsY+bVf7nLL8zArYVRZqHnUutG3A5/rIF9rKd91eKSVsFZbNXfgrBwD1reypdBU65aja 0Jb0ItPvQ0DMjcV1cAD6+5TrR44E3+QcvIhVM9B8y/JOKV5ZRIvtBa6BmsB5cQlD4tuX ZfmznrVOY2ofsX3Gw/+VIbktEBr9tsVij0VW1EIRrV2tnsKeRAXpvTPNFhQYEjUZIbwO wB5sucxnR0te3N2MrU2pXfsMs96lpKxaCYSEOws3QKH9RZtF9GgUBfdnjJHItUheNmS+ 3AzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=Kr2yQo5O; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y13si7050860ioq.14.2021.08.05.14.47.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Aug 2021 14:47:55 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=Kr2yQo5O; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:36806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBlDW-0003O3-KN for alex.bennee@linaro.org; Thu, 05 Aug 2021 17:47:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBlDP-0003Nq-5P for qemu-arm@nongnu.org; Thu, 05 Aug 2021 17:47:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57489) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBlDM-0001qX-Gu for qemu-arm@nongnu.org; Thu, 05 Aug 2021 17:47:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628200062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vdxTM4C0KO7pi9l+swDUMHkW24uAfawxkVhRlCdFyjU=; b=Kr2yQo5OsZMZE39Pr9jocHPGBgbwNOT4D7EeYelkWKXY8LeOLWMh9nnyw2rUEdCuHAVQq6 GKwI4gFPoR1Le9c6qEvMo7Zq5kx/hSAnQLO795U6pNFbAzn5WS7hSfF4omd+GyDe5iwaSt 8txespJO7ovJdjPLco2e96g9gBdeSck= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-240-c0Tl6f90MkWxmTbHPH8JXg-1; Thu, 05 Aug 2021 17:47:42 -0400 X-MC-Unique: c0Tl6f90MkWxmTbHPH8JXg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A97DB93924; Thu, 5 Aug 2021 21:47:40 +0000 (UTC) Received: from localhost (unknown [10.22.11.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4802C26FD4; Thu, 5 Aug 2021 21:47:40 +0000 (UTC) From: Eduardo Habkost To: qemu-devel@nongnu.org Subject: [PATCH] bcm2836: Remove redundant typedef and macros Date: Thu, 5 Aug 2021 17:47:39 -0400 Message-Id: <20210805214739.390613-1-ehabkost@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Daniel P. Berrange" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Andrew Baumann , qemu-arm@nongnu.org, Paolo Bonzini , Luc Michel Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: DsU3KD8pJ447 commit 58b350280e97 ("hw/arm/bcm2836: Restrict BCM283XInfo declaration to C source") didn't just move the struct BCM283XClass definition to bcm2836.c. It also introduced a typedef (BCM283XClass) and two type checking macros (BCM283X_CLASS, BCM283X_GET_CLASS). The typedef and macros duplicate what is already defined by the OBJECT_DECLARE_TYPE declaration at bcm2836.h. Remove the redundant declarations. Signed-off-by: Eduardo Habkost --- Cc: Philippe Mathieu-Daudé Cc: Luc Michel Cc: Peter Maydell --- hw/arm/bcm2836.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c index 24354338cad..f894338fc6a 100644 --- a/hw/arm/bcm2836.c +++ b/hw/arm/bcm2836.c @@ -16,7 +16,7 @@ #include "hw/arm/raspi_platform.h" #include "hw/sysbus.h" -typedef struct BCM283XClass { +struct BCM283XClass { /*< private >*/ DeviceClass parent_class; /*< public >*/ @@ -26,12 +26,7 @@ typedef struct BCM283XClass { hwaddr peri_base; /* Peripheral base address seen by the CPU */ hwaddr ctrl_base; /* Interrupt controller and mailboxes etc. */ int clusterid; -} BCM283XClass; - -#define BCM283X_CLASS(klass) \ - OBJECT_CLASS_CHECK(BCM283XClass, (klass), TYPE_BCM283X) -#define BCM283X_GET_CLASS(obj) \ - OBJECT_GET_CLASS(BCM283XClass, (obj), TYPE_BCM283X) +}; static Property bcm2836_enabled_cores_property = DEFINE_PROP_UINT32("enabled-cpus", BCM283XState, enabled_cpus, 0); -- 2.31.1