Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58F82C4338F for ; Fri, 6 Aug 2021 11:48:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E5DAB60EBC for ; Fri, 6 Aug 2021 11:48:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E5DAB60EBC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5A2C88D0003; Fri, 6 Aug 2021 07:48:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 552E36B0071; Fri, 6 Aug 2021 07:48:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 441A08D0003; Fri, 6 Aug 2021 07:48:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id 2A8F26B006C for ; Fri, 6 Aug 2021 07:48:09 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C7B758249980 for ; Fri, 6 Aug 2021 11:48:08 +0000 (UTC) X-FDA: 78444482256.24.AF14977 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf11.hostedemail.com (Postfix) with ESMTP id 7D442F00614E for ; Fri, 6 Aug 2021 11:48:08 +0000 (UTC) Received: by mail-qt1-f169.google.com with SMTP id c5so6193632qtp.13 for ; Fri, 06 Aug 2021 04:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to; bh=eGSjSqZSYbLxuQd8oI0XJgV6zBB7+cKt8LohYyTcZZs=; b=BezIgjl+gGQUTu7iVDcfOPvYqkFN+zCpKnY1WYtZ2qYRtRrSSFvtopgNpJSq6VvpjU DYXi60g8760AYS+P0KA+f0BEYyGvmEAiXmtncJQ7MNGiXxbif1z3dbvs6hgXGKmzvfjm AjB9TlgbN8/YUQ8pXsLB2lRPIgUG1RXA8iuMGRw2cmNOuFVqQ00A79tnU485W/C/JyuR 2PQ2EYaAXzLNenIlToEISr+UYqfg2qUghKOHn6iCbU78+95HCRvWGf6KG+mluF+N1bDc yuu7o7/9N1a5s5UXswE3FNOtyzppvVPGIDlQWUYfoBmSK3x/bGI1OaqV+vZxxUNT2P7S sXcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to; bh=eGSjSqZSYbLxuQd8oI0XJgV6zBB7+cKt8LohYyTcZZs=; b=hS2/yBosIVrbLr+7Hv5p3oGiC5YMXWmfvk7JyVU34+BjDuHm/YbCQjnkR0p8A/Dm6k GXMmzkVtDi0/ndAd1WoFR+cIQ3uRnyR7A17wANaFcyawSbGRpQW8XUzY+UJ1kNqEC5L/ xfS7sxz30BJZksSRZ/8Q0nDwczl7DVOR/BOg094WmP6dZkldlgMkDGoFRi8/vqDK9Asu PailiumsHHc24U1qop9q7AgvyyRPhdOUFURPkG7CDppPHU3sMJ4snRmRjywBpfATpb+R pYAm+JwRof8jame0IAnE3BTLUsWlgdfVzo1Z0+t5zvJVzukjPxRCXYqFrXp3Wf4Hqo+d 2g5g== X-Gm-Message-State: AOAM530PIzaXhdBmfF+p53f1TXxd8Ar+bnfZEhG1V8VlYew9CzFupjKt i4GV1Ng0nglRGnqkxV7CjIs= X-Google-Smtp-Source: ABdhPJzEJRoYEkGBXrvd5E849+FERj7uQF2zN7qzcOZdLpibeL+Tn2GWh/7otgjmTmgVEyjRBpWRPA== X-Received: by 2002:ac8:6886:: with SMTP id m6mr8681334qtq.255.1628250487810; Fri, 06 Aug 2021 04:48:07 -0700 (PDT) Received: from localhost.localdomain (ec2-35-169-212-159.compute-1.amazonaws.com. [35.169.212.159]) by smtp.gmail.com with ESMTPSA id t64sm4470921qkd.71.2021.08.06.04.48.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Aug 2021 04:48:07 -0700 (PDT) From: SeongJae Park X-Google-Original-From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Shakeel Butt , SeongJae Park , Jonathan.Cameron@huawei.com, amit@kernel.org, Jonathan Corbet , David Hildenbrand , dwmw@amazon.com, foersleo@amazon.de, Greg Thelen , jgowans@amazon.com, mheyne@amazon.de, David Rientjes , sieberf@amazon.com, Vlastimil Babka , linux-damon@amazon.com, Linux MM , linux-doc@vger.kernel.org, LKML , Wei Xu , Paul Turner , Yu Zhao , Dave Hansen Subject: Re: [PATCH v34 00/13] Introduce Data Access MONitor (DAMON) Date: Fri, 6 Aug 2021 11:48:01 +0000 Message-Id: <20210806114801.6958-1-sjpark@amazon.de> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210805170344.afbf5f1ceb00eb212082ca7b@linux-foundation.org> Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=BezIgjl+; spf=pass (imf11.hostedemail.com: domain of sj38park@gmail.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=sj38park@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7D442F00614E X-Stat-Signature: mh9xqw1diphqduf9f7adq6cc6cn51p93 X-HE-Tag: 1628250488-337086 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: SeongJae Park On Thu, 5 Aug 2021 17:03:44 -0700 Andrew Morton wrote: > On Wed, 28 Jul 2021 08:36:43 +0000 SeongJae Park wrote: > > > > DAMON does not expose stable APIs at the moment, so these can > > > be changed later if needed. I think it is ok to merge DAMON for some > > > exposure. However I do want to make this clear that the solution space > > > is not complete. The solution of system level monitoring is still > > > needed which can be a future extension to DAMON or more generalized > > > Multigen LRU. > > > > Agreed. We have lots more works to do. Some of those are already posted as > > RFC patchsets[1,2,3,4]. I promise I will happily do the works. But, how dare > > could only I get all the fun? I'd like to do that together with others in this > > great community. One major purpose of this patchset is thus providing a > > flexible framework for such collaboration. The virtual address space > > monitoring, which this patchset provides in addition to the framework, is also > > for real-world usages, though. > > > > Now all the patches have at least one 'Reviewed-by:' or 'Acked-by:' tags. We > > didn't find serious problems since v26[5], which was posted about four months > > ago. so I'm thinking this patchset has passed the minimum qualification. If > > you think there are more things to be done before this patchset is merged in > > the -mm tree or mainline, please let me know. If not, Andrew, I'd like you to > > consider merging this patchset into '-mm' tree. > > Shall take a look. With some trepidation. > > 1-2 years from now someone will pop up with a massive patchset > implementing some monitoring scheme and we'll say "why didn't you use > DAMON" and they'll say "it's unsuitable for ". Agreed. And I personally believe merging this in will help avoiding such situation, because the someone will be able to easily find the developer who is responsible to convince the person. I will happily and definitely do my best for that. > > I would like to see more thought/design go into how DAMON could be > modified to address Shakeel's other three requirements. At least to > the point where we can confidently say "yes, we will be able to do > this". Are you able to drive this discussion along please? Sure. I will describe my plan for convincing Shakeel's usages in detail as a reply to this mail. Thanks, SeongJae Park