Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74F71C4338F for ; Fri, 6 Aug 2021 14:43:56 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83F7B6052B for ; Fri, 6 Aug 2021 14:43:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 83F7B6052B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CB6F782F3F; Fri, 6 Aug 2021 16:43:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="BpN9p7+V"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 857A68311D; Fri, 6 Aug 2021 16:43:50 +0200 (CEST) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 573FA82C89 for ; Fri, 6 Aug 2021 16:43:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72b.google.com with SMTP id c9so10064239qkc.13 for ; Fri, 06 Aug 2021 07:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=W5dPjEfcQ61C6k6NUe9H8Cp+MG4B1vDydVip9SlU1Pk=; b=BpN9p7+V95knKozT7CWD1f7ucPIgonLYU5rWa3cjOMpj0h67LginAAqxPC/Jruq9QC kLo2Nimydi4S+GJ0Po1YhrWogE88fPYQYe1l0kcJkYBF78LQlJYc+FL3aJJBxnvVrSOt 1WpDMN57qzREkdjgiVM7bgmgaLj+zYU9HLQac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=W5dPjEfcQ61C6k6NUe9H8Cp+MG4B1vDydVip9SlU1Pk=; b=Y5hXUSblmHu60Re7z7njdzssZISPQRz3SWZkGp0nF5UfesYRwe1itaslk+/KmLU/ib XTiT6zkMHQ1QbGIvE5IiIXTHyWRAuk/R5Q8vr0cShUXnNAr9/5f8StuGLdFYSQyfe1WR hewLT0cZtIPiNADuj45cschsT4Mx/0zVzy9L4jKo9ZhmyS/BOI23vfg2/wqNPjj9PTDl mV/SZeXgDkjXHv//CDCA8EZAmegB6IkwLQccGYBZZtR/w6pHLr8SRWxIFYlpuzC/j0iL izgUuGHj328i3iI6IQdWKZL9tVwxSVCV+qksyuJaY2g4U+/8/Gmkh2SeGwUbfI3gJJOC D2cA== X-Gm-Message-State: AOAM531xnb6OLkXvRYi5l964bKnCRps2ANmcrATII6DfJPZxe06r8ZcD acNWsdPBnYz8vW1+zJkI8eJWIg== X-Google-Smtp-Source: ABdhPJw6NNAzcAhL99kDNZh4z0ODt/I6pkOZKU4Dt2KOP1IcAapOy8yVrsZG4loNXB9JNGUbUaiHYg== X-Received: by 2002:a37:9a43:: with SMTP id c64mr3798793qke.87.1628261026093; Fri, 06 Aug 2021 07:43:46 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-91f5-8795-37c3-31a0.res6.spectrum.com. [2603:6081:7b01:cbda:91f5:8795:37c3:31a0]) by smtp.gmail.com with ESMTPSA id h2sm1672637qko.127.2021.08.06.07.43.45 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Aug 2021 07:43:45 -0700 (PDT) Date: Fri, 6 Aug 2021 10:43:43 -0400 From: Tom Rini To: Stefan Roese Cc: u-boot@lists.denx.de, sjg@chromium.org Subject: Re: [PATCH v1 4/5] arm64: arch/arm/lib: Add optimized memset/memcpy functions Message-ID: <20210806144343.GY858@bill-the-cat> References: <20210806133843.3642916-1-sr@denx.de> <20210806133843.3642916-5-sr@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yYeq/WQYi/kuVVbm" Content-Disposition: inline In-Reply-To: <20210806133843.3642916-5-sr@denx.de> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --yYeq/WQYi/kuVVbm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 06, 2021 at 03:38:42PM +0200, Stefan Roese wrote: > Ported from https://github.com/ARM-software/optimized-routines >=20 > Please note that when adding these optimized functions as default memset > memcpy functions in U-Boot, U-Boot fails to boot on the LX2160ARDB. > After the initial ATF output, no U-Boot output is shown on the serial > console. Some exception is triggered here in the very early boot process > as some of the assembler opcodes need the caches to be enabled. >=20 > Because of this, some additional patches will introduce memset_simple() > which will be used in some selected code location. >=20 > Note: > I also integrated and tested with the Linux versions of these optimized > functions. They are similar to the ones now integrated but these ARM > versions are still a small bit faster. Ah, so here's why you didn't use the kernel versions. Do the kernel versions still have the cache issue? Also, this should be reworded a bit since you did introduce memset_simple before here. --=20 Tom --yYeq/WQYi/kuVVbm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmENSpsACgkQFHw5/5Y0 tyztrQwAmvtVb0JUmNn1t2DraSKvj9kqTP1JEIeEPft4Vir/CYkMVF6zRFA3QSb7 R6IONzZ8HafzcpnY1tZBR8ahSbKUd/2SY3vNlQrIrmbhGIxiGfQuIOFfISEK+zZb U0ld2uxrXwwDyTJnTrJnNtlpHRxJehJJY8djaLi15ODr+FX4MSAn/844SY9OSY+w vvb84WmgMyBIvZPjA/cYcWAIXNHRjL+G1rJxr34VxqUlKqR5M3nkMBLtjf1CYVwE TRalOqj5y+kyW0gW2dSQ2q5sJkGHY7mxd3BEl8VSGtFyllHKXHkBtHw8iM3DEN2h lnM0lRSnKDhSXpsDd5RUlv1ENSAM5Fffjglu8zZiQ2A4ZKmrXxdxYcb0Tzt0gJdj SUXC8d7mGZxtzgWpmgnTWz0LBVUeYTZMxzdPmaPp+MNTMeTG4YG6Eda4g0pqpr6R 22X86HXYC+VoAGhbXA3G5WJ6QidPWx6+rUKcehdipvYqaEYhBHZWbt2HrsYE+/4P jLGxoGUK =wJm8 -----END PGP SIGNATURE----- --yYeq/WQYi/kuVVbm--