Content-Type: multipart/mixed; boundary="===============5260865687014811020==" MIME-Version: 1.0 From: Masami Hiramatsu To: kbuild-all@lists.01.org Subject: Re: [PATCH v2 5/9] tracing/boot: Show correct histogram error command Date: Fri, 06 Aug 2021 23:00:43 +0900 Message-ID: <20210806230043.cc3700ca5518651c3efe5748@kernel.org> In-Reply-To: <202108061028.Wme82Hlq-lkp@intel.com> List-Id: --===============5260865687014811020== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Fri, 6 Aug 2021 10:58:30 +0800 kernel test robot wrote: > Hi Masami, > = > I love your patch! Perhaps something to improve: > = > [auto build test WARNING on tip/perf/core] > [also build test WARNING on trace/for-next linux/master linus/master v5.1= 4-rc4 next-20210805] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > = > url: https://github.com/0day-ci/linux/commits/Masami-Hiramatsu/tracing= -boot-Add-histogram-syntax-support-in-boot-time-tracing/20210806-002938 > base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 79551= ec0782895af27d6aa9b3abb6d547b7260d3 This seems that the base tree is not correct. I worked on Steve's = linux-trace tree for this series, including = commit e5efaeb8a8f5 ("bootconfig: Support mixing a value and subkeys under = a key") which introduced "xbc_node_for_each_subkey()" macro. Thank you, > config: x86_64-randconfig-r025-20210805 (attached as .config) > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 42b9= c2a17a0b63cccf3ac197a82f91b28e53e643) > reproduce (this is a W=3D1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi= n/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/b07ebb734f4e2b68934de50= 1715c1cd98e34ae17 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Masami-Hiramatsu/tracing-boot-Ad= d-histogram-syntax-support-in-boot-time-tracing/20210806-002938 > git checkout b07ebb734f4e2b68934de501715c1cd98e34ae17 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross AR= CH=3Dx86_64 = > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > = > All warnings (new ones prefixed by >>): > = > kernel/trace/trace_boot.c:287:2: error: implicit declaration of functi= on 'xbc_node_for_each_subkey' [-Werror,-Wimplicit-function-declaration] > xbc_node_for_each_subkey(hnode, node) { > ^ > kernel/trace/trace_boot.c:287:39: error: expected ';' after expression > xbc_node_for_each_subkey(hnode, node) { > ^ > ; > kernel/trace/trace_boot.c:290:4: error: 'continue' statement not in lo= op statement > continue; > ^ > kernel/trace/trace_boot.c:294:4: error: 'break' statement not in loop = or switch statement > break; > ^ > kernel/trace/trace_boot.c:404:2: error: implicit declaration of functi= on 'xbc_node_for_each_subkey' [-Werror,-Wimplicit-function-declaration] > xbc_node_for_each_subkey(hnode, node) { > ^ > kernel/trace/trace_boot.c:404:39: error: expected ';' after expression > xbc_node_for_each_subkey(hnode, node) { > ^ > ; > kernel/trace/trace_boot.c:407:4: error: 'continue' statement not in lo= op statement > continue; > ^ > >> kernel/trace/trace_boot.c:420:4: warning: misleading indentation; stat= ement is not part of the previous 'if' [-Wmisleading-indentation] > if (trigger_process_regex(file, buf) < 0) > ^ > kernel/trace/trace_boot.c:418:3: note: previous statement is here > if (trace_boot_compose_hist_cmd(hnode, buf, size) =3D= =3D 0) > ^ > 1 warning and 7 errors generated. > = > = > vim +/if +420 kernel/trace/trace_boot.c > = > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 395 = > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 396 static void __init > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 397 trace_boot_init_histogra= ms(struct trace_event_file *file, > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 398 struct xbc_node *h= node, char *buf, size_t size) > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 399 { > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 400 struct xbc_node *node; > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 401 const char *p; > b07ebb734f4e2b Masami Hiramatsu 2021-08-06 402 char *tmp; > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 403 = > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 @404 xbc_node_for_each_subke= y(hnode, node) { > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 405 p =3D xbc_node_get_dat= a(node); > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 406 if (!isdigit(p[0])) > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 407 continue; > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 408 /* All digit started n= ode should be instances. */ > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 409 if (trace_boot_compose= _hist_cmd(node, buf, size) =3D=3D 0) { > b07ebb734f4e2b Masami Hiramatsu 2021-08-06 410 tmp =3D kstrdup(buf, = GFP_KERNEL); > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 411 if (trigger_process_r= egex(file, buf) < 0) > b07ebb734f4e2b Masami Hiramatsu 2021-08-06 412 pr_err("Failed to ap= ply hist trigger: %s\n", tmp); > b07ebb734f4e2b Masami Hiramatsu 2021-08-06 413 kfree(tmp); > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 414 } > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 415 } > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 416 = > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 417 if (xbc_node_find_child= (hnode, "keys")) { > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 418 if (trace_boot_compose= _hist_cmd(hnode, buf, size) =3D=3D 0) > b07ebb734f4e2b Masami Hiramatsu 2021-08-06 419 tmp =3D kstrdup(buf, = GFP_KERNEL); > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 @420 if (trigger_process_r= egex(file, buf) < 0) > b07ebb734f4e2b Masami Hiramatsu 2021-08-06 421 pr_err("Failed to ap= ply hist trigger: %s\n", tmp); > b07ebb734f4e2b Masami Hiramatsu 2021-08-06 422 kfree(tmp); > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 423 } > 8885ed81dfd529 Masami Hiramatsu 2021-08-06 424 = > = > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org -- = Masami Hiramatsu --===============5260865687014811020==--