Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7140D899F2 for ; Mon, 9 Aug 2021 09:22:59 +0000 (UTC) Date: Mon, 9 Aug 2021 11:22:53 +0200 From: Zbigniew =?utf-8?Q?Kempczy=C5=84ski?= Message-ID: <20210809092253.GC17331@zkempczy-mobl2> References: <20210806134145.24634-1-zbigniew.kempczynski@intel.com> <20210806134145.24634-31-zbigniew.kempczynski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210806134145.24634-31-zbigniew.kempczynski@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t v4 30/56] tests/gem_mmap_gtt: Add allocator support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: igt-dev@lists.freedesktop.org Cc: Ch Sai Gowtham , Petri Latvala , Ashutosh Dixit List-ID: On Fri, Aug 06, 2021 at 03:41:19PM +0200, Zbigniew Kempczyński wrote: > From: Ch Sai Gowtham > > When relocations are not available tests must assign addresses to objects > by themselves instead of relying on the driver. We use allocator for > that purpose. > > Signed-off-by: Ch Sai Gowtham > Cc: Zbigniew Kempczyński > Cc: Petri Latvala > Cc: Ashutosh Dixit > --- > tests/i915/gem_mmap_gtt.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c > index 60282699e..92bbb5d2a 100644 > --- a/tests/i915/gem_mmap_gtt.c > +++ b/tests/i915/gem_mmap_gtt.c > @@ -335,10 +335,12 @@ test_pf_nonblock(int i915) > { > igt_spin_t *spin; > uint32_t *ptr; > + uint64_t ahnd; > > igt_require(mmap_gtt_version(i915) >= 3); > > - spin = igt_spin_new(i915); > + ahnd = get_reloc_ahnd(i915, 0); > + spin = igt_spin_new(i915, .ahnd = ahnd); > > igt_set_timeout(1, "initial pagefaulting did not complete within 1s"); > > @@ -349,6 +351,7 @@ test_pf_nonblock(int i915) > igt_reset_timeout(); > > igt_spin_free(i915, spin); > + put_ahnd(ahnd); > } > > static void > @@ -741,11 +744,13 @@ test_hang_busy(int i915) > igt_spin_t *spin; > igt_hang_t hang; > uint32_t handle; > + uint64_t ahnd; > > hang = igt_allow_hang(i915, ctx->id, 0); > igt_require(igt_params_set(i915, "reset", "1")); /* global */ > > - spin = igt_spin_new(i915, .ctx = ctx, > + ahnd = get_reloc_ahnd(i915, ctx->id); > + spin = igt_spin_new(i915, .ctx = ctx, .ahnd = ahnd, > .flags = IGT_SPIN_POLL_RUN | > IGT_SPIN_FENCE_OUT | > IGT_SPIN_NO_PREEMPTION); > @@ -788,6 +793,7 @@ test_hang_busy(int i915) > munmap(ptr, 4096); > > igt_spin_free(i915, spin); > + put_ahnd(ahnd); > igt_disallow_hang(i915, hang); > intel_ctx_destroy(i915, ctx); > } > @@ -800,11 +806,13 @@ test_hang_user(int i915) > igt_spin_t *spin; > igt_hang_t hang; > uint32_t handle; > + uint64_t ahnd; > > hang = igt_allow_hang(i915, ctx->id, 0); > igt_require(igt_params_set(i915, "reset", "1")); /* global */ > > - spin = igt_spin_new(i915, .ctx = ctx, > + ahnd = get_reloc_ahnd(i915, ctx->id); > + spin = igt_spin_new(i915, .ctx = ctx, .ahnd = ahnd, > .flags = IGT_SPIN_POLL_RUN | > IGT_SPIN_FENCE_OUT | > IGT_SPIN_NO_PREEMPTION); > @@ -843,6 +851,7 @@ test_hang_user(int i915) > munmap(ptr, 4096); > > igt_spin_free(i915, spin); > + put_ahnd(ahnd); > igt_disallow_hang(i915, hang); > intel_ctx_destroy(i915, ctx); > } > -- > 2.26.0 > Looks ok, Reviewed-by: Zbigniew Kempczyński -- Zbigniew