Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B72DC4338F for ; Thu, 12 Aug 2021 06:40:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60A6D60FD7 for ; Thu, 12 Aug 2021 06:40:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231225AbhHLGkY (ORCPT ); Thu, 12 Aug 2021 02:40:24 -0400 Received: from mga01.intel.com ([192.55.52.88]:13074 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231149AbhHLGkX (ORCPT ); Thu, 12 Aug 2021 02:40:23 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10073"; a="237318599" X-IronPort-AV: E=Sophos;i="5.84,315,1620716400"; d="scan'208";a="237318599" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 23:39:58 -0700 X-IronPort-AV: E=Sophos;i="5.84,315,1620716400"; d="scan'208";a="421808995" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 23:39:57 -0700 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id EA1C1203D0; Thu, 12 Aug 2021 09:39:24 +0300 (EEST) Date: Thu, 12 Aug 2021 09:39:24 +0300 From: Sakari Ailus To: "Kao, Arec" Cc: "linux-media@vger.kernel.org" , "Yeh, Andy" , "Chang, Wei Shun" Subject: Re: [PATCH] Add sensor driver support for the ov13b10 camera. Message-ID: <20210812063924.GO3@paasikivi.fi.intel.com> References: <20210811102402.21945-1-arec.kao@intel.com> <20210811104029.GM3@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Arec, On Thu, Aug 12, 2021 at 03:38:55AM +0000, Kao, Arec wrote: > Hi Sakari, > > Thank you for the nice feedback. I will fix each of your comments on v2 > patch. As regards to your comment: "Does v/hflip change the pixel order > with this driver btw.?", yes, it does actually change bayer order when > image flip/mirror and already made some changes with > increasing/decreasing horizontal/ vertical window offset in v/hflip > function. Ok. Almost all sensors require changing the Bayer order but some drivers just shift the crop window by one pixel. Either is fine, as long as it is taken care of so that the sensor produces pixels in the order the driver indicates. -- Regards, Sakari Ailus