Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87264C4338F for ; Fri, 13 Aug 2021 14:35:02 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 522DB60F36 for ; Fri, 13 Aug 2021 14:35:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 522DB60F36 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nedap.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4189180F4B; Fri, 13 Aug 2021 16:34:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nedap.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nedap.com header.i=@nedap.com header.b="XX+8QdAu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CCC8A829C6; Fri, 13 Aug 2021 16:34:55 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20725.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::725]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6628C82D13 for ; Fri, 13 Aug 2021 16:34:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nedap.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=harm.berntsen@nedap.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HLXmtcJonnc8UJQi+SJzR9cwmmDOrRmSfHgAnx+1QNCbpaT7UsmovFzx6YmR3VvivrgooXcUVxHtuxrHundC8qc2LsITa6gKeRe6uT6r/OAJKlHiJYKVpWAZWfx7oWuMWec8kcBD/+MJ3YjFJxi8OORYRrb4/YSPgnNfXjLzszwg5u61py7Jw9PUF5zdTzdPPOQZ2Q1Rdrx745dvjYpfIuiJ4TTtYYM8WQGo0CdBli3dal7Dnoh5fDX4N2rLscEUP/oHy0yQRT21KZTSvlhRYDqrPeIikL1L+U/faVIbR1zaWcxcI7z6KP4n0NFzW/xiRUkH69Hvu2BisF4bpmJjtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fVMKoX0tch2b5k/Zvtay2YgBxUUm7JyROe2mLJVDdXQ=; b=nbUmN/GY5WCDTNn745VKNK5G5ugH2ex4Eq/I9d243D4JyWn9Nf8OahHec4jXcpsazczBfSr7Y0pAxQO3bRkvRpj1W482PJ3SnJxt57Od82wi1TNnSQaH174psegnB/s6FCUuoZXlmgFdZkXSb2s9lkyfo5cg19q9LuZMi8o1gkJN90wDmTG2L3AjEM33tStq31wx79suF024KXYAq+w+IMgXWgghojeGMFQyBu4nwcOF2or/clVDhkQGyKKm8YjDI7olr6FTusjxGOy14l3jI5QvcMretVafAu+s4K3Ehh7X7If6SRseNNMTZyEE1F+2dBgOfkaNObcjD+LHlbchgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nedap.com; dmarc=pass action=none header.from=nedap.com; dkim=pass header.d=nedap.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nedap.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fVMKoX0tch2b5k/Zvtay2YgBxUUm7JyROe2mLJVDdXQ=; b=XX+8QdAuo64jRl/Ws/b53wSyb5oq9u6MIpub6q/7CjccBStw4ISp0epEZJOo+01aNzsTb8gTHI9G9ZkzwmC9M10i3zI5otTY1BgnqevKPCOhk8m5UHbjAopIg6W+1guSaXW9wd96DLnfPsuwDFkItHC3O3BgDddCtPbq2p8u5yw= Received: from AM8PR10MB4034.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:1e7::20) by AM0PR10MB3476.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:15e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.17; Fri, 13 Aug 2021 14:34:50 +0000 Received: from AM8PR10MB4034.EURPRD10.PROD.OUTLOOK.COM ([fe80::b15c:ce54:d4a5:def6]) by AM8PR10MB4034.EURPRD10.PROD.OUTLOOK.COM ([fe80::b15c:ce54:d4a5:def6%4]) with mapi id 15.20.4415.019; Fri, 13 Aug 2021 14:34:50 +0000 From: Harm Berntsen To: "u-boot@lists.denx.de" CC: Harm Berntsen , "sjg@chromium.org" , Robert Krikke , "ye.li@nxp.com" , "sbabic@denx.de" Subject: [PATCH] gpio: mxc_gpio: Fix i.MX8M GPIO output status read Thread-Topic: [PATCH] gpio: mxc_gpio: Fix i.MX8M GPIO output status read Thread-Index: AQHXkFBfzfNY9BVIyk+qeylSXuBXjQ== Date: Fri, 13 Aug 2021 14:34:50 +0000 Message-ID: <20210813143419.32391-1-harm.berntsen@nedap.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.32.0 authentication-results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nedap.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 72b5a100-837d-4caf-2917-08d95e6781e4 x-ms-traffictypediagnostic: AM0PR10MB3476: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /Q65c8sgVWlywOrlVpNnlORYUojuU26nq0RyxMjGrL+DWAtl6CcWZsDAIEJIYpZjKpaEuAb2WxOF5DKnz2iXZhBdKOgAlW2Z3VbuwumeAaa9o2431sCjPBQGTMl4qhztK7rSxfwc1AaqRtJBJPU6wkD6IyP3gTM0aqvA9mF+mcXwx3GvKlmXbKnaH/GO6A5q0mNGlsN7O9Rt3d2uvZGCF1Wk1sxRBL1fvXr/15sLWkhBpj7sbARAqITsGs4AvYH5E4cTvB1RuVuYoUQKDj/koBiZrM76OeJHt3kmpBMOqDWhM6XLO1SPbQ+I1SfVIYQNbXBVDcZun1Wkxsr4j3fW188Ezz/s4sIb+aEsaTZvV2rmoGZAyvyXLCjAt9vXBkcrfI9LhiYoCSUBdRsP7HMh0aaf4oB72v1KuzFkTksRztkRUvHSaP74eDlNwcxk5ORoHGUMff5IFmvsqf0WytQoGv2IajXBmnvBF7ZWeDPwepeU+aabfK+SsuagpC9vqEeXIAYc+W41xXwFNQcG/znZfhlstgwOKZher/HWugcGJdb9oj9pu273YdPyjhTaVpT1se8OdoXk6WBoA8t7NTwOl4XUeVqVfAzZyK1h97BVfBr+EstJOTu0N7PX580thgUmYtPCDqrXurKx/WrSDT2NG4PCa4wiV47HyDceVSsvmFyJlsIyJCBUKScuAMe4VUSeo4Wj5D16E7aigIbQ/cu9vw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM8PR10MB4034.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(396003)(39840400004)(136003)(366004)(376002)(346002)(1076003)(6512007)(71200400001)(2616005)(6486002)(66946007)(83380400001)(122000001)(2906002)(26005)(6506007)(38100700002)(186003)(86362001)(316002)(8676002)(66476007)(54906003)(36756003)(4326008)(66446008)(44832011)(8936002)(64756008)(66556008)(76116006)(5660300002)(478600001)(6916009)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?VgSNUPeI+GtdW9TEEFibzW/BrOenMeJBios9nvH3/DFcJlFM1AFPMNbOfp?= =?iso-8859-1?Q?xXYXeWoxQMYVrRAXEkrXPDERgo4+nc5krtTkHVIA2FEmGNGd+O+2Llivgq?= =?iso-8859-1?Q?nHiN+jOAfCUkgmefD3KD7murb9tTRdXpVxRnUGpoAckqd847I747lh9KXQ?= =?iso-8859-1?Q?uhCQhMmuXKxvbh63v72nahpQUDx8d6u+nUjlQV7XsgOKhmJE7fOhjjiR+T?= =?iso-8859-1?Q?tlIKDzkaBDinQ8RZ0Kq05W0GDFM0N3v3S5n+6kuuKgIL5TRPa9kpNqP/Ev?= =?iso-8859-1?Q?A9Lapj1iAFmtQbx8WCGTl9+nkf9khmJOwpGuN14I02xcvbNDDpBtBXjARq?= =?iso-8859-1?Q?xjisEmDb6Whw4Lg+rv+zHnbD2KUYcLm69stsrdVqIj1Llww1YB037w8gAy?= =?iso-8859-1?Q?kPOjJwQ0ZLIMW33xB9HDFnVREQXc03p4RQQ4LtWgpGR9+SsM3LPdXIS9WV?= =?iso-8859-1?Q?uccs3atnsyotLG8SWHqHu+3Iu46f7Y9wdHZ/7DDkGto/K6yO7bVF4MAT0a?= =?iso-8859-1?Q?esGnZnjOpLQX96S6VREOFOoJYq1uvmJf/2XRwFT4UaSi0J/7bZqvxXRj6V?= =?iso-8859-1?Q?ckM83WM1rtej5xnMMyAniLzrJAKbIEGSAlDNTRSExTfy4RLIZtscMn+3v4?= =?iso-8859-1?Q?6Eb444ZpR2Vk0eVlr/gf8EP90uWxdCDXTm/xa7CcXrKdyGGfD1p12N0Tjb?= =?iso-8859-1?Q?Hcuwpt0pvGiX9++wSf5gU/JL8FnRIO/JKDPezMqJHJ6vjTWsWcNVhS6xJA?= =?iso-8859-1?Q?S9GhTbKDgGitcOH+UNu1TUEkOE9kqq91qEw5fOu3npjo6rtnqqbUuE1/fg?= =?iso-8859-1?Q?yzi5DjbEGdRSWkO2UrfxY3dWTbFLTHIyQQxruWPR3ZAADJALtxicC4Ln2e?= =?iso-8859-1?Q?wAuOq2vfo2Z+cQ9Dy8xoEWYxEwgQOD+GlSkvA7e40X7hsGqThNO+BDCIxa?= =?iso-8859-1?Q?X5uzA+nP3gkUe8wahcNr0RLcVBmRMogv6Qp2lUQkVtfrB62RXhdNFCunP6?= =?iso-8859-1?Q?BsJ9u+IUTpqNoibtJmSFCwNd14Ffs+WskhdzPvXBY9jVXUYFLSBYQjesDg?= =?iso-8859-1?Q?zZpgI0jcYrdt6rIs6M7TBJqpHjYTZWX/tqawHiXA++nC+eV4Atmc+dTTHF?= =?iso-8859-1?Q?mwt7lqIjQ8gcthvT9EJYKywwVjzWznK+NSaOPdovBne+nDHIIM9B0DBk/B?= =?iso-8859-1?Q?XJIAlKTmNdZZ1hEU3zNWKIM6zsLf2ldpcOt4VgWdJVYkNkLN35XizLE5nZ?= =?iso-8859-1?Q?pThhDz/RUWyGCIiNSayAdrQmToJRw7on64YDr9TNEuIaxKPqU0bylXXTAe?= =?iso-8859-1?Q?0D54SEbEZGWOPkxD9+6guuHQtmeQoUgItIClUsgCGMC06yoSsfMMi3Yro3?= =?iso-8859-1?Q?YxG+QYQ1jA?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nedap.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM8PR10MB4034.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 72b5a100-837d-4caf-2917-08d95e6781e4 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Aug 2021 14:34:50.2615 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 6d21d161-0ae7-4a24-94cf-df0881e2fa96 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tIFLNlGT/I2qvMGtzKbkXog/9skhblJH/2Icj4d/yy1R3gFBsHy9h6DJkHMreaFMiYjLOOsUjIN53VykAFbyFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB3476 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Currently the driver gets value from PSR register, but this register is only for input mode. For output mode, it always returns 0, not the value we set for output. This patch changes to use DR register, which returns the DR value for output mode, and PSR value for input mode. This patch is based on code from Ye Li Signed-off-by: Robert Krikke Signed-off-by: Harm Berntsen CC: Ye Li CC: Stefano Babic --- drivers/gpio/mxc_gpio.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/mxc_gpio.c b/drivers/gpio/mxc_gpio.c index 06e6b2279f..c30246399c 100644 --- a/drivers/gpio/mxc_gpio.c +++ b/drivers/gpio/mxc_gpio.c @@ -36,6 +36,17 @@ struct mxc_bank_info { struct gpio_regs *regs; }; =20 +static int gpio_bank_get_value(struct gpio_regs *regs, int offset) +{ + u32 gpio_val; + + if (IS_ENABLED(CONFIG_ARCH_IMX8M)) + gpio_val =3D readl(®s->gpio_dr); + else + gpio_val =3D readl(®s->gpio_psr); + return (gpio_val >> offset) & 0x01; +} + #if !CONFIG_IS_ENABLED(DM_GPIO) #define GPIO_TO_PORT(n) ((n) / 32) =20 @@ -125,18 +136,13 @@ int gpio_get_value(unsigned gpio) { unsigned int port =3D GPIO_TO_PORT(gpio); struct gpio_regs *regs; - u32 val; - if (port >=3D ARRAY_SIZE(gpio_ports)) return -1; =20 gpio &=3D 0x1f; =20 regs =3D (struct gpio_regs *)gpio_ports[port]; - - val =3D (readl(®s->gpio_psr) >> gpio) & 0x01; - - return val; + return gpio_bank_get_value(regs, gpio); } =20 int gpio_request(unsigned gpio, const char *label) @@ -211,7 +217,7 @@ static void mxc_gpio_bank_set_value(struct gpio_regs *r= egs, int offset, =20 static int mxc_gpio_bank_get_value(struct gpio_regs *regs, int offset) { - return (readl(®s->gpio_psr) >> offset) & 0x01; + return gpio_bank_get_value(regs, offset); } =20 /* set GPIO pin 'gpio' as an input */ --=20 2.32.0