Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mFhwk-00088t-2s for mharc-grub-devel@gnu.org; Mon, 16 Aug 2021 15:06:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3R7caYQcKCjAYMeWdMkSaaSXQ.OaYSdgN-PQhQXSZg.adS@flex--maskray.bounces.google.com>) id 1mFhwj-00088A-45 for grub-devel@gnu.org; Mon, 16 Aug 2021 15:06:53 -0400 Received: from mail-qk1-x74a.google.com ([2607:f8b0:4864:20::74a]:49081) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3R7caYQcKCjAYMeWdMkSaaSXQ.OaYSdgN-PQhQXSZg.adS@flex--maskray.bounces.google.com>) id 1mFhwf-0006d8-Ac for grub-devel@gnu.org; Mon, 16 Aug 2021 15:06:52 -0400 Received: by mail-qk1-x74a.google.com with SMTP id p14-20020a05620a22eeb02903b94aaa0909so13848076qki.15 for ; Mon, 16 Aug 2021 12:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=l/HJCj8LB4Vo4BKEpudrzdYTDL0gBP6E/dC9hi70TGs=; b=UsU4cgYwE6/CVCaETIAijA8S/yHLetRKNSKeoSXOqtjPFx+ByLKC2osUZ7pA0liW/U ruVKfTqzBNckrVY3NkVdGAg6qjfKdbPsbrwuM3zXIwHKlUhdXZZpbFXPp7KR3vSUCgSm DRpkaYjzHwTw41WoWXpMhti9H4WKZ2a16z3/l5Vf58h5ItrtYBt1TXO5inskW+Lb5yDL 6XRdeCG4bpCB8ShxHgqOyQLbPWgNA+Bpxu7qTfHAli9D/o6nPcOvi+HWfAIV+0O6AUJG 9j61J1zU50q7xLY3FEakqnhNaP9io92sMMWMXISOe58y++EuPllIzI0Ff6kGNzkSX/Fu hb0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=l/HJCj8LB4Vo4BKEpudrzdYTDL0gBP6E/dC9hi70TGs=; b=GLmeA5IlygofXYtJLx/da4bKG1CcZTFo2ZBVfGsfH2jBRxrxkzVyTInnc+0PMu5Hsa VKpdlcBZCG0+z4ewOc8gGo++6o72vPWoSoEm5ao1hxi5cTKrapQZklmM4l/g24Z91ZLC htzwqp8987cYKq3uM9X8IfGa+UB+VQ8QKhNht3dFB4smt62JQ15x0+DxMR5ikjHa5K1A TOUA8BTW9OtTafizFv51GSk37VLs6UFFfImbktmYOXPpdtNfQQ10xbxeTqu0J7Zm1P2I olKAAEg9QNM5Zw0daMF3TBFfZO0OK1W65DjTJ9tjoxDNOtNS3r33hTSHbpDAZ5gwWSzj 8xPg== X-Gm-Message-State: AOAM531LTn7GDPCEbgBCblxTZWbyB/6KVacdMIlFutu9QKsZXpobyUzd M6RzOP/aI2/zZMYFwBmmSU3ZHQ1BUbydnrdX5lV2Oun62xmpyPi6Cu0pGzwdbfJDp3nUXoU00xq fP0XwYyduZ6MsURfSV0J7e8brDLRBHJA9jaxx/2LZWYvLOrt7wXLwSUCqrfg= X-Google-Smtp-Source: ABdhPJzMJVRIMnoeSmaiwuz6w9J5V3wV+zv0P+qTf3dOv4TChZ3oWiqlZnkXktFdtDLCUtiAo4hCmkl4mCuD X-Received: from maskray1.svl.corp.google.com ([2620:15c:2ce:200:3b0d:d236:8e9c:7f59]) (user=maskray job=sendgmr) by 2002:ad4:4973:: with SMTP id p19mr304574qvy.30.1629140807584; Mon, 16 Aug 2021 12:06:47 -0700 (PDT) Date: Mon, 16 Aug 2021 12:06:25 -0700 Message-Id: <20210816190625.2878309-1-maskray@google.com> Mime-Version: 1.0 Subject: [PATCH] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1 From: Fangrui Song To: grub-devel@gnu.org Cc: Fangrui Song Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::74a; envelope-from=3R7caYQcKCjAYMeWdMkSaaSXQ.OaYSdgN-PQhQXSZg.adS@flex--maskray.bounces.google.com; helo=mail-qk1-x74a.google.com X-Spam_score_int: -95 X-Spam_score: -9.6 X-Spam_bar: --------- X-Spam_report: (-9.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Aug 2021 19:06:53 -0000 Clang 14.0.0 has implemented -falign-loops=1 but -falign-jumps=1 is still unsupported. The check should test all flags which may be added into CFLAGS. Signed-off-by: Fangrui Song --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index bee28dbeb..b2fd0c3e4 100644 --- a/configure.ac +++ b/configure.ac @@ -799,14 +799,14 @@ fi # Force no alignment to save space on i386. if test "x$target_cpu" = xi386; then AC_CACHE_CHECK([whether -falign-loops works], [grub_cv_cc_falign_loop], [ - CFLAGS="$TARGET_CFLAGS -falign-loops=1 -Werror" + CFLAGS="$TARGET_CFLAGS -falign-jumps=1 -falign-loops=1 -falign-functions=1 -Werror" AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])], [grub_cv_cc_falign_loop=yes], [grub_cv_cc_falign_loop=no]) ]) AC_CACHE_CHECK([whether -malign-loops works], [grub_cv_cc_malign_loop], [ - CFLAGS="$TARGET_CFLAGS -malign-loops=1 -Werror" + CFLAGS="$TARGET_CFLAGS -malign-jumps=1 -malign-loops=1 -malign-functions=1 -Werror" AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])], [grub_cv_cc_malign_loop=yes], [grub_cv_cc_malign_loop=no]) -- 2.33.0.rc1.237.g0d66db33f3-goog