Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91376C4338F for ; Wed, 18 Aug 2021 13:38:49 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D38E60238 for ; Wed, 18 Aug 2021 13:38:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9D38E60238 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2329482DEF; Wed, 18 Aug 2021 15:38:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="hkhipDoa"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0E77382BE5; Wed, 18 Aug 2021 15:38:45 +0200 (CEST) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9566F82BE5 for ; Wed, 18 Aug 2021 15:38:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x734.google.com with SMTP id t66so3056177qkb.0 for ; Wed, 18 Aug 2021 06:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=h8mkFLmBjcwfqCEjHvD7to8Ip8zxcc7tyIhXj46zhMA=; b=hkhipDoa0+Dcfq6celdpNIbCQhAvF3L9VBFh1b0qcZRCyeKaJ+oBfTQvrP99Gdn7t+ DsWv6bBf8/X3tn/3SRjXd+66S3D8YvJjiTswPqvzaYMfHai7g6VdtsZmjZa6WRxrE1K4 RS32m25BMH9VmNPR1O+jununmlpddyVcH9lvw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=h8mkFLmBjcwfqCEjHvD7to8Ip8zxcc7tyIhXj46zhMA=; b=Y2alxul1brIhr4kwzgdxFjHFRY6H6WiIMH8Y09ELYwNPkecuLfYhcuY3ypxD3/DkLp dka6mhZWAbXz//klypuHSNAXOuuMID2P45awty3nW4R5QbVhvQUhaOU+IkccK6Ql0Evp zk/sS+94Wm7PeHGOa39numz+i5d3KDZvN7AIr752nYVjwlHYEZaPXxmxS6nyrc+mOeUG arLLlNe/PFb2tlyPezuQLFa5Y4ghh0JWHxpKxpBliRLSnUxtJlB10e5CHArocAOlFo14 J6QN5K+F270b6pqQGSyEt7v7vreyNyzwfuSOzig1a9/KdIoJ4vp2tBaU+HUp6npg+IdJ MHVQ== X-Gm-Message-State: AOAM5313CJGlm4DJWYMXIByXygHzeitRVGE43t5ydtXpgbLPnoEjOGqZ CRXQto8qyIuzWBcuAGwcInhHKQ== X-Google-Smtp-Source: ABdhPJyIXhpRY5+xrrWQWHBOx4U7a8KKbOQa/X1X+O8JFXBeneV7Orkum10v75m5Ln+ryBniWSTy9Q== X-Received: by 2002:ae9:f50a:: with SMTP id o10mr9800904qkg.387.1629293919511; Wed, 18 Aug 2021 06:38:39 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-f93a-0b29-d1e6-92fc.res6.spectrum.com. [2603:6081:7b01:cbda:f93a:b29:d1e6:92fc]) by smtp.gmail.com with ESMTPSA id i18sm3553673qkk.115.2021.08.18.06.38.38 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Aug 2021 06:38:38 -0700 (PDT) Date: Wed, 18 Aug 2021 09:38:37 -0400 From: Tom Rini To: Anatolij Gustschin Cc: u-boot@lists.denx.de, Samuel Egli , Heiko Schocher Subject: Re: [PATCH 05/13] siemens: Move CONFIG_SYS_I2C_EEPROM_ADDR usage out of CONFIG namespace Message-ID: <20210818133837.GR858@bill-the-cat> References: <20210817220009.22721-1-trini@konsulko.com> <20210817220009.22721-6-trini@konsulko.com> <20210818110228.74958771@crub> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WA5LXqLFUosN1weT" Content-Disposition: inline In-Reply-To: <20210818110228.74958771@crub> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --WA5LXqLFUosN1weT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 18, 2021 at 11:02:28AM +0200, Anatolij Gustschin wrote: > On Tue, 17 Aug 2021 17:59:40 -0400 > Tom Rini trini@konsulko.com wrote: >=20 > > The instances of CONFIG_SYS_I2C_EEPROM_ADDR on these platforms doesn't > > match up with the rest of the EERPOM related defines in U-Boot. Move > > these out of the CONFIG namespace rather than make complex Kconfig > > logic. > >=20 > > Cc: Samuel Egli > > Cc: Anatolij Gustschin > > Cc: Heiko Schocher > > Signed-off-by: Tom Rini >=20 > Reviewed-by: Anatolij Gustschin >=20 > But probably some more cleanup in other board config headers needed, > see comment below. >=20 > ... > > diff --git a/include/configs/draco.h b/include/configs/draco.h > > index 396eb7ded500..7c1f071d99ec 100644 > > --- a/include/configs/draco.h > > +++ b/include/configs/draco.h > > @@ -32,10 +32,6 @@ > > /* I2C Configuration */ > > #define CONFIG_SYS_I2C_SPEED 100000 > > =20 > > -#define CONFIG_SYS_I2C_EEPROM_ADDR 0x50 > > -#define EEPROM_ADDR_DDR3 0x90 > > -#define EEPROM_ADDR_CHIP 0x120 >=20 > these defines are also in >=20 > include/configs/etamin.h > include/configs/rastaban.h > include/configs/thuban.h Yes, it would be good for the board maintainers to follow up with more clean-up and migrate some siemens-specific symbols to Kconfig. I'm trying to not get too far off track and focus on just getting symbols in to Kconfig or out of CONFIG namespace right now. Thanks! --=20 Tom --WA5LXqLFUosN1weT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEdDVwACgkQFHw5/5Y0 tyxq6wwAoQnnbKzdb1qllIqAJNrXROFRk2WMjDFKQKqBJzkKO5bVIzEvaDAgV72e /qN9OgLbJpeOGXuRhCm7USLGpEc7QIXNpFLFB0Qh/piGvXH16MapZuNgEBqd9oNo etwgdvVKMt1lt1lIRr4xcyTV08Nb7YVD49wlGREcxFRAa/5OsQGwYLeeaKbulPVV 6k/t9FJD+J8nP18ugZPoBgaMhw5ZRgjalvL0qmtHJE60IEd1baFla7yBmLWo8wSu DdDdEOG5vzDvBb/57NptqcKHjBFthI6NvhpBqnG3+pet5XCYIvP+BtiWrGuUxQaU SN3V5k4iMsubIbKcB4eYkwhFx6xOtEYFSaipa/7RwGVpR2wKtHq/piGDWM0g71hp UVNth9Ghhe2RgaXiU7JK21jkOba7UM62YXTw36sERICpWgzrlVKVMhif3OsqTMO8 U4O/ywi40g/V0U03KXqqmR3tsJfYvIHXvz+vP8idvGU/mT4qadCsaKagg45hGIrK +EWw/iYL =ItGK -----END PGP SIGNATURE----- --WA5LXqLFUosN1weT--