Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B544DC4338F for ; Fri, 20 Aug 2021 05:13:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 845C861037 for ; Fri, 20 Aug 2021 05:13:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233108AbhHTFNn (ORCPT ); Fri, 20 Aug 2021 01:13:43 -0400 Received: from verein.lst.de ([213.95.11.211]:39747 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231524AbhHTFNn (ORCPT ); Fri, 20 Aug 2021 01:13:43 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 92A9C6736F; Fri, 20 Aug 2021 07:13:03 +0200 (CEST) Date: Fri, 20 Aug 2021 07:13:03 +0200 From: Christoph Hellwig To: Hannes Reinecke Cc: "Martin K. Petersen" , Christoph Hellwig , James Bottomley , Matthew Wilcox , linux-scsi@vger.kernel.org Subject: Re: [PATCH 1/4] sym53c8xx_2: move PCI EEH handling to host reset Message-ID: <20210820051303.GA27915@lst.de> References: <20210819090716.94049-1-hare@suse.de> <20210819090716.94049-2-hare@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210819090716.94049-2-hare@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Thu, Aug 19, 2021 at 11:07:13AM +0200, Hannes Reinecke wrote: > When PCI EEH is active the entire card will be reset; which means > that we _have_ to do the equivalent of a eh_host_reset(). > So trying to do it from other EH callbacks is pointless, and we > should delegate it to eh_host_reset(). > > Signed-off-by: Hannes Reinecke Looks good, Reviewed-by: Christoph Hellwig