Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EACF9C4338F for ; Fri, 20 Aug 2021 17:51:14 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B7A060F58 for ; Fri, 20 Aug 2021 17:51:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1B7A060F58 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BE25E80C85; Fri, 20 Aug 2021 19:51:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="Q2p8FUXu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A5EBC80F4B; Fri, 20 Aug 2021 19:51:10 +0200 (CEST) Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 65AD080796 for ; Fri, 20 Aug 2021 19:51:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=nm@ti.com Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 17KHp4AI056633; Fri, 20 Aug 2021 12:51:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1629481864; bh=AwEqtUANxhRzOC8dk4pLSg/8vF5Sx9zuZ1YrkSWhwmc=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=Q2p8FUXuu7iBnA+T12cLgP4lL3lTgic+yPCu3T2fjq4FA8KftuQunIVawoNxinZye 4lXOLQadWOSn2cTLM/KJFX2LTNxeJtXPPEmxq7GG2sE8/6IblJ0/XCSH8vLrr5BYGC LObDt9xHs6Q7H4PINtOESvAJ9eP1NV0aWt/e/URU= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 17KHp3F0114972 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 20 Aug 2021 12:51:04 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 20 Aug 2021 12:51:03 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Fri, 20 Aug 2021 12:51:03 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 17KHp39b127316; Fri, 20 Aug 2021 12:51:03 -0500 Date: Fri, 20 Aug 2021 12:51:03 -0500 From: Nishanth Menon To: Roger Quadros CC: , Subject: Re: [PATCH] ARM: dts: Fix node status to "okay" on TI boards Message-ID: <20210820175103.c7phsyewcr6yy6sy@elastic> References: <20210820104131.13188-1-rogerq@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210820104131.13188-1-rogerq@kernel.org> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 13:41-20210820, Roger Quadros wrote: > As per Device Tree core schema [1], status parameter of nodes can be either > "okay" or "disabled". > > U-boot Driver Model does not recognize status="ok" and treats > the node as disabled. > Did you miss: [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3 Also, I think it might be better to refer to the specification than the schema implementation of the specification. > Signed-off-by: Roger Quadros > --- > arch/arm/dts/am3517-evm-ui.dtsi | 4 ++-- > arch/arm/dts/am3517-evm.dts | 2 +- > arch/arm/dts/am437x-gp-evm.dts | 2 +- > arch/arm/dts/am43x-epos-evm.dts | 2 +- > arch/arm/dts/am57xx-beagle-x15-common.dtsi | 6 +++--- > arch/arm/dts/da850-evm.dts | 2 +- > arch/arm/dts/dra7-evm.dts | 2 +- > arch/arm/dts/dra72-evm-common.dtsi | 6 +++--- > arch/arm/dts/keystone-k2e-evm.dts | 2 +- > arch/arm/dts/keystone-k2hk-evm.dts | 2 +- > arch/arm/dts/keystone-k2l-evm.dts | 2 +- > arch/arm/dts/omap3-beagle-xm.dts | 4 ++-- > arch/arm/dts/omap3-beagle.dts | 6 +++--- > arch/arm/dts/omap3-igep0020-common.dtsi | 2 +- > arch/arm/dts/omap3-panel-sharp-ls037v7dw01.dtsi | 2 +- > arch/arm/dts/omap34xx.dtsi | 2 +- > arch/arm/dts/omap36xx.dtsi | 2 +- > arch/arm/dts/omap4-panda-common.dtsi | 6 +++--- > arch/arm/dts/omap4-sdp.dts | 8 ++++---- > arch/arm/dts/omap5-board-common.dtsi | 4 ++-- > 20 files changed, 34 insertions(+), 34 deletions(-) > > diff --git a/arch/arm/dts/am3517-evm-ui.dtsi b/arch/arm/dts/am3517-evm-ui.dtsi > index e841918c1c..54aa2522aa 100644 > --- a/arch/arm/dts/am3517-evm-ui.dtsi > +++ b/arch/arm/dts/am3517-evm-ui.dtsi > @@ -186,14 +186,14 @@ > }; > > &mcbsp1 { > - status = "ok"; > + status = "okay"; > #sound-dai-cells = <0>; > pinctrl-names = "default"; > pinctrl-0 = <&mcbsp1_pins>; > }; > > &mcbsp2 { > - status = "ok"; > + status = "okay"; > #sound-dai-cells = <0>; > pinctrl-names = "default"; > pinctrl-0 = <&mcbsp2_pins>; > diff --git a/arch/arm/dts/am3517-evm.dts b/arch/arm/dts/am3517-evm.dts > index 3527c0f2df..935c471c97 100644 > --- a/arch/arm/dts/am3517-evm.dts > +++ b/arch/arm/dts/am3517-evm.dts > @@ -193,7 +193,7 @@ > }; > > &dss { > - status = "ok"; > + status = "okay"; > > pinctrl-names = "default"; > pinctrl-0 = <&dss_dpi_pins>; > diff --git a/arch/arm/dts/am437x-gp-evm.dts b/arch/arm/dts/am437x-gp-evm.dts > index 3c500d52db..21f7691f49 100644 > --- a/arch/arm/dts/am437x-gp-evm.dts > +++ b/arch/arm/dts/am437x-gp-evm.dts > @@ -742,7 +742,7 @@ > }; > > &dss { > - status = "ok"; > + status = "okay"; > > pinctrl-names = "default"; > pinctrl-0 = <&dss_pins>; > diff --git a/arch/arm/dts/am43x-epos-evm.dts b/arch/arm/dts/am43x-epos-evm.dts > index 65f157ed59..b940bc6ccf 100644 > --- a/arch/arm/dts/am43x-epos-evm.dts > +++ b/arch/arm/dts/am43x-epos-evm.dts > @@ -752,7 +752,7 @@ > }; > > &dss { > - status = "ok"; > + status = "okay"; > > pinctrl-names = "default"; > pinctrl-0 = <&dss_pins>; > diff --git a/arch/arm/dts/am57xx-beagle-x15-common.dtsi b/arch/arm/dts/am57xx-beagle-x15-common.dtsi > index d6b94d528f..1912ea9a15 100644 > --- a/arch/arm/dts/am57xx-beagle-x15-common.dtsi > +++ b/arch/arm/dts/am57xx-beagle-x15-common.dtsi > @@ -528,13 +528,13 @@ > }; > > &dss { > - status = "ok"; > + status = "okay"; > > vdda_video-supply = <&ldoln_reg>; > }; > > &hdmi { > - status = "ok"; > + status = "okay"; > vdda-supply = <&ldo4_reg>; > > port { > @@ -545,7 +545,7 @@ > }; > > &pcie1_rc { > - status = "ok"; > + status = "okay"; > gpios = <&gpio2 8 GPIO_ACTIVE_LOW>; > }; > > diff --git a/arch/arm/dts/da850-evm.dts b/arch/arm/dts/da850-evm.dts > index f04bc3e153..b331cefd18 100644 > --- a/arch/arm/dts/da850-evm.dts > +++ b/arch/arm/dts/da850-evm.dts > @@ -405,7 +405,7 @@ > &aemif { > pinctrl-names = "default"; > pinctrl-0 = <&nand_pins>; > - status = "ok"; > + status = "okay"; > cs3 { > #address-cells = <2>; > #size-cells = <1>; > diff --git a/arch/arm/dts/dra7-evm.dts b/arch/arm/dts/dra7-evm.dts > index 43de9638e3..8e9a1a80a8 100644 > --- a/arch/arm/dts/dra7-evm.dts > +++ b/arch/arm/dts/dra7-evm.dts > @@ -501,7 +501,7 @@ > }; > > &dcan1 { > - status = "ok"; > + status = "okay"; > pinctrl-names = "default", "sleep", "active"; > pinctrl-0 = <&dcan1_pins_sleep>; > pinctrl-1 = <&dcan1_pins_sleep>; > diff --git a/arch/arm/dts/dra72-evm-common.dtsi b/arch/arm/dts/dra72-evm-common.dtsi > index 2e485a13df..964e5e9b90 100644 > --- a/arch/arm/dts/dra72-evm-common.dtsi > +++ b/arch/arm/dts/dra72-evm-common.dtsi > @@ -430,7 +430,7 @@ > }; > > &dcan1 { > - status = "ok"; > + status = "okay"; > pinctrl-names = "default", "sleep", "active"; > pinctrl-0 = <&dcan1_pins_sleep>; > pinctrl-1 = <&dcan1_pins_sleep>; > @@ -499,11 +499,11 @@ > }; > > &dss { > - status = "ok"; > + status = "okay"; > }; > > &hdmi { > - status = "ok"; > + status = "okay"; > > port { > hdmi_out: endpoint { > diff --git a/arch/arm/dts/keystone-k2e-evm.dts b/arch/arm/dts/keystone-k2e-evm.dts > index 9288df21ce..bb197e133e 100644 > --- a/arch/arm/dts/keystone-k2e-evm.dts > +++ b/arch/arm/dts/keystone-k2e-evm.dts > @@ -142,7 +142,7 @@ > }; > > &mdio { > - status = "ok"; > + status = "okay"; > ethphy0: ethernet-phy@0 { > compatible = "marvell,88E1514", "marvell,88E1510", "ethernet-phy-ieee802.3-c22"; > reg = <0>; > diff --git a/arch/arm/dts/keystone-k2hk-evm.dts b/arch/arm/dts/keystone-k2hk-evm.dts > index 84c58d75ad..acfcaff0a8 100644 > --- a/arch/arm/dts/keystone-k2hk-evm.dts > +++ b/arch/arm/dts/keystone-k2hk-evm.dts > @@ -170,7 +170,7 @@ > }; > > &mdio { > - status = "ok"; > + status = "okay"; > ethphy0: ethernet-phy@0 { > compatible = "marvell,88E1111", "ethernet-phy-ieee802.3-c22"; > reg = <0>; > diff --git a/arch/arm/dts/keystone-k2l-evm.dts b/arch/arm/dts/keystone-k2l-evm.dts > index 91cefdf2aa..ca049ba81b 100644 > --- a/arch/arm/dts/keystone-k2l-evm.dts > +++ b/arch/arm/dts/keystone-k2l-evm.dts > @@ -119,7 +119,7 @@ > }; > > &mdio { > - status = "ok"; > + status = "okay"; > ethphy0: ethernet-phy@0 { > compatible = "marvell,88E1514", "marvell,88E1510", "ethernet-phy-ieee802.3-c22"; > reg = <0>; > diff --git a/arch/arm/dts/omap3-beagle-xm.dts b/arch/arm/dts/omap3-beagle-xm.dts > index 0349fcc9dc..8461159baf 100644 > --- a/arch/arm/dts/omap3-beagle-xm.dts > +++ b/arch/arm/dts/omap3-beagle-xm.dts > @@ -379,7 +379,7 @@ > }; > > &dss { > - status = "ok"; > + status = "okay"; > > pinctrl-names = "default"; > pinctrl-0 = < > @@ -396,7 +396,7 @@ > }; > > &venc { > - status = "ok"; > + status = "okay"; > > vdda-supply = <&vdac>; > > diff --git a/arch/arm/dts/omap3-beagle.dts b/arch/arm/dts/omap3-beagle.dts > index 3ca8991a6c..4ceee2ba19 100644 > --- a/arch/arm/dts/omap3-beagle.dts > +++ b/arch/arm/dts/omap3-beagle.dts > @@ -353,7 +353,7 @@ > }; > > &dss { > - status = "ok"; > + status = "okay"; > > pinctrl-names = "default"; > pinctrl-0 = <&dss_dpi_pins>; > @@ -367,7 +367,7 @@ > }; > > &venc { > - status = "ok"; > + status = "okay"; > > vdda-supply = <&vdac>; > > @@ -380,7 +380,7 @@ > }; > > &gpmc { > - status = "ok"; > + status = "okay"; > ranges = <0 0 0x30000000 0x1000000>; /* CS0 space, 16MB */ > > /* Chip select 0 */ > diff --git a/arch/arm/dts/omap3-igep0020-common.dtsi b/arch/arm/dts/omap3-igep0020-common.dtsi > index ecbec23af4..d62481dacd 100644 > --- a/arch/arm/dts/omap3-igep0020-common.dtsi > +++ b/arch/arm/dts/omap3-igep0020-common.dtsi > @@ -248,7 +248,7 @@ > }; > > &dss { > - status = "ok"; > + status = "okay"; > > port { > dpi_out: endpoint { > diff --git a/arch/arm/dts/omap3-panel-sharp-ls037v7dw01.dtsi b/arch/arm/dts/omap3-panel-sharp-ls037v7dw01.dtsi > index b8b9fcc41e..2dbb687d4d 100644 > --- a/arch/arm/dts/omap3-panel-sharp-ls037v7dw01.dtsi > +++ b/arch/arm/dts/omap3-panel-sharp-ls037v7dw01.dtsi > @@ -46,7 +46,7 @@ > }; > > &dss { > - status = "ok"; > + status = "okay"; > port { > dpi_out: endpoint { > remote-endpoint = <&lcd_in>; > diff --git a/arch/arm/dts/omap34xx.dtsi b/arch/arm/dts/omap34xx.dtsi > index ac4f8795b7..a703d09736 100644 > --- a/arch/arm/dts/omap34xx.dtsi > +++ b/arch/arm/dts/omap34xx.dtsi > @@ -69,7 +69,7 @@ > }; > > &ssi { > - status = "ok"; > + status = "okay"; > > clocks = <&ssi_ssr_fck>, > <&ssi_sst_fck>, > diff --git a/arch/arm/dts/omap36xx.dtsi b/arch/arm/dts/omap36xx.dtsi > index 6fb23ada1f..52e1b8ce0f 100644 > --- a/arch/arm/dts/omap36xx.dtsi > +++ b/arch/arm/dts/omap36xx.dtsi > @@ -153,7 +153,7 @@ > }; > > &ssi { > - status = "ok"; > + status = "okay"; > > clocks = <&ssi_ssr_fck>, > <&ssi_sst_fck>, > diff --git a/arch/arm/dts/omap4-panda-common.dtsi b/arch/arm/dts/omap4-panda-common.dtsi > index 55ea8b6189..c124b20d46 100644 > --- a/arch/arm/dts/omap4-panda-common.dtsi > +++ b/arch/arm/dts/omap4-panda-common.dtsi > @@ -546,7 +546,7 @@ > }; > > &dss { > - status = "ok"; > + status = "okay"; > > port { > dpi_out: endpoint { > @@ -557,12 +557,12 @@ > }; > > &dsi2 { > - status = "ok"; > + status = "okay"; > vdd-supply = <&vcxio>; > }; > > &hdmi { > - status = "ok"; > + status = "okay"; > vdda-supply = <&vdac>; > > port { > diff --git a/arch/arm/dts/omap4-sdp.dts b/arch/arm/dts/omap4-sdp.dts > index 91480ac1f3..28b989cfdb 100644 > --- a/arch/arm/dts/omap4-sdp.dts > +++ b/arch/arm/dts/omap4-sdp.dts > @@ -648,11 +648,11 @@ > }; > > &dss { > - status = "ok"; > + status = "okay"; > }; > > &dsi1 { > - status = "ok"; > + status = "okay"; > vdd-supply = <&vcxio>; > > port { > @@ -677,7 +677,7 @@ > }; > > &dsi2 { > - status = "ok"; > + status = "okay"; > vdd-supply = <&vcxio>; > > port { > @@ -702,7 +702,7 @@ > }; > > &hdmi { > - status = "ok"; > + status = "okay"; > vdda-supply = <&vdac>; > > port { > diff --git a/arch/arm/dts/omap5-board-common.dtsi b/arch/arm/dts/omap5-board-common.dtsi > index 68ac04641b..1eedd8d706 100644 > --- a/arch/arm/dts/omap5-board-common.dtsi > +++ b/arch/arm/dts/omap5-board-common.dtsi > @@ -743,11 +743,11 @@ > }; > > &dss { > - status = "ok"; > + status = "okay"; > }; > > &hdmi { > - status = "ok"; > + status = "okay"; > > /* vdda-supply populated in board specific dts file */ > > -- > 2.17.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D