Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B4B4C4338F for ; Mon, 23 Aug 2021 11:20:11 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9115C6138E for ; Mon, 23 Aug 2021 11:20:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9115C6138E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4C57982C93; Mon, 23 Aug 2021 13:20:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 38F4382C93; Mon, 23 Aug 2021 13:20:05 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id C3C9C82C03 for ; Mon, 23 Aug 2021 13:19:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C403D1042; Mon, 23 Aug 2021 04:19:58 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8F6623F66F; Mon, 23 Aug 2021 04:19:57 -0700 (PDT) Date: Mon, 23 Aug 2021 12:19:48 +0100 From: Andre Przywara To: Michal Simek Cc: u-boot@lists.denx.de, git@xilinx.com, Bin Meng , Chee Hong Ang , Marek =?UTF-8?B?QmVow7pu?= , Pali =?UTF-8?B?Um9ow6Fy?= , Simon Glass Subject: Re: [PATCH 07/10] Makefile: Align fit-dtb.blob and u-boot.itb by 64bits Message-ID: <20210823121948.1530e6e8@slackpad.fritz.box> In-Reply-To: <07e38a4009054fba63f6e46f393ad33efb495f4b.1629704273.git.michal.simek@xilinx.com> References: <07e38a4009054fba63f6e46f393ad33efb495f4b.1629704273.git.michal.simek@xilinx.com> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, 23 Aug 2021 09:37:54 +0200 Michal Simek wrote: > Enabling MULTI_DTB_FIT and DTB_RESELECT can end up with multi DTBs in FIT > image placed and aligned only by 32bits (4bytes). Based on device tree > specification: > "Specifically, the memory reservation block shall be aligned to an 8-byte boundary > and the structure block to a 4-byte boundary." > is 64bit (8bytes) alignment required. That's why make sure that > fit-dtb.blob and u-boot.itb as our primary target images for Xilinx ZynqMP > are all 64bit aligned. Indeed, thanks for fixing this! > > Signed-off-by: Michal Simek Reviewed-by: Andre Przywara Cheers, Andre > --- > > Changes in v2: > - Update subject and commit message > - Enable 64bit alignment for all - reported by Andre > > Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Makefile b/Makefile > index 269e353a28ad..0de909123cf9 100644 > --- a/Makefile > +++ b/Makefile > @@ -1169,6 +1169,8 @@ MKIMAGEFLAGS_fit-dtb.blob = -f auto -A $(ARCH) -T firmware -C none -O u-boot \ > -a 0 -e 0 -E \ > $(patsubst %,-b arch/$(ARCH)/dts/%.dtb,$(subst ",,$(CONFIG_OF_LIST))) -d /dev/null > > +MKIMAGEFLAGS_fit-dtb.blob += -B 0x8 > + > ifneq ($(EXT_DTB),) > u-boot-fit-dtb.bin: u-boot-nodtb.bin $(EXT_DTB) > $(call if_changed,cat) > @@ -1431,6 +1433,7 @@ MKIMAGEFLAGS_u-boot.itb = > else > MKIMAGEFLAGS_u-boot.itb = -E > endif > +MKIMAGEFLAGS_u-boot.itb += -B 0x8 > > ifdef U_BOOT_ITS > u-boot.itb: u-boot-nodtb.bin \