Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mIPNC-000365-54 for mharc-grub-devel@gnu.org; Tue, 24 Aug 2021 01:53:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42114) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3SYkkYQcKCvwqewove2ksskpi.gsqkvyf-hizipkry.svk@flex--maskray.bounces.google.com>) id 1mIPNA-00035x-Vm for grub-devel@gnu.org; Tue, 24 Aug 2021 01:53:20 -0400 Received: from mail-qk1-x74a.google.com ([2607:f8b0:4864:20::74a]:36785) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3SYkkYQcKCvwqewove2ksskpi.gsqkvyf-hizipkry.svk@flex--maskray.bounces.google.com>) id 1mIPN5-0006oL-Cy for grub-devel@gnu.org; Tue, 24 Aug 2021 01:53:20 -0400 Received: by mail-qk1-x74a.google.com with SMTP id 21-20020a370815000000b003d5a81a4d12so8346540qki.3 for ; Mon, 23 Aug 2021 22:53:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=6vvQZglU4b0rv2XAp+eLHpR8wKB53D0IZfugcyuOmBA=; b=QvdVYMvQitSTjUXRSmwLX8LINr/9qgYhAp29Zb46+znJcpoi0HTp7mnSHrqePnrjvA gbUpDE9iempVisrtCkP1s8afbJlgVGsNjvq9sUWBNfAdmVqNOLh7aJbVGwEmwqEn6Hs1 lij5Iq/WYCTUzqqeuSmIGiGxsoME8NW6MrsFqE15BCtRD5awiyiMilVM2TXwwWqTDC2w WjZc6UtA0DeGvcBZoM2y7qYsnVaaVnScgyV7SPgHWnaLyXmKpeycXBFbkkNIWoCHE4zR pnM5w2ipfRgZ199hg7kIg2i+JUNswH457hId0Uj44OiEdwxHOYOOauJf1SKbfOLxkNsn lflg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=6vvQZglU4b0rv2XAp+eLHpR8wKB53D0IZfugcyuOmBA=; b=aY3ndoMb3YsVtdalxaBITGC2qjdsoeaGNPOB8wUAJrLwYlaG0OyeIvlOm6vtQ6vb+Y AyIbTzgPEPgqN/2bDOTNJ+fFl9VRQupg4gl4qMLBHVWRbrswsUjeJYHEQk70oJ13eTOZ K0uAP93oGSHDESvrGyz47g4ko7vasJTp8NdSuClhp7yPOugygjPuK+4NEycUP4Yl3bjZ ZdCw84wAzMBJ9W4RQ3mbgu8EIsHUIAWbxUStfPGHbw/2ug5FQX3elhC7DYLOESjsHW0g shaAG4cAMgWjJPyPHwvgf2L760CmOzEC0GFU+0TTaGfNlhTL0egI25+Zym4j7LxXnaBs a0Dw== X-Gm-Message-State: AOAM533vEuYqSVlfYDIcM0mmz2Wgkbyn9G5UdxW30mumaVBjjhohD1vy vKowqfOQxWh7OnWMRMy7WsaqPUuCcW4kKrZwGRvj4x95OVpNwfYFMmFFYyN6K5cMfpceZOlrEAt on28PqXM5JeiN3QVt5a/T2/WgcTbPvMK8CBzsanb8UkaFewEwdahTNO4JuYc= X-Google-Smtp-Source: ABdhPJwyNDidzzvHXn0ILwoHslOzwi1Dg29ZIH+yFmBTBsUp3C6NmDNkMCmAm86ZutbmshDQqQLcDc6Ubhm6 X-Received: from maskray1.svl.corp.google.com ([2620:15c:2ce:200:196f:5297:b0e8:1313]) (user=maskray job=sendgmr) by 2002:a05:6214:2247:: with SMTP id c7mr282259qvc.17.1629784393373; Mon, 23 Aug 2021 22:53:13 -0700 (PDT) Date: Mon, 23 Aug 2021 22:53:09 -0700 Message-Id: <20210824055309.3528861-1-maskray@google.com> Mime-Version: 1.0 Subject: [PATCH v2] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1 From: Fangrui Song To: grub-devel@gnu.org, Daniel Kiper , Alex Burmashev , "Vladimir 'phcoder' Serbinenko" Cc: Fangrui Song Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::74a; envelope-from=3SYkkYQcKCvwqewove2ksskpi.gsqkvyf-hizipkry.svk@flex--maskray.bounces.google.com; helo=mail-qk1-x74a.google.com X-Spam_score_int: -95 X-Spam_score: -9.6 X-Spam_bar: --------- X-Spam_report: (-9.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Aug 2021 05:53:21 -0000 Clang does not support -falign-jumps and only recently gained support for -falign-loops. Test all the alignment options to avoid passing unrecognized options to Clang: clang-14: error: optimization flag '-falign-jumps=1' is not supported [-Werror,-Wignored-optimization-argument] When compiled with older Clang, the alignment options are not added, so just avoid the complexity for each option. While here, remove checks for the obsoleted -malign-* forms. GCC has supported the preferred -falign-* forms since 3.2. Signed-off-by: Fangrui Song --- configure.ac | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index bee28dbeb..8625e6776 100644 --- a/configure.ac +++ b/configure.ac @@ -798,24 +798,16 @@ fi # Force no alignment to save space on i386. if test "x$target_cpu" = xi386; then - AC_CACHE_CHECK([whether -falign-loops works], [grub_cv_cc_falign_loop], [ - CFLAGS="$TARGET_CFLAGS -falign-loops=1 -Werror" + AC_CACHE_CHECK([whether -falign-jumps=1 -falign-loops=1 -falign-functions=1 works], + [grub_cv_cc_falign_loop], [ + CFLAGS="$TARGET_CFLAGS -falign-jumps=1 -falign-loops=1 -falign-functions=1 -Werror" AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])], [grub_cv_cc_falign_loop=yes], [grub_cv_cc_falign_loop=no]) ]) - AC_CACHE_CHECK([whether -malign-loops works], [grub_cv_cc_malign_loop], [ - CFLAGS="$TARGET_CFLAGS -malign-loops=1 -Werror" - AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])], - [grub_cv_cc_malign_loop=yes], - [grub_cv_cc_malign_loop=no]) - ]) - if test "x$grub_cv_cc_falign_loop" = xyes; then TARGET_CFLAGS="$TARGET_CFLAGS -falign-jumps=1 -falign-loops=1 -falign-functions=1" - elif test "x$grub_cv_cc_malign_loop" = xyes; then - TARGET_CFLAGS="$TARGET_CFLAGS -malign-jumps=1 -malign-loops=1 -malign-functions=1" fi fi -- 2.33.0.rc2.250.ged5fa647cd-goog