Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mIPWt-0004OH-05 for mharc-grub-devel@gnu.org; Tue, 24 Aug 2021 02:03:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIPWr-0004O8-Ud for grub-devel@gnu.org; Tue, 24 Aug 2021 02:03:22 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]:35348) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mIPWh-0006j1-Hi for grub-devel@gnu.org; Tue, 24 Aug 2021 02:03:21 -0400 Received: by mail-pf1-x432.google.com with SMTP id x16so17389943pfh.2 for ; Mon, 23 Aug 2021 23:03:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=kr2GNEx/EZBGctA9333/zpnTzunIxMhE+itQxLVlW58=; b=R/dT2cUEqCbwSQ3QBEIfHhUl3jzDY3+GAQAj4NOJvIj9CtLt2yZtT9EgSssf44JEnj tHOnSamfM1QM3csCIjozaXEQ8sLDaH05bXWnGaVFrzt9tJyF4h376VnFLH46+7c/dT5y 3AKUNQscSR0Bryejdws9Cld5//hetSv/qBwM0KKLXxHTCO2FAqxXiVkDUgwV+Fq3Qjab i1NfxCNmn8nGLKNRnXyzUUOya4nFy6i5ZLlI52pgsGGrdSdjCbbueE/x9u9pL5eeRN+R X69AtIMIOXAafEEHEHz3oyKXhTg75mB7Ehe5VBnRz7+1E7EyCe0p4eedS/9T3cWBHmLN Uxrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=kr2GNEx/EZBGctA9333/zpnTzunIxMhE+itQxLVlW58=; b=GFTxPhaGzfETg9LkQbFjsj4AEDFNdeYVVRFKdpYGRpuUiPMbtHb4+BwNUN78j/fDq8 pTpaEpAYv3AWHaMrbo4H7drAmHlSMYm17uoB3syhtrHl1hUOC94aZdFZU4cToElThGnj qILmUZDADrCbrV2Yr3i1VPzUuUoeeAYydLyD3dhacvxcEaoqx+z21gUuYkKzhD79kEXg epp/JxnbrabwIFMMgNpWFs6GdYlsY8qSf3vjaOoo3BKIv8EdeVx55B9RzmPnzTxzSlT/ fad1uBDlw1OUO9aMdQgr/DRxHt6uUa2cnF4Zo4nUwG9QMJ/gd9uZ4noqWh028LIQYwlc 7Ynw== X-Gm-Message-State: AOAM5325RB1OmuYjy5iqLdOJZNcWdAEkx7I2LcU5l9aFrayCzQLxAkko HLMc0Qz1ZHQ1I75HY0xwnqjmTw== X-Google-Smtp-Source: ABdhPJz0RJlu6i01BLN7BYeXrbhisbUsbcNjhhRYxxgqmkgchkGs0Sz87k8fO2HbDDdU3Y17sridOg== X-Received: by 2002:a63:374e:: with SMTP id g14mr35566276pgn.170.1629784989775; Mon, 23 Aug 2021 23:03:09 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:196f:5297:b0e8:1313]) by smtp.gmail.com with ESMTPSA id s1sm14465539pfd.13.2021.08.23.23.03.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 23:03:09 -0700 (PDT) Date: Mon, 23 Aug 2021 23:03:05 -0700 From: Fangrui Song To: Paul Menzel Cc: grub-devel@gnu.org Subject: Re: [PATCH] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1 Message-ID: <20210824060305.6kqqopkmpw4cb6tv@google.com> References: <20210816190625.2878309-1-maskray@google.com> <448b4333-2f90-ed3c-5206-af4739a5fe88@molgen.mpg.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <448b4333-2f90-ed3c-5206-af4739a5fe88@molgen.mpg.de> Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=maskray@google.com; helo=mail-pf1-x432.google.com X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Aug 2021 06:03:22 -0000 Hi Paul, Thank you for your suggestions. I just sent v2 https://lists.gnu.org/archive/html/grub-devel/2021-08/msg00091.html with a further cleanup. On 2021-08-24, Paul Menzel wrote: >Dear Fangrui, > > >Am 16.08.21 um 21:06 schrieb Fangrui Song via Grub-devel: >>Clang 14.0.0 has implemented -falign-loops=1 but -falign-jumps=1 is >>still unsupported. The check should test all flags which may be added > >“alignment” flags? Done. >>into CFLAGS. >> >>Signed-off-by: Fangrui Song >>--- >> configure.ac | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >>diff --git a/configure.ac b/configure.ac >>index bee28dbeb..b2fd0c3e4 100644 >>--- a/configure.ac >>+++ b/configure.ac >>@@ -799,14 +799,14 @@ fi >> # Force no alignment to save space on i386. >> if test "x$target_cpu" = xi386; then >> AC_CACHE_CHECK([whether -falign-loops works], [grub_cv_cc_falign_loop], [ >>- CFLAGS="$TARGET_CFLAGS -falign-loops=1 -Werror" >>+ CFLAGS="$TARGET_CFLAGS -falign-jumps=1 -falign-loops=1 -falign-functions=1 -Werror" > >I guess the `AC_CACHE_CHECK` description needs to be updated too? > >Please mention in the commit message, why a separate check for each >switch is not useful. Done >> AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])], >> [grub_cv_cc_falign_loop=yes], >> [grub_cv_cc_falign_loop=no]) >> ]) >> AC_CACHE_CHECK([whether -malign-loops works], [grub_cv_cc_malign_loop], [ >>- CFLAGS="$TARGET_CFLAGS -malign-loops=1 -Werror" >>+ CFLAGS="$TARGET_CFLAGS -malign-jumps=1 -malign-loops=1 -malign-functions=1 -Werror" >> AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])], >> [grub_cv_cc_malign_loop=yes], >> [grub_cv_cc_malign_loop=no]) >> > >When you sent the v2, please include the maintainers listed in >`MAINTAINERS` in the recipient list. Done. > >Kind regards, > >Paul