Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EEF1C4338F for ; Tue, 24 Aug 2021 14:10:51 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FE306103E for ; Tue, 24 Aug 2021 14:10:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8FE306103E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 70A6580612; Tue, 24 Aug 2021 16:10:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="cSirx/NF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8FE80805DF; Tue, 24 Aug 2021 16:10:45 +0200 (CEST) Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DEE1781269 for ; Tue, 24 Aug 2021 16:10:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=aford173@gmail.com Received: by mail-il1-x133.google.com with SMTP id s16so20619175ilo.9 for ; Tue, 24 Aug 2021 07:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pAC8Y9BjWGw46ZXIEBV9Fb+bMHV75Ziv2V09PTxKDF4=; b=cSirx/NFzPDevTSrB8ckc5mT4VglUiHuKzb6hTgCsE90Rra2XDoPVoEYJrRqG1YYcg jIbcOoBDN3s6pXQcPyWNi0lknSefGlmnrC4jEHvMh9L6fV1gY6PDRAjxXi1Hdth9Gu3L aHC8fzBSBfNxQ55AYH1Wk5rx9eSFLVJvG5FJ7aK9S+YpZuMRc+AEPklemK39iDvW8RkU HRb/auEIQBARpl7ZPBfr4Z2lzElvqhIBpBY7Cl87m6rBHjBRExeGHTPyirf42G53FpEa RueEijsUmWE1YP362jCgGjf2K5mPLhEVltUxMxuubuB9UWgKW/WuDP/Mlc00TmCfTgFc v7qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pAC8Y9BjWGw46ZXIEBV9Fb+bMHV75Ziv2V09PTxKDF4=; b=aA9+TgWnRK8R1RO+KPfdVE0F4lWBYEfq6jE71vdbQOTWadyTkGRxu51lCAx25sxSjs 54iUYnFVNCsTIbyoPGn2ucqB3resH1otntsc9NGAh/eOQ7un0b5JYTkZZVkwILUStubh iOBz1XvkGjvCQp+l0CVGKtXP7TKe5GRDzebpGF5IQ0KAX02dM+j9fuhFJ9otNE9gUzbE RspC9GQruoluJf26sh/2/u5iWCoG95sce2Rf4EWH+hvM/p3m3p/fSq3sZDItaRRbxkBT 5MMSSSOe6U2X3QRh+tz83QWUev56aRz4LmAcJQ+z0i/T8OBt9DxzWc+knbB8cQSmK8eZ ktRQ== X-Gm-Message-State: AOAM533wPF4YCfXoUNxWvl+U0Vf1hUWWADk0TXk6ystUgMuikAzziLj8 R69lBkO34jAz9oCCShpQrk4XhfHvKX13hg== X-Google-Smtp-Source: ABdhPJx/eVR38Idr2xjhJD16hcMtbkCu9Tnkcw90aRJqD2NMByxVybA6OypFEE2HllruYyTrU48O4Q== X-Received: by 2002:a92:7f03:: with SMTP id a3mr27630249ild.254.1629814238997; Tue, 24 Aug 2021 07:10:38 -0700 (PDT) Received: from aford-IdeaCentre-A730.lan (c-73-37-219-234.hsd1.mn.comcast.net. [73.37.219.234]) by smtp.gmail.com with ESMTPSA id a17sm9962626ilp.75.2021.08.24.07.10.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Aug 2021 07:10:38 -0700 (PDT) From: Adam Ford To: u-boot@lists.denx.de Cc: hs@denx.de, biju.das.jz@bp.renesas.com, Adam Ford Subject: [PATCH] i2c: rcar_i2c: Enable configuring SCL rise and fall times Date: Tue, 24 Aug 2021 09:10:31 -0500 Message-Id: <20210824141031.53770-1-aford173@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean The Linux i2c driver supports i2c-scl-rising-time-ns, and i2c-scl-falling-time-ns, but U-Boot uses hard-coded values for these values. Update the calculation by fetching them from the device tree if present and use the previous values as the default if they are missing. Signed-off-by: Adam Ford diff --git a/drivers/i2c/rcar_i2c.c b/drivers/i2c/rcar_i2c.c index 14bb6603d5..d9ece5e3a8 100644 --- a/drivers/i2c/rcar_i2c.c +++ b/drivers/i2c/rcar_i2c.c @@ -64,6 +64,8 @@ enum rcar_i2c_type { struct rcar_i2c_priv { void __iomem *base; struct clk clk; + u32 fall_ns; + u32 rise_ns; u32 intdelay; u32 icccr; enum rcar_i2c_type type; @@ -278,7 +280,7 @@ static int rcar_i2c_set_speed(struct udevice *dev, uint bus_freq_hz) * = F[sum * ick / 1000000000] * = F[(ick / 1000000) * sum / 1000] */ - sum = 35 + 200 + priv->intdelay; + sum = priv->fall_ns + priv->rise_ns + priv->intdelay; round = (ick + 500000) / 1000000 * sum; round = (round + 500) / 1000; @@ -323,6 +325,10 @@ static int rcar_i2c_probe(struct udevice *dev) int ret; priv->base = dev_read_addr_ptr(dev); + priv->rise_ns = dev_read_u32_default(dev, + "i2c-scl-rising-time-ns", 200); + priv->fall_ns = dev_read_u32_default(dev, + "i2c-scl-falling-time-ns", 35); priv->intdelay = dev_read_u32_default(dev, "i2c-scl-internal-delay-ns", 5); priv->type = dev_get_driver_data(dev); -- 2.25.1