Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D772C4338F for ; Wed, 25 Aug 2021 01:19:56 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7079D610CE for ; Wed, 25 Aug 2021 01:19:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7079D610CE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 84A0E82DF6; Wed, 25 Aug 2021 03:19:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="dyTPlzpM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AF36282DFE; Wed, 25 Aug 2021 03:19:51 +0200 (CEST) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EDE9182DB2 for ; Wed, 25 Aug 2021 03:19:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72b.google.com with SMTP id a66so6646143qkc.1 for ; Tue, 24 Aug 2021 18:19:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=kRMU750fqcYbeN6OoyG89bGqcIS77t6XO2rOJ5EN82w=; b=dyTPlzpM/lB9RZf/Ogw/MdvaOZCNnhTe4TXHFJaC00tL+ftbMOFiXMA1fwOjvU5A93 6kALGjxQcbSNM+8rr6KGZP0gWFpVYkVWIPiPBWIr8snaVwgdPRwB1e0Lb+I8a1hW0yxE glNYIvCu42m3+M8qFb4BYv0EyswNtfMwW+kO0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=kRMU750fqcYbeN6OoyG89bGqcIS77t6XO2rOJ5EN82w=; b=PioClO2jkrB1jPktJvp1hfYFLTRtyj3wfkDWeBkfg7IEYIUtQBNIx9rgXiqgKSDN75 jwKztu/d5vAm32ZDfnmTxHkEVCkUYVEkrxkF/MCuLJKlAjVO62D9LwGAxBJgPT17JujT 3jAuVP4fUxBJi97B0tKjRTlx4NHf7LCb+a/mPA9QqvCr9un/TT+jk/yi3JYSSEvcUKX5 6byCvIDXHDmuzXJzu1H72xnaO2lBh3EMKniDf+m7gE63hiBneEGmzKsmfV5+6WiMMUrA ukDNB61v9Xs7jxOdHFvAE2b7fsuZt1chJhee0GOakhHTOrjjvmBGE6PT58ryDESnZF7F F3xw== X-Gm-Message-State: AOAM531mSS1NbivwVMYSeWD8xfPBRAyrT3oT+JX74OQPXwO2+jILYuck nrEF5oFruNioxncQkB1TF/tSyw== X-Google-Smtp-Source: ABdhPJzFwJR3m3omp2vjbqhrkOVzCV/wCIytXmQIkA9ArJi2zw4PtAJdv0Ul8DjuQ670xuJio2wvMw== X-Received: by 2002:a05:620a:1325:: with SMTP id p5mr29762137qkj.29.1629854385715; Tue, 24 Aug 2021 18:19:45 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-48fb-97cb-8afe-8d4e.res6.spectrum.com. [2603:6081:7b01:cbda:48fb:97cb:8afe:8d4e]) by smtp.gmail.com with ESMTPSA id b19sm12232617qkc.7.2021.08.24.18.19.44 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Aug 2021 18:19:45 -0700 (PDT) Date: Tue, 24 Aug 2021 21:19:43 -0400 From: Tom Rini To: Troy Kisky Cc: u-boot@lists.denx.de Subject: Re: [PATCH 4/6] nitrogen6x: Migrate DDR_MB to Kconfig Message-ID: <20210825011943.GM858@bill-the-cat> References: <20210825004104.6648-1-trini@konsulko.com> <20210825004104.6648-4-trini@konsulko.com> <6b80baf0-8eaa-6845-19c6-1ea660369c4d@boundarydevices.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6y91TzBqz7AtkeNG" Content-Disposition: inline In-Reply-To: <6b80baf0-8eaa-6845-19c6-1ea660369c4d@boundarydevices.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --6y91TzBqz7AtkeNG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 24, 2021 at 06:05:10PM -0700, Troy Kisky wrote: > On 8/24/2021 5:41 PM, Tom Rini wrote: > > Move the CONFIG_DDR_MB symbol to Kconfig. A later clean-up would be to > > make dynamic memory size detection work based on how this is done on > > other i.MX6 platforms. > >=20 > > Cc: Troy Kisky > > Signed-off-by: Tom Rini > > --- > > For example, mx6cuboxi does dynamic memory size detection and that code > > could be adapted for this platform and perhaps moved to a more generic > > imx6 location. > > --- > > board/boundary/nitrogen6x/Kconfig | 3 +++ > > configs/marsboard_defconfig | 1 - > > configs/mx6qsabrelite_defconfig | 3 ++- > > configs/nitrogen6dl2g_defconfig | 2 +- > > configs/nitrogen6dl_defconfig | 2 +- > > configs/nitrogen6q2g_defconfig | 2 +- > > configs/nitrogen6q_defconfig | 2 +- > > configs/nitrogen6s1g_defconfig | 2 +- > > configs/nitrogen6s_defconfig | 2 +- > > configs/riotboard_defconfig | 1 - > > 10 files changed, 11 insertions(+), 9 deletions(-) > >=20 > > diff --git a/board/boundary/nitrogen6x/Kconfig b/board/boundary/nitroge= n6x/Kconfig > > index f4db56d49601..9c176c071e72 100644 > > --- a/board/boundary/nitrogen6x/Kconfig > > +++ b/board/boundary/nitrogen6x/Kconfig > > @@ -9,4 +9,7 @@ config SYS_VENDOR > > config SYS_CONFIG_NAME > > default "nitrogen6x" > > =20 > > +config DDR_MB > > + int "Memory size in MB" > > + > > endif >=20 >=20 >=20 > > diff --git a/configs/marsboard_defconfig b/configs/marsboard_defconfig > > index bcb83b5d73de..8fcb16c108d1 100644 > > --- a/configs/marsboard_defconfig > > +++ b/configs/marsboard_defconfig > > @@ -11,7 +11,6 @@ CONFIG_TARGET_EMBESTMX6BOARDS=3Dy > > CONFIG_DM_GPIO=3Dy > > CONFIG_DEFAULT_DEVICE_TREE=3D"imx6q-marsboard" > > CONFIG_DISTRO_DEFAULTS=3Dy > > -CONFIG_SYS_EXTRA_OPTIONS=3D"DDR_MB=3D1024" > > CONFIG_BOOTCOMMAND=3D"run finduuid; run distro_bootcmd" > > # CONFIG_CONSOLE_MUX is not set > > CONFIG_SYS_CONSOLE_IS_IN_ENV=3Dy >=20 > > +++ b/configs/riotboard_defconfig > > @@ -18,7 +18,6 @@ CONFIG_SPL_SERIAL_SUPPORT=3Dy > > CONFIG_SPL=3Dy > > CONFIG_SPL_LIBDISK_SUPPORT=3Dy > > CONFIG_DISTRO_DEFAULTS=3Dy > > -CONFIG_SYS_EXTRA_OPTIONS=3D"DDR_MB=3D1024" > > CONFIG_BOOTCOMMAND=3D"run finduuid; run distro_bootcmd" > > # CONFIG_CONSOLE_MUX is not set > > CONFIG_SYS_CONSOLE_IS_IN_ENV=3Dy > >=20 >=20 >=20 > I guess marsboard_defconfig/riotboard_defconfig was a copy/paste issue, a= nd never needed DDR_MB=3D1024 ? Correct. > For boundary boards > Acked-by: Troy Kisky Thanks! --=20 Tom --6y91TzBqz7AtkeNG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmElmqwACgkQFHw5/5Y0 tyxIvQv6A6xOjN26DLMmHPuN7EIHJR/K3LNiJ65+EroN8W7tEtTvuH6bawvY+O2u UKFbklvDo/JmLy+1AIVPICs6B8iumugXQGNn1ucOK/J3+mzyBFvMIC1U1pyuOZ18 NM7h4ADiXUhNuB2Oo0Rdz3iedA/AfUKGGWCrRUBjMcf1fUpnMKe8XFWdwVqHU545 nKKdwC5/EQ7fICmO64y+vo+TOgkm/k1kWg8C8I4xXsuVmM43xm5VUikyily8d3MY eeNGrflCuZa0HUC9U8BtzqAbcyqVEgQSvC1UCrpmjUhNRfT+mkMae9vh5/O73J38 JpOPu8tUvQYViL+q2NqvOYO0sz9Fl+gfd2uKOwfAk8215UJLtflfCeHAnRj5bfca ZF/qBCkpmG9PlxYYnF/rAZRRfPF/eaelmRkQj441TP4xKMiL4sXi+Zfv44TIa/n1 YGD+/1B39d77s6C3l2V1D/2Z6rV8yFTgSm7LN8mrulWda8gHC2+ooOWqVJBprUCc 5qhVDec+ =yaWI -----END PGP SIGNATURE----- --6y91TzBqz7AtkeNG--