Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mIvrb-0005Ol-MV for mharc-grub-devel@gnu.org; Wed, 25 Aug 2021 12:34:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40902) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIvrZ-0005OZ-U7 for grub-devel@gnu.org; Wed, 25 Aug 2021 12:34:54 -0400 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]:35340) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mIvrU-0000sl-S8 for grub-devel@gnu.org; Wed, 25 Aug 2021 12:34:53 -0400 Received: by mail-pg1-x52f.google.com with SMTP id e7so284481pgk.2 for ; Wed, 25 Aug 2021 09:34:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+nWbVnq6PcuQnMe9wqzeLiNQkhM1zQLO2G8NStmWU8I=; b=MHXk0NXF++y0ApTJbzICHjrJXs8LBJGgwwTECcW/YDd1hSKaEf/s040GC9OyplAEYH rrPDyiBfkhTIv7Kws0WJWQpZeZqXHHZiq8d7+Va/MBY3fiX8O2ufd79GMweskqti+qrL +o3r5RbfBjdWsbdihCsEbf9q9JX1V/2W3B7ttvcv7EamosWm8anKofNKtzkVKQ9LkggE YqbDbpGJ3LGTMtn4zTMkUXertqhI4XRo1h3fDExUndO2F0ZPqsoxcCWtUYN4Zn7okLyR ynuJyCCdYgZhD/q/MSzqW123p1CrCrTUJy6lvYPnwbqogHfryLPxYoqgztr5REIL9L/I vK5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+nWbVnq6PcuQnMe9wqzeLiNQkhM1zQLO2G8NStmWU8I=; b=r5OooYwi5hV+2g8t7KSDtrNoJKelk+Qo7oD+x33nxXjzYrBhkOWgv2tO5TVcKMVHw1 vxZs6XMMCgi2iQrNb12PjjAqlxQxnLwuxxUPZE6+U36/nWMXiyo5AzkgT8pIuinlQkOc vnoq8hrvfJ8XEGtf0DH4/Xxpu1bTuu/gYl72GzS02QlAwGRUcJLEaXdq66TnXhHN5M8g zlOLBgpqwxWzeL+UYzUxlOWBZee5g2Cutl93mfWGUpeYabc+rFsPsNRfEZ3klpOOLLx2 oAiW0LcdmMQX6XQXny5kt407PmngkEpjrrUEfaJaOKsymknXSI8qaQ/2fbslm9mWbOm5 slUA== X-Gm-Message-State: AOAM531viiKKG6MjYSt6ks8YtvHOl0VFcNBtLZ1i8rW4HvVR8Mccsf4D HBV4B8wFPJPh6acRdI1jxjmNjg== X-Google-Smtp-Source: ABdhPJxqpvEtI704YzYshtzB9HV8EtxUpAmmx2h6LHSRNMEt5TVddXn3uH/DqEdj7mpRLHYR53HVHQ== X-Received: by 2002:a63:5024:: with SMTP id e36mr42907774pgb.66.1629909286355; Wed, 25 Aug 2021 09:34:46 -0700 (PDT) Received: from google.com ([2620:15c:2ce:200:2cb4:c19d:325d:c05c]) by smtp.gmail.com with ESMTPSA id x189sm343776pfx.99.2021.08.25.09.34.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Aug 2021 09:34:45 -0700 (PDT) Date: Wed, 25 Aug 2021 09:34:41 -0700 From: Fangrui Song To: Daniel Kiper Cc: grub-devel@gnu.org, Alex Burmashev , Vladimir 'phcoder' Serbinenko Subject: Re: [PATCH 2/2] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1 Message-ID: <20210825163441.vfzgujarnnq2rs4l@google.com> References: <20210824061838.3569412-1-maskray@google.com> <20210824061838.3569412-3-maskray@google.com> <20210825132408.owyrc2gm72zgg5s6@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="76bczto7elvrjgxk" Content-Disposition: inline In-Reply-To: <20210825132408.owyrc2gm72zgg5s6@tomti.i.net-space.pl> Received-SPF: pass client-ip=2607:f8b0:4864:20::52f; envelope-from=maskray@google.com; helo=mail-pg1-x52f.google.com X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Aug 2021 16:34:54 -0000 --76bczto7elvrjgxk Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On 2021-08-25, Daniel Kiper wrote: >On Mon, Aug 23, 2021 at 11:18:38PM -0700, Fangrui Song wrote: >> Clang does not support -falign-jumps and only recently gained support >> for -falign-loops. Test all the alignment options to avoid passing >> unrecognized options to Clang: >> >> clang-14: error: optimization flag '-falign-jumps=1' is not supported [-Werror,-Wignored-optimization-argument] >> >> When compiled with older Clang, the alignment options are not added, so >> just avoid the complexity for each option. >> >> Signed-off-by: Fangrui Song >> --- >> configure.ac | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/configure.ac b/configure.ac >> index 9a12151bd..8625e6776 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -798,8 +798,9 @@ fi >> >> # Force no alignment to save space on i386. >> if test "x$target_cpu" = xi386; then >> - AC_CACHE_CHECK([whether -falign-loops works], [grub_cv_cc_falign_loop], [ >> - CFLAGS="$TARGET_CFLAGS -falign-loops=1 -Werror" >> + AC_CACHE_CHECK([whether -falign-jumps=1 -falign-loops=1 -falign-functions=1 works], >> + [grub_cv_cc_falign_loop], [ >> + CFLAGS="$TARGET_CFLAGS -falign-jumps=1 -falign-loops=1 -falign-functions=1 -Werror" > >I would prefer if you add a separate check for every -falign-* option. > >Daniel The attached patch checks both -falign-jumps=1 and -falign-loops=1 --76bczto7elvrjgxk Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-configure-Check-falign-jumps-1-beside-falign-loops-1.patch" From fbef8198d26babeb402b480d333a4a5212069afb Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Wed, 25 Aug 2021 09:28:46 -0700 Subject: [PATCH] configure: Check -falign-jumps=1 beside -falign-loops=1 Clang does not support -falign-jumps and only recently gained support for -falign-loops. -falign-jumps=1 should be tested beside -fliang-loops=1 to avoid passing unrecognized options to Clang: clang-14: error: optimization flag '-falign-jumps=1' is not supported [-Werror,-Wignored-optimization-argument] -falign-functions=1 is supported by GCC 5.1.0/Clang 3.8.0, so just add the option unconditionally. Signed-off-by: Fangrui Song --- configure.ac | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 9a12151bd..91a6ef128 100644 --- a/configure.ac +++ b/configure.ac @@ -798,6 +798,8 @@ fi # Force no alignment to save space on i386. if test "x$target_cpu" = xi386; then + TARGET_CFLAGS="$TARGET_CFLAGS -falign-functions=1" + AC_CACHE_CHECK([whether -falign-loops works], [grub_cv_cc_falign_loop], [ CFLAGS="$TARGET_CFLAGS -falign-loops=1 -Werror" AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])], @@ -806,7 +808,18 @@ if test "x$target_cpu" = xi386; then ]) if test "x$grub_cv_cc_falign_loop" = xyes; then - TARGET_CFLAGS="$TARGET_CFLAGS -falign-jumps=1 -falign-loops=1 -falign-functions=1" + TARGET_CFLAGS="$TARGET_CFLAGS -falign-loops=1" + fi + + AC_CACHE_CHECK([whether -falign-jumps works], [grub_cv_cc_falign_jumps], [ + CFLAGS="$TARGET_CFLAGS -falign-jumps=1 -Werror" + AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])], + [grub_cv_cc_falign_jumps=yes], + [grub_cv_cc_falign_jumps=no]) + ]) + + if test "x$grub_cv_cc_falign_jumps" = xyes; then + TARGET_CFLAGS="$TARGET_CFLAGS -falign-jumps=1" fi fi -- 2.33.0.rc2.250.ged5fa647cd-goog --76bczto7elvrjgxk--