Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mJHqK-00008U-4A for mharc-grub-devel@gnu.org; Thu, 26 Aug 2021 12:03:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3LLsnYQcKClE5tB3AtHz77z4x.v75zADu-wxEx4z6D.7Az@flex--maskray.bounces.google.com>) id 1mJHqG-0008T1-7E for grub-devel@gnu.org; Thu, 26 Aug 2021 12:03:00 -0400 Received: from mail-yb1-xb49.google.com ([2607:f8b0:4864:20::b49]:55860) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3LLsnYQcKClE5tB3AtHz77z4x.v75zADu-wxEx4z6D.7Az@flex--maskray.bounces.google.com>) id 1mJHqB-00007T-Bx for grub-devel@gnu.org; Thu, 26 Aug 2021 12:02:59 -0400 Received: by mail-yb1-xb49.google.com with SMTP id q80-20020a25d953000000b0059a45a5f834so3470496ybg.22 for ; Thu, 26 Aug 2021 09:02:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=6UW/twoFGpPQjPtYQJu/mB4MjJ9eWkBqmY1DBx6cyZI=; b=Biq3bYxVXAXollFQXTAIj2382GPx9+8PSdwqusIijiScY7SND/mi/4rs5NLdE2uIID uTCKRJdXjcP3YxRd21lPkv6exkQA+2v81rZSAAlyImlWDYUiD3BhP5SXxPDnTNBjwkaz X5WKXsWkloMWQrRfz+NJ9q8/BfIE0YkqMi88/z22P4TC8G2DccCAGboDK/GPA8iMgyX4 6wm6S6TmgtcmD93lkqXsaLHO7gy28mRAkK7Sc/WGlWfz0NPpAw/XlQK4aOvFfkXZq892 91IsDJfbekmE5jTEwHhFaAW6+sF8RnmzbXXIjo4VCbfMpf0FBLOnOwwecaz8WR4KCAsH cmbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=6UW/twoFGpPQjPtYQJu/mB4MjJ9eWkBqmY1DBx6cyZI=; b=ah0c+vU1U9VG7ZwvasUXg+2hDaEO9LCFa7bn1Rn25WOgf4mbdsqRKA+lZq10CX1ZbQ FS3Q5TS2Yt5ibWjZa4pekVbIlAOEzdLZsKFu56XFrgydBBPUEFTU6ma48+n9QCSnDPk5 khQVU6tUYHk/NeceUQUSd/HIn+4ppXwolI5z5mftcziFjJJR9JscZzCZfR+kG3O/z3lC icPQwNWulTiw5wGVDO2WgtXLiytnTep+aJo0yC+ZGDpe+RJE6307ntVbWuWxB/ry1UTL lo5hnYdar+eh9ApmOa9qcnfsgohDqRBPCyMn2iTN9nnvp7ti8DmTHGyW+hwFmCkEqJ/m ePeg== X-Gm-Message-State: AOAM530gdDKYs7QJk4eNt8R8MEiDOpZ8hcGgHqnxpghUpGPiCIs50wEf CitPdFJMpY38HhQpQjkjsYgI8DKNpIUBeQqZ4a+NqdgndiIr7N15YhPwwiOa7MA47+/lAyYwLKv nU5nY3svqZGPj4zElfhQVTQJ7xt60OaaU9XIryBSza0EJ0FGXuCEw8jRf8Kk= X-Google-Smtp-Source: ABdhPJx1ib+4BBX4RDtwOr+r1lZtN6bB/kMi77LXar9IHSMbONRHrQwcgd0w9seyLwnknVk2kZBzPBLpzNZP X-Received: from maskray1.svl.corp.google.com ([2620:15c:2ce:200:15b4:cfcb:3ed7:d7d2]) (user=maskray job=sendgmr) by 2002:a25:ba05:: with SMTP id t5mr5506826ybg.120.1629993772729; Thu, 26 Aug 2021 09:02:52 -0700 (PDT) Date: Thu, 26 Aug 2021 09:02:32 -0700 In-Reply-To: <20210826160232.1189046-1-maskray@google.com> Message-Id: <20210826160232.1189046-3-maskray@google.com> Mime-Version: 1.0 References: <20210826160232.1189046-1-maskray@google.com> Subject: [PATCH v3 2/2] configure: Check -falign-jumps=1 beside -falign-loops=1 From: Fangrui Song To: grub-devel@gnu.org, Daniel Kiper , Alex Burmashev , "Vladimir 'phcoder' Serbinenko" Cc: Fangrui Song , Paul Menzel Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::b49; envelope-from=3LLsnYQcKClE5tB3AtHz77z4x.v75zADu-wxEx4z6D.7Az@flex--maskray.bounces.google.com; helo=mail-yb1-xb49.google.com X-Spam_score_int: -95 X-Spam_score: -9.6 X-Spam_bar: --------- X-Spam_report: (-9.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2021 16:03:01 -0000 Clang does not support -falign-jumps and only recently gained support for -falign-loops. -falign-jumps=1 should be tested beside -fliang-loops=1 to avoid passing unrecognized options to Clang: clang-14: error: optimization flag '-falign-jumps=1' is not supported [-Werror,-Wignored-optimization-argument] -falign-functions=1 is supported by GCC 5.1.0/Clang 3.8.0, so just add the option unconditionally. Acked-by: Paul Menzel Reviewed-by: Daniel Kiper Signed-off-by: Fangrui Song --- configure.ac | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 9a12151bd..eeb5d2211 100644 --- a/configure.ac +++ b/configure.ac @@ -798,6 +798,8 @@ fi # Force no alignment to save space on i386. if test "x$target_cpu" = xi386; then + TARGET_CFLAGS="$TARGET_CFLAGS -falign-functions=1" + AC_CACHE_CHECK([whether -falign-loops works], [grub_cv_cc_falign_loop], [ CFLAGS="$TARGET_CFLAGS -falign-loops=1 -Werror" AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])], @@ -806,7 +808,18 @@ if test "x$target_cpu" = xi386; then ]) if test "x$grub_cv_cc_falign_loop" = xyes; then - TARGET_CFLAGS="$TARGET_CFLAGS -falign-jumps=1 -falign-loops=1 -falign-functions=1" + TARGET_CFLAGS="$TARGET_CFLAGS -falign-loops=1" + fi + + AC_CACHE_CHECK([whether -falign-jumps works], [grub_cv_cc_falign_jumps], [ + CFLAGS="$TARGET_CFLAGS -falign-jumps=1 -Werror" + AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])], + [grub_cv_cc_falign_jumps=yes], + [grub_cv_cc_falign_jumps=no]) + ]) + + if test "x$grub_cv_cc_falign_jumps" = xyes; then + TARGET_CFLAGS="$TARGET_CFLAGS -falign-jumps=1" fi fi -- 2.33.0.rc2.250.ged5fa647cd-goog