Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C247C432BE for ; Mon, 30 Aug 2021 21:57:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7BE560F42 for ; Mon, 30 Aug 2021 21:57:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238554AbhH3V6n (ORCPT ); Mon, 30 Aug 2021 17:58:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233612AbhH3V6m (ORCPT ); Mon, 30 Aug 2021 17:58:42 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EC2DC061575 for ; Mon, 30 Aug 2021 14:57:48 -0700 (PDT) Received: from localhost ([::1]:33744 helo=xic) by orbyte.nwl.cc with esmtp (Exim 4.94.2) (envelope-from ) id 1mKpHm-0006dJ-E8; Mon, 30 Aug 2021 23:57:46 +0200 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org, =?UTF-8?q?Adam=20W=C3=B3jcik?= Subject: [iptables PATCH] extensions: libxt_mac: Fix for missing space in listing Date: Mon, 30 Aug 2021 23:58:17 +0200 Message-Id: <20210830215817.4114-1-phil@nwl.cc> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Listing the extension using 'iptables -L', there was no space between 'MAC' and the following Address. Reported-by: Adam Wójcik Fixes: 1bdb5535f561a ("libxtables: Extend MAC address printing/parsing support") Signed-off-by: Phil Sutter --- extensions/libxt_mac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extensions/libxt_mac.c b/extensions/libxt_mac.c index b90eef207c98e..55891b2be7104 100644 --- a/extensions/libxt_mac.c +++ b/extensions/libxt_mac.c @@ -42,10 +42,10 @@ mac_print(const void *ip, const struct xt_entry_match *match, int numeric) { const struct xt_mac_info *info = (void *)match->data; - printf(" MAC"); + printf(" MAC "); if (info->invert) - printf(" !"); + printf("! "); xtables_print_mac(info->srcaddr); } -- 2.32.0