Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B55DC432BE for ; Wed, 1 Sep 2021 22:31:46 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9651360FDA for ; Wed, 1 Sep 2021 22:31:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9651360FDA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9EFC68325E; Thu, 2 Sep 2021 00:31:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="cmRibmaf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B3E7C8325E; Thu, 2 Sep 2021 00:31:40 +0200 (CEST) Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5EAA08324B for ; Thu, 2 Sep 2021 00:31:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x736.google.com with SMTP id y144so1268287qkb.6 for ; Wed, 01 Sep 2021 15:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JIEH64rhV1L7ikdRtMju7zkSPbUWFopOxUWdRjKN6rg=; b=cmRibmafbvFUM1pnd7lGtgQ5Vf60kfiL+iraUOt4GGtpvrcYmmUY9Sqp/43quJlzUT yPNXFJRpneWrLLUGX7Fl/nrCCj19d7YOpR5blOCwv+kyYcDS0SlMT8IlJzGEWbXJqbdf 6QIJ92SnYxtUjfhfGbRH3cnAriK3S5yTZtPjE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JIEH64rhV1L7ikdRtMju7zkSPbUWFopOxUWdRjKN6rg=; b=VIIwL67UCXh5K/MxvnpHGswV1SVYQRohorxZ4FwQCMeCdGpL9kCC2iEqXdBxI6O1X2 PItfp9uCxZEnZLikDzmmmAu6wVmQugPfTal/YdSnS3mM8H9+Ep81s1Xa4hLyUZdA1pE0 cqOHGqFZCjV20xVsMpajYHhmK7O2V31MeHDfqHL/Ims/xyxB+274BlhKpbMvNXNaY604 11NM7zC1XuSU65I2wKVQGo+FlDQV9ePT/CvCL5pQfrv8ohYfEp5flho9rQRfRtZo/hnz 61lBj/xaNvfBRS6GE9H+fDddTLTmRt6/NP85Vovfo9CPRc3vb9DYC7cK5yLB4tE+HLHK H9EQ== X-Gm-Message-State: AOAM533xFxFudLWljj8/O6wRXoePLUa/S2Q2Ts9zMCfpxLfey1XIY/vO eg//vduuVHpWaGdB40ltIeSIkQ== X-Google-Smtp-Source: ABdhPJyNLYaZXRq4/LE/4UtD9Q7Z4H/qLaDHegDH8Xr+f1xlJ5WN53c4FvKJQTsa4l7tthLNZNtKCw== X-Received: by 2002:a05:620a:4151:: with SMTP id k17mr210563qko.51.1630535495051; Wed, 01 Sep 2021 15:31:35 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-9d52-d816-c53d-6548.res6.spectrum.com. [2603:6081:7b01:cbda:9d52:d816:c53d:6548]) by smtp.gmail.com with ESMTPSA id x8sm704268qts.69.2021.09.01.15.31.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Sep 2021 15:31:34 -0700 (PDT) Date: Wed, 1 Sep 2021 18:31:32 -0400 From: Tom Rini To: Donald Chan Cc: u-boot@lists.denx.de, mr.nuke.me@gmail.com, sjg@chromium.org Subject: Re: [PATCH] lib: rsa: Extract public key from private key if keyfile argument is used Message-ID: <20210901223132.GA4712@bill-the-cat> References: <20210728202030.GZ9379@bill-the-cat> <20210729003441.17428-1-hoiho@lab126.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="r5Pyd7+fXNt84Ff3" Content-Disposition: inline In-Reply-To: <20210729003441.17428-1-hoiho@lab126.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 28, 2021 at 05:34:41PM -0700, Donald Chan wrote: > If the 'keyfile' (-G) argument is used, there is little value to require > 'keydir' (-k) argument since the public key can also be extracted from the > private key itself. >=20 > Signed-off-by: Donald Chan This breaks the "vboot" tests run under sandbox, please investigate and fix, thanks! --=20 Tom --r5Pyd7+fXNt84Ff3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEv/z0ACgkQFHw5/5Y0 tyxr0Av+MynmhFmLFHqrLF83UTAVxuh1MqM72FeG/gv1+d9pkwhpxE/pa5LOdWCG fE2inVJP/xsXzuagyoSTypJ2zlc+5LlLJN2XnmQEOKbSZSKUk7PusR9Gf7ceyweN s/BVIMkpZ+bVKMi4r1NJrKpfJFwzk6e4tN7aE741WOsBgX1yGjZQNmfFPlo12KW4 aE7sedMDz2FD9MpT68CMRYxpKF067Jg5mobf+RpvUlmlamxOwkj3j2YP2M7dbkpp Wp3pQcUktlg+MHQ+51NjhNfOeudP5ZRBAGPD3aF3H4EJHgsXlLxm2AdZVACUtTxG RWIaRVFczYYAf5mhTr2nZ5R9AhchMejMbyhBwR3MmYw7WRwwck4LBagbYJd2MX2G svrEPVdN1yqcXfLxr1774XqrpeFGRCaTPfZfh5KUDlhCTPaGiidn/kafc9t9p9RO XPV2jAG6pum3MIfqfuCq2kCe/NtObkqlv5ct2FWIEFwjwNOU1Yu87z8mWDgaLrJP iWZ2YHU8 =u/v6 -----END PGP SIGNATURE----- --r5Pyd7+fXNt84Ff3--