Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8E34C432BE for ; Thu, 2 Sep 2021 14:39:05 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3DE7C60BD3 for ; Thu, 2 Sep 2021 14:39:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3DE7C60BD3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 731D583301; Thu, 2 Sep 2021 16:39:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="F+nbw3ce"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 92535832F4; Thu, 2 Sep 2021 16:39:00 +0200 (CEST) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EF35083474 for ; Thu, 2 Sep 2021 16:38:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x731.google.com with SMTP id c10so2260386qko.11 for ; Thu, 02 Sep 2021 07:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=H602zJ9bKCbJ68PncuXxEobge8U//ppdUx1rqbyCltQ=; b=F+nbw3cek4al32L+pronJZMdS1/xJNRJZkvAriY+mjQ164GmZu1VOCgxvoumdAi5z4 R5bbdLX2jkze/r7pJKkf/nhFCKMT06fRisrUMPviiO4lWcqEo2NUaXlzU3z8EizkbgvB rF/0ZxlNRF1E6psrD5tKdbHT1OSxq8C8cgZ7c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=H602zJ9bKCbJ68PncuXxEobge8U//ppdUx1rqbyCltQ=; b=qrhInoOemV74S06MrjvVJLOpzEvfPDgw9L50kHlTaaD9jcfHU++vYnH1g5nz7a+OuR zSUo91S0opHD3V2V+KI0qNY4YK0/86znYz2dOdOAeKlPLXRg80FbQEv4JE64IF1mdKJp tr+ca539K8VGOgQZ+90LWmhhcoSeBMjk0Yfi1a2RPV55iBu4RK5A0BJOjWxuORvzhPAV KxeHWvVwLz8FhhN2/KDJ0aZpfPQkz18snvmor7pl2GK4zNAk/IRFSY8P648yk+GDoKWU pHdixuDVmutMWXvy+jOKaFEseVIfIWUXj0yFjoj06mnWl+qjiurcWcYRV0kD3ZppgORz KkTg== X-Gm-Message-State: AOAM533gWfLQfhBZaks40daMopqw8sXQNiUd35lcmFvD/2QZ/GrFoboo /o/8P7m/HiCAhCPXdeR4zQ0PDQ== X-Google-Smtp-Source: ABdhPJxAEABAPE/XMHt/3gNbIv+Y0wOfqWttbToIqEZjT2bzUBH4YIce4rLpjCAIJvHlW4AHxdPDRA== X-Received: by 2002:a37:a1cc:: with SMTP id k195mr3545941qke.230.1630593534597; Thu, 02 Sep 2021 07:38:54 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-95b1-4c42-35f4-d991.res6.spectrum.com. [2603:6081:7b01:cbda:95b1:4c42:35f4:d991]) by smtp.gmail.com with ESMTPSA id s204sm1514298qke.109.2021.09.02.07.38.53 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Sep 2021 07:38:53 -0700 (PDT) Date: Thu, 2 Sep 2021 10:38:51 -0400 From: Tom Rini To: Peter Robinson Cc: Alexandru Gagniuc , u-boot@lists.denx.de, panfilov.artyom@gmail.com Subject: Re: [PATCH] lib/rsa: Remove support for OpenSSL < 1.1.0 and libressl < 2.7.0 Message-ID: <20210902143851.GK858@bill-the-cat> References: <20210729183121.3798261-1-mr.nuke.me@gmail.com> <20210902132828.GW858@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="I4edPl/KX7SuHiPy" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --I4edPl/KX7SuHiPy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 02, 2021 at 03:36:43PM +0100, Peter Robinson wrote: > On Thu, Sep 2, 2021 at 2:28 PM Tom Rini wrote: > > > > On Thu, Jul 29, 2021 at 01:31:21PM -0500, Alexandru Gagniuc wrote: > > > > > Older OpenSSL and libressl versions have a slightly different API. > > > This require #ifdefs to support. However, we still can't support it > > > because the ECDSA path does not compile with these older versions. > > > These #ifdefs are truly a vestigial appendage. > > > > > > Alternatively, the ECDSA path could be updated for older libraries, > > > but this requires significant extra code, and #ifdefs. Those libraries > > > are over three years old, and there concerns whether it makes sense to > > > build modern software for real world use against such old libraries. > > > > > > Thusly, remove #ifdefs and code for old OpenSSL and LibreSSL support. > > > > > > Signed-off-by: Alexandru Gagniuc > > > > Applied to u-boot/next, thanks! >=20 > According to recent CVE announcements 1.1.0 is out of support [1], > does it make sense to just support 1.1.1x and later? >=20 > [1] https://www.openssl.org/news/secadv/20210824.txt Good question. Are there API changes between 1.1.0 and 1.1.1x ? --=20 Tom --I4edPl/KX7SuHiPy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEw4fUACgkQFHw5/5Y0 tywtKAwAjy5jfJYWvbOkTbLzNL6H1pleO9i92izvbKz7VFPqsHTt7nCOMl2Ao414 ZyxNJqgv7ns4G2xh2Oia7Qhbtf38ZIIoXel+hNOBk9pBWDZYfk/XlGM4+XtNnBiC fcfiP+idr64prH/bpNocpQ0F5HleVYMbpjhe7ifioTvduje8bBU39ZWlWR+Xruc8 8BJQ5x6U97Ak8dWAiwk3YjlzP6rryMSoAbQQYtaeFwP+SoVBDuhkQ8IaBD2ZgmHM otHFALR7d62z0RiEuKrrMjrNOq8zH+NbJQUtIY6IhdjzlnlsG+WbZLt1QKYNdVv1 nd/byLk3thlmivtbg04SDcHXJpBgTGRDeuWfLv/M66gtWBlMYkUPoPnX3DV51MDs rZQltTjtueYxyNySiXGhTKoUo/I0gOEvo2tjapMA7x2+HRc13nJOUXxY8raA7lu+ Vh7jPJ1aWgejKGPmDIWd8M2riVEju8Wy4N3ldsT7MNiWgzTD63RvuMO3+yGNbrS2 FlpFGXXJ =lDkZ -----END PGP SIGNATURE----- --I4edPl/KX7SuHiPy--