Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D83DC433F5 for ; Thu, 2 Sep 2021 17:59:18 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39D65610A2 for ; Thu, 2 Sep 2021 17:59:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 39D65610A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 98EA983474; Thu, 2 Sep 2021 19:59:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="SMVecV2H"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BF0428348D; Thu, 2 Sep 2021 19:59:12 +0200 (CEST) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 11917832BC for ; Thu, 2 Sep 2021 19:59:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id r21so2312895qtw.11 for ; Thu, 02 Sep 2021 10:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=h7VtmRbIn81jWO+V1O+5NrPC5BcDQplTPwK8iJ21sJQ=; b=SMVecV2HsXTdZETnfDfR3AU2Jiqad0yUvxNiO15l27B1p8f1TVdgPSqNwa6AIvpV3g We5vnV2A4niVBTcuFJcS932y6sxE7eFTtZ3mL+eSCqMtJBKjegG5qu+Oe+1ZDrjDC5m9 /hDGIe2N1It3EtWCAV2mowuqopsQERCJKyb2c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=h7VtmRbIn81jWO+V1O+5NrPC5BcDQplTPwK8iJ21sJQ=; b=YrdbYiSbfgHaG9UFua3kGV3PnaztB6i2K6qPA+UvmWGn7MypZ+DP9vWqqFF/ZVz5Pk bNgmoZzNtriz/AgkF1WYJxq0mMjIf2uTn3WidC5xV/2eGkMSzPeYg0fsYvvHQPupZCJ8 PhK/S+uG3f+HeBtbN64lw7XSJQvfrKo0k5zuB5vaiM/jlq6BFLjT5Avs13izry7LAH6c dR57tDdWaEUUWqsUiVSEoiQg6ebb9xH1SVUwTVKWvtqCXQ0Yk3LoR3apWa69G1dKI8Dr wjbRGUFIlrGeJp+SCDoGfo712IWrKuhT+aUFayCjmn/FzxvVvdVsyrqGSQtahlgxH+kQ 7ozw== X-Gm-Message-State: AOAM533A7VWP/dRLMqvgDvWyN3TDhjgnpVDQcn9EDpk2Ga5wzbeZZlMw qAAoy4CVyOZDLDoE8bKeaVMoJA== X-Google-Smtp-Source: ABdhPJzG1SQpMHPjuqZaCUIgSVQf1ZFyk+3cFC4dRb4zxSZCkw8BBMb0BDDqkMyrBM96A82UgidaiA== X-Received: by 2002:ac8:6697:: with SMTP id d23mr4282620qtp.34.1630605547682; Thu, 02 Sep 2021 10:59:07 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-95b1-4c42-35f4-d991.res6.spectrum.com. [2603:6081:7b01:cbda:95b1:4c42:35f4:d991]) by smtp.gmail.com with ESMTPSA id b13sm1441186qtb.13.2021.09.02.10.59.06 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Sep 2021 10:59:06 -0700 (PDT) Date: Thu, 2 Sep 2021 13:59:04 -0400 From: Tom Rini To: "Alex G." Cc: Peter Robinson , u-boot@lists.denx.de, panfilov.artyom@gmail.com Subject: Re: [PATCH] lib/rsa: Remove support for OpenSSL < 1.1.0 and libressl < 2.7.0 Message-ID: <20210902175904.GM858@bill-the-cat> References: <20210729183121.3798261-1-mr.nuke.me@gmail.com> <20210902132828.GW858@bill-the-cat> <20210902143851.GK858@bill-the-cat> <2cf69c6b-9d87-20d4-28ed-d118e8fe5ba9@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="otknUzgNhP4oiOdy" Content-Disposition: inline In-Reply-To: <2cf69c6b-9d87-20d4-28ed-d118e8fe5ba9@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --otknUzgNhP4oiOdy Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 02, 2021 at 12:48:29PM -0500, Alex G. wrote: >=20 >=20 > On 9/2/21 12:43 PM, Peter Robinson wrote: > > On Thu, Sep 2, 2021 at 3:38 PM Tom Rini wrote: > > >=20 > > > On Thu, Sep 02, 2021 at 03:36:43PM +0100, Peter Robinson wrote: > > > > On Thu, Sep 2, 2021 at 2:28 PM Tom Rini wrote: > > > > >=20 > > > > > On Thu, Jul 29, 2021 at 01:31:21PM -0500, Alexandru Gagniuc wrote: > > > > >=20 > > > > > > Older OpenSSL and libressl versions have a slightly different A= PI. > > > > > > This require #ifdefs to support. However, we still can't suppor= t it > > > > > > because the ECDSA path does not compile with these older versio= ns. > > > > > > These #ifdefs are truly a vestigial appendage. > > > > > >=20 > > > > > > Alternatively, the ECDSA path could be updated for older librar= ies, > > > > > > but this requires significant extra code, and #ifdefs. Those li= braries > > > > > > are over three years old, and there concerns whether it makes s= ense to > > > > > > build modern software for real world use against such old libra= ries. > > > > > >=20 > > > > > > Thusly, remove #ifdefs and code for old OpenSSL and LibreSSL su= pport. > > > > > >=20 > > > > > > Signed-off-by: Alexandru Gagniuc > > > > >=20 > > > > > Applied to u-boot/next, thanks! > > > >=20 > > > > According to recent CVE announcements 1.1.0 is out of support [1], > > > > does it make sense to just support 1.1.1x and later? > > > >=20 > > > > [1] https://www.openssl.org/news/secadv/20210824.txt > > >=20 > > > Good question. Are there API changes between 1.1.0 and 1.1.1x ? > >=20 > > So outside of the new TLS 1.3 feature the release says "What=E2=80=99s = more is > > that OpenSSL 1.1.1 is API and ABI compliant with OpenSSL 1.1.0" and > > depending on how we use openssl it may even be API compatible with 3.0 > > when it comes out any time now. > >=20 > > https://www.openssl.org/blog/blog/2018/09/11/release111/ >=20 > Okay, I don't think it's worth excluding 1.1.0 then. The only way we could > do that is a compile time check against OPENSSL_VERSION. >=20 > That won't prevent someone from compiling with openssl 1.1.1, and then ju= st > replacing libcrypto.so with 1.1.0. That's what I was figuring. If there was compatibility code we could drop, it would make sense. But since there's not, I don't think we're in a position to really influence things. --=20 Tom --otknUzgNhP4oiOdy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmExEOUACgkQFHw5/5Y0 tywZCgwAqPFSpSXuA6UEoAuq2kza7XOFKCobCW1qR3UpP02h/hn/XX2CS+8iDGel 8XPZgWhfq13QVq+G/yBXd8QWJ86gIhi2JZKEIQ1kAmYaMPHhs29/YjSeV+P8dvdP PllcG1N6n+QNnNPyyqR+xRCWXzT3pzUiFff3wLrb2sJDoWlTIwWus8UYYGISp3bv G17t6Uy7yn8AR8GPiJjMh2a1iF0IagK1v1aQKr4xjgwrn+OFY23LhQmIaHBsee5Y Omuurp43W7hbxypQaLnkBa1Q7uSRZRNv4+KPwbM8gOZ4Tm5+RkY2n2YbpFRTdh3k i+ul51Zj88IhxgBSqHJfdKXP+HmV5nbynP1rAGNywgkcy4UBH5pxdsYYoiLGWbH+ sCLYODrk44YsP/BWkqKiQtscp/w06WQB4A3vUeXUxZKw+zLaSQMOsKwsVUU2e7Zy 93NVyCOIjBXY3scaVnJv/TRzk0rMAPqtDJbSlHiZNGazY0xpE9EwFo5A7RvU/7TB +B86ibNH =Slnz -----END PGP SIGNATURE----- --otknUzgNhP4oiOdy--