Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4622DC433EF for ; Thu, 2 Sep 2021 23:49:31 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4774760FA0 for ; Thu, 2 Sep 2021 23:49:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4774760FA0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 47276834C0; Fri, 3 Sep 2021 01:49:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="q6GX3YZn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4F6438348D; Fri, 3 Sep 2021 01:49:25 +0200 (CEST) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8487281761 for ; Fri, 3 Sep 2021 01:49:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82f.google.com with SMTP id t9so3178263qtp.2 for ; Thu, 02 Sep 2021 16:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Cd7qf9zJf9a9wfHtvEPYYHhb3gaUi58FZQThiBBR7pQ=; b=q6GX3YZn8bhNGW5XiMZ9jypp92CYktigR3ZUWGTChpOBJYAJfhxIxb++PShGn2Lkmz bAjNsfbh2Yi3KjmFAA0kEaGH2gHvY2zjDMGcftlZXJbPuNRV2zA1nYyUmfqTb0v7dHFr 0+CKO5SXzegGeQZk/Is5zoHAaC7oXFX9ZliyI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Cd7qf9zJf9a9wfHtvEPYYHhb3gaUi58FZQThiBBR7pQ=; b=rP37p5NVYz0I/nJlX2eR0oKW0+6IlNIzPedT4+N/csw9lWSeDHxXI1nvao70NHeHVx CER1Jr1bfT6CDa44I+oklJijsyACFLGxgIl+k1Fjafft4ZQmmvd+CvFnb/mSZEwkzadr F33X+OmiIy8yFnxH6565ykhdvsr2CCZTeF5ZJb8Pq+wfIpG9o9i0n1/JP+nbREqerCSw 5bsUSkjyihLOAkN0L2b3eXh72sNGvV5CBCa3uai6s8Ygr54tsc4O42xaIXGrynuY064U AnFfL0Fos4EAfMo3S5GFiHM0ST9ZfL0iLzyszhU5O2ZPILBgMYKvU1A2ilqpoVSZjDZZ LRVA== X-Gm-Message-State: AOAM533UWg0JwhQF3yHFiT3OKARLaQMOtoStTqaE6vRA11ecU4llqdmD 5vbezVyOOn16J7MdgbFY2BJQrw== X-Google-Smtp-Source: ABdhPJwTVytNwwTTBQqMEC88GVpq+ptWFvT8cZ5zjHIFma7kkFcMg8KRy+n+hOgL65Tc8gtzgAM2uQ== X-Received: by 2002:a05:622a:181d:: with SMTP id t29mr1001436qtc.309.1630626560097; Thu, 02 Sep 2021 16:49:20 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-95b1-4c42-35f4-d991.res6.spectrum.com. [2603:6081:7b01:cbda:95b1:4c42:35f4:d991]) by smtp.gmail.com with ESMTPSA id w185sm2723380qkd.30.2021.09.02.16.49.18 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Sep 2021 16:49:19 -0700 (PDT) Date: Thu, 2 Sep 2021 19:49:17 -0400 From: Tom Rini To: Andre Przywara Cc: Peter Hoyes , u-boot@lists.denx.de, patrick.delaunay@foss.st.com, sjg@chromium.org, diego.sueiro@arm.com Subject: Re: [PATCH v2 5/6] arm: Use armv8_switch_to_el1 env to switch to EL1 Message-ID: <20210902234917.GG858@bill-the-cat> References: <20210819155314.1787973-1-peter.hoyes@arm.com> <20210819155314.1787973-6-peter.hoyes@arm.com> <20210902224205.GX858@bill-the-cat> <20210903000628.4419ad1f@slackpad.fritz.box> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/ZDYMhaXUMV+Eds7" Content-Disposition: inline In-Reply-To: <20210903000628.4419ad1f@slackpad.fritz.box> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --/ZDYMhaXUMV+Eds7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 03, 2021 at 12:07:20AM +0100, Andre Przywara wrote: > On Thu, 2 Sep 2021 18:42:05 -0400 > Tom Rini wrote: >=20 > Hi Tom, >=20 > > On Thu, Aug 19, 2021 at 04:53:13PM +0100, Peter Hoyes wrote: > >=20 > > > From: Peter Hoyes > > >=20 > > > Use the environment variable armv8_switch_to_el1 to determine whether > > > to switch to EL1 at runtime. This is an alternative to the > > > CONFIG_ARMV8_SWITCH_TO_EL1 compile-time option. > > >=20 > > > The environment variable will be ineffective if the ARMV8_MULTIENTRY > > > config is used. > > >=20 > > > This is required by the Armv8r64 architecture, which must be able to > > > boot at S-EL1 for Linux but may need to boot at other ELs for other > > > systems. > > >=20 > > > Signed-off-by: Peter Hoyes =20 > >=20 > > Applied to u-boot/next, thanks! >=20 > Sorry for keeping silent on this, we had some internal discussions > here, and we don't think this is the right approach. Well, oops on my part too. > This whole CONFIG_ARMV8_SWITCH_TO_EL1 solution is actually already > questionable, as it goes somewhat against the PSCI spec, which requires > secondaries to enter in the highest non-secure exception level (Section > 6.1.3: "... As described in Figure 6, the return Exception level for a > CPU_ON call is the highest Non secure Exception level implemented.") >=20 > In any case the primary core must enter an the same exception level as > the secondaries, or all hell breaks loose. The current code violates > this bluntly when the dynamic method is used (as the spin table code > doesn't know about this variable). >=20 > So can you please revert this patch? We are looking into a different Should I undo just this, or the whole vexpress_aemv8r series? --=20 Tom --/ZDYMhaXUMV+Eds7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmExYvYACgkQFHw5/5Y0 tyz8Rwv/QVGHa5d5b06+vXA8cl9pZkXbY2DT4rdr0IoGw2orIu8Ky5S9s3YcWwLR wErr4JA0f2zwmpG7lUDBAy+hmAd8Cwiv1kNbxidAZCJPfv4cOChonzgE25QwV/UZ zDFEab9J7pCUZ/ZdKU8Fi793uh/EvKNNbC36wSAHY8DgdDeywTG35tXqr57hUI4N IdFKUm1YI5NUtVRwNfYjPTlRpBwGYYcFlkK31WBUGQtNOxecD6A0i5vohICnqHvy p7SSjLIwfLiqML1gQHFF+79Q8laAEIEMgnJuzVQKM7ODmiUwV2WpAR+w7b88ygUb zKbT7NBHJ6mZhCeHgylONb+NNVB3j9l6pngA6eAl4C+3sfV4mjjncMGONdrfQCbr S51PTxNGPUYaC7UvjqpJMamTve3QRMAso8kCp/TO5DyzenR1vqpkHblRJzkejZ7P VOr7+g7zolQD+krmk94Uda6Se0Znpw9wNQaMCMOZIDd+MJGmp89JapQ5qi/7SJBJ yAaKujK2 =6fc9 -----END PGP SIGNATURE----- --/ZDYMhaXUMV+Eds7--