Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D7CFC433EF for ; Fri, 3 Sep 2021 00:54:19 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFAFC60FC4 for ; Fri, 3 Sep 2021 00:54:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CFAFC60FC4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EBD53834F9; Fri, 3 Sep 2021 02:54:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Njc+Gr1M"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9658383503; Fri, 3 Sep 2021 02:54:13 +0200 (CEST) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AA0C6834EF for ; Fri, 3 Sep 2021 02:54:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf32.google.com with SMTP id bn14so2288920qvb.12 for ; Thu, 02 Sep 2021 17:54:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=c+0C0Jc6sEBzEe6Z6ECxgzvgZKNQ/onRwvQyySxOpWA=; b=Njc+Gr1M2P13wqcvopR/p8mODYBinwfACvhCa9SkpyZpqHFLv0vu+rGwbHGALTbCK0 K9unPO/wlJZ6dWaDxal4HqcM8QcKfkT2GXWnQNDt8y/JH+TBO5tARP9bUUJxDCuo8uZi vmYxaB8RYlrI5DD9p+eVKcOxT0qkpOIDZnQbw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=c+0C0Jc6sEBzEe6Z6ECxgzvgZKNQ/onRwvQyySxOpWA=; b=QNvC495R+V7WCcHIPsXN204Bs5SYgaNwOSU6e7nRAeMuSiTsU1j3nUCAGydeyoDq1k c2nmmMFxqy+1CITeU3sDMpkF0sF+zQGejLkv6BR5ewqe17iCayvLS4aiETERHezXIPqJ 8Xe2S4CYpgYz3yf0r79PNZFh24SiilXJ8fjPo3ftt9TXroacDQ30bIwF9d2TDj78Gl7L 6S8t3b5Cp3ilBN3TjLLANvKLb6lUowcFrjkKINOTeCb8aCvAwU1TfcZ3OzMpf0E2MLvw TUkswhc1OQ40aAgEtLiJ/le0Ea1QeBHbw0tvKyk+511KcmvoUDa1OPDgzYEJXezfR+In Q/WA== X-Gm-Message-State: AOAM531jjMX6fSFydyF9VpxHIczmnLeOw2OjGYjuKkIVEmqxSISepSAG nOK0Ll0mWdvSLi7tLMrz+h7jYA== X-Google-Smtp-Source: ABdhPJzY8NhCxx6TTLeMQtGpAdSUgILOJVOWECnDup0j/oNB+VzSbVtyBXSsjk11LAF8K56r7Ic4nQ== X-Received: by 2002:a0c:cb03:: with SMTP id o3mr1126146qvk.36.1630630449283; Thu, 02 Sep 2021 17:54:09 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-95b1-4c42-35f4-d991.res6.spectrum.com. [2603:6081:7b01:cbda:95b1:4c42:35f4:d991]) by smtp.gmail.com with ESMTPSA id e22sm2034584qte.57.2021.09.02.17.54.08 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Sep 2021 17:54:08 -0700 (PDT) Date: Thu, 2 Sep 2021 20:54:06 -0400 From: Tom Rini To: Bin Meng Cc: Andreas Schwab , U-Boot Mailing List , Pragnesh Patel , Bhargav Shah Subject: Re: [PATCH] lib: add crc16.o if CONFIG_MMC_SPI_CRC_ON for SPL build Message-ID: <20210903005406.GH858@bill-the-cat> References: <20210902224232.GB858@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Ufz/RmxPGtf3Gf+d" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Ufz/RmxPGtf3Gf+d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 03, 2021 at 08:52:18AM +0800, Bin Meng wrote: > On Fri, Sep 3, 2021 at 6:42 AM Tom Rini wrote: > > > > On Tue, Aug 17, 2021 at 12:51:34PM +0200, Andreas Schwab wrote: > > > > > CONFIG_MMC_SPI_CRC_ON needs the crc16 functions, but it was not inclu= ded > > > in an SPL build. For non-SPL builds, crc16.o is already added > > > unconditionally. This also removes CONFIG_SPL_YMODEM_SUPPORT from the > > > sifive board configs, which is only relevant for some ARM boards and = was > > > only set for its side effect of adding crc16.o. > > > > Applied to u-boot/next, thanks! >=20 > I thought I replied this email, but it seems not. >=20 > This patch is missing SoB tag. Yes, I also saw, but it's also small / obvious enough that it's not worrisome. By which I also mean, if you check through the linux kernel, there's still an occasional no-SoB tag commit. Not often, but non-zero. --=20 Tom --Ufz/RmxPGtf3Gf+d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmExcicACgkQFHw5/5Y0 tyz2yAwAuwKkBD01awb2qu/T+5JNvMtyNo7S8KevhM4GcsP1v7xtTFkntFpV9c+J okpeeC589kj6u/qISO6h2iEa5z4DvXIlEgSr3UzbN8RM5qbkCqWYpIQPHR/lpRWK iroAU/WgEMuZShLgKU4O41KRMasskwx6G0x6cZjN6iNLX+v+okLwG8/BrEh8FHl6 SraEipQctsuYhHA4c4vmxU/681XGiHM+I2A0HXGPzKlL1FsKsYI7tnAFeexS++je FWjagRirw5KRtTmWCWJbFsN4oxee9HWo2iqfAZX3c3WVEhhM2OMy92Re8hxCRvRC N6G6cY/5KCdLNlFtj9+ywRxr3u/dv095HaDIoqViCMKYvvY8yAyND+i8t+1e4Aco gqX4/l2jvpzMF/gMLxpWaz8ryw0+v+sTyXhcueLhiw6CYXG55dTz4marOfCok1vn xNhK9nSv3BGq1m1u3/EI3yKBee/BIFwGJjG3YYQJHiDtHVkkZCXCGBouv22VC76N aqMDLb5u =JAQP -----END PGP SIGNATURE----- --Ufz/RmxPGtf3Gf+d--