Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 041D7C433F5 for ; Fri, 3 Sep 2021 14:00:49 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF8C760F12 for ; Fri, 3 Sep 2021 14:00:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CF8C760F12 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 24BF4834D0; Fri, 3 Sep 2021 16:00:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="be9SRV0v"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3BBBD834D0; Fri, 3 Sep 2021 16:00:43 +0200 (CEST) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B0EFA8330B for ; Fri, 3 Sep 2021 16:00:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id x5so4532172qtq.13 for ; Fri, 03 Sep 2021 07:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jEOMejPHl6jVncwkdv+lGc4PnSZ+EHHgC5sZQVN141E=; b=be9SRV0v4kAFmt1Ipy1w2hosM89vHc71rP3grsidz29wMQU4U7ecEHKgJniH+vbrSe vF7tpfhGWPnrR8b0hAC3gnFcoNwU9yFxDqmUhvQZiq8PbJCR2YVIae5FRJNefDwMAW33 K0HmUr/MjE7T2oBwGrbABGLHSNJczyF5b1Cl0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jEOMejPHl6jVncwkdv+lGc4PnSZ+EHHgC5sZQVN141E=; b=JwJeFSrW1oKfzmi86ekhJNPfxR7LZ7KafztOPg3kqwoNyMQvKZ+hNDy3gxTX2lQRap oOGiH76Tm6SiTSf64bILM9B2Ul4D7buMnUMaXQPHLu1ZPW00X1BGRv/z0UlajxDKdyut I3uG1spxXVfxznH6Jy2yl6jwY4SAUuG1FNcQhLa5+8joGG6+0kBGLJAyfG0zaLDGvSXu VGTtikdsve5L/Hr1i0+X2dybYlg6CmwtYeLzYH75Y7Qm5oNPiYzqxuHtzyVTfjHhScsV cOd3jawmYM8Vu8Z+54pxzJy+3ULgQKoEg9IRp8gI5EiURP2LYtrNAiz1bp3Wp+vY87dK NpKA== X-Gm-Message-State: AOAM5337fWtlxcqS7TcSmXAgu0jpUJnGZyrVhsgX59s1VLoqEkdTl+lO n+by9mDTUiFeELoGcUOdkDmT7A== X-Google-Smtp-Source: ABdhPJz715pIEbYp9YKs68FDrO2gInVKyNKf6srDuYKzSfFOM5EGfG+CoT27gbHrLvhGLtDdzFxHyg== X-Received: by 2002:ac8:4156:: with SMTP id e22mr3939158qtm.308.1630677636742; Fri, 03 Sep 2021 07:00:36 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-e598-7a50-554e-ee54.res6.spectrum.com. [2603:6081:7b01:cbda:e598:7a50:554e:ee54]) by smtp.gmail.com with ESMTPSA id d20sm3157729qtr.80.2021.09.03.07.00.35 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Sep 2021 07:00:35 -0700 (PDT) Date: Fri, 3 Sep 2021 10:00:33 -0400 From: Tom Rini To: Peter Hoyes Cc: Andre Przywara , u-boot@lists.denx.de, patrick.delaunay@foss.st.com, sjg@chromium.org, diego.sueiro@arm.com Subject: Re: [PATCH v2 5/6] arm: Use armv8_switch_to_el1 env to switch to EL1 Message-ID: <20210903140033.GJ858@bill-the-cat> References: <20210819155314.1787973-1-peter.hoyes@arm.com> <20210819155314.1787973-6-peter.hoyes@arm.com> <20210902224205.GX858@bill-the-cat> <20210903000628.4419ad1f@slackpad.fritz.box> <20210902234917.GG858@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZxVzBsGGnIM0n0U6" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --ZxVzBsGGnIM0n0U6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 03, 2021 at 11:19:28AM +0100, Peter Hoyes wrote: >=20 > Hi, >=20 > On 03/09/2021 00:49, Tom Rini wrote: > > On Fri, Sep 03, 2021 at 12:07:20AM +0100, Andre Przywara wrote: > > > On Thu, 2 Sep 2021 18:42:05 -0400 > > > Tom Rini wrote: > > >=20 > > > Hi Tom, > > >=20 > > > > On Thu, Aug 19, 2021 at 04:53:13PM +0100, Peter Hoyes wrote: > > > >=20 > > > > > From: Peter Hoyes > > > > >=20 > > > > > Use the environment variable armv8_switch_to_el1 to determine whe= ther > > > > > to switch to EL1 at runtime. This is an alternative to the > > > > > CONFIG_ARMV8_SWITCH_TO_EL1 compile-time option. > > > > >=20 > > > > > The environment variable will be ineffective if the ARMV8_MULTIEN= TRY > > > > > config is used. > > > > >=20 > > > > > This is required by the Armv8r64 architecture, which must be able= to > > > > > boot at S-EL1 for Linux but may need to boot at other ELs for oth= er > > > > > systems. > > > > >=20 > > > > > Signed-off-by: Peter Hoyes > > > > Applied to u-boot/next, thanks! > > > Sorry for keeping silent on this, we had some internal discussions > > > here, and we don't think this is the right approach. > > Well, oops on my part too. > Oops here too. > >=20 > > > This whole CONFIG_ARMV8_SWITCH_TO_EL1 solution is actually already > > > questionable, as it goes somewhat against the PSCI spec, which requir= es > > > secondaries to enter in the highest non-secure exception level (Secti= on > > > 6.1.3: "... As described in Figure 6, the return Exception level for a > > > CPU_ON call is the highest Non secure Exception level implemented.") > > >=20 > > > In any case the primary core must enter an the same exception level as > > > the secondaries, or all hell breaks loose. The current code violates > > > this bluntly when the dynamic method is used (as the spin table code > > > doesn't know about this variable). > > >=20 > > > So can you please revert this patch? We are looking into a different > > Should I undo just this, or the whole vexpress_aemv8r series? > >=20 > We are still discussing how to support v8-R internally and it'll probably > take a while to resolve. >=20 > Please can you revert the wholeseries apart from patch 1, which isn't > actually specific to the v8-R. (If preferable,I can submit a "v3" to > clarify this). OK, I'll revert everything except the first patch. For the next go-round, I had fixed up that the defconfig wasn't listed in the board MAINTAINERS, and there was a typo in the docs that checkpatch also spotted. --=20 Tom --ZxVzBsGGnIM0n0U6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEyKnoACgkQFHw5/5Y0 tyx5Swv/W1+J0KF4iImubVZm+ftLQBy0v8iNawYycKXTCK3ccctGJXvHvI37dWwc 4WtEeXqU13UdXdtdKJV8/eBGN9+VFp4xcqwy5TGPXi66hMLCyLvCvV0E2seKVeCc W83Dg8iSyk/3vP1gCHxiDjm/nJ3WOEQuQutDYH226WLxQ2DGrJq5bC3C+tCAJjQe 76CmjppwQjAMZjStWT9KitsGgDLEhu59X5SyRl5QMq8bja8HqKXRl6LtDb5QvkC8 7kEgWHoJVBQvIER38Uhg9Qufc60BAKhA90qpmQt6Uy+stxiHxBl1NwXgFoP8TilF VSdL0+Cce24in79334q40wny1JDJntJNn+1geYwz/mjc1ks7B5TAAAMGxv6amptZ ItSCABL3pb13oNzsEMlYp0CP4YDY4fvMEUIhL8PjMXtHha3HxgjyUtLAdENiHs9G 38Tb2wWLsLgsNqH0XWyABUR32dXuybkkJ0E+/SP02qL16V1DPS7t5w4HXebNCSuO UMw9e+IT =XD72 -----END PGP SIGNATURE----- --ZxVzBsGGnIM0n0U6--