Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 260603FE1 for ; Thu, 9 Sep 2021 10:49:39 +0000 (UTC) Received: by mail-wm1-f73.google.com with SMTP id p11-20020a05600c204b00b002f05aff1663so559188wmg.2 for ; Thu, 09 Sep 2021 03:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=JKG2Csw+REpqX6pYLoajkSbStNWY+2P13qnXNLcGPTo=; b=oVBgZSF0f7gZb8HxrZbIdXzorsMl6/30hQtezrkGiG8Mjm7GMEenEEeX5JUiCbYIgx Doy4WrNjWdwiqs8RasWNSvfZMqCqnH3qDP5QY3UwDBgMIVon3xP9XEhsjAd1s9G2oe3x RiqzigUTJHbCf4sZNRHKAS30r6yHw0KBwy5YQPG1DjBL3/6mFcF5IBV5cgzgfseyw+lr N53YN3j9A/2jMxFze4B4nunFb0XIP42E5YN4mAKc7Ck8rGjvakkPbQCWqASi8Y3uDwYC thMRP3jA2e6aXbyMrjruuJeGvI7gZjIhXqKuZKJDaRFVke0PxsNbBzmW77HK7kksfQ58 J8nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=JKG2Csw+REpqX6pYLoajkSbStNWY+2P13qnXNLcGPTo=; b=RBJzo6vFQusTHqOGWrdIc02LV6OECPq1K2U1Cg26eWDJ0WajoAvjJYTQZWhI+d5j/C StpiWzIsSoMCTXXv4UKBsqZPOVzXAb0EfbQ408J5inTNh+M6DBHGduAlUArz0nw2YhkJ ps+HPmbM6bz4zA7ngOMAtCDWG4eVTCp2FoDOLkyHUTnyjUKpIXzsSMmQ3xrBbG2P/5nT S8EriSpRhbpgglzh8Dh+SrEE2gkzv/ATZnsz69Ns6u+vntbWGQyjs+vhTFiqR3wSV/Ww t1UU11sAmKCdAvGTAjoVYbTICVtZbtApL/feeSUOUFUer3xelZhoBexeS0GvgqAo0DvV TVag== X-Gm-Message-State: AOAM533KlvsTZNkEGgHG1GUtk6wpR01ub2zJz1Cql8I8KeaP6xatnbTb imjN7JNVlTI+YZCNohXpoYbZUa5UlA== X-Google-Smtp-Source: ABdhPJzkOAvHKQVqCuqxsCtyM6C/PyG02n+39nThS1IWFPChq3RDEGCJm3IbSKaPCz97WE1D6JAp5UuEWQ== X-Received: from elver.muc.corp.google.com ([2a00:79e0:15:13:98f9:2b1c:26b6:bc81]) (user=elver job=sendgmr) by 2002:a05:600c:b4e:: with SMTP id k14mr2206453wmr.151.1631184577256; Thu, 09 Sep 2021 03:49:37 -0700 (PDT) Date: Thu, 9 Sep 2021 12:49:25 +0200 Message-Id: <20210909104925.809674-1-elver@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.33.0.153.gba50c8fa24-goog Subject: [PATCH] kasan: double -Wframe-larger-than threshold if KASAN From: Marco Elver To: elver@google.com, Andrew Morton Cc: linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Arnd Bergmann , Christoph Hellwig , Guenter Roeck , Nathan Chancellor , Nick Desaulniers , Aleksandr Nogikh , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Taras Madan , linux-mm@kvack.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" All architectures at least double stack size when using one of the KASAN software modes that rely on compiler instrumentation. Until now, warnings emitted by -Wframe-larger-than could easily be ignored, as we would still get a working kernel. However, with the introduction of -Werror (CONFIG_WERROR=y), it makes sense to at least double the -Wframe-larger-than threshold for software-based KASAN modes to reflect the already increased stack sizes when building a kernel with KASAN enabled. Link: https://lkml.kernel.org/r/YTbOs13waorzamZ6@Ryzen-9-3900X.localdomain Signed-off-by: Marco Elver --- lib/Kconfig.debug | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index ed4a31e34098..2055bbb6724a 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -345,6 +345,8 @@ endif # DEBUG_INFO config FRAME_WARN int "Warn for stack frames larger than" range 0 8192 + default 4096 if 64BIT && (KASAN_GENERIC || KASAN_SW_TAGS) + default 2048 if !64BIT && (KASAN_GENERIC || KASAN_SW_TAGS) default 2048 if GCC_PLUGIN_LATENT_ENTROPY default 1536 if (!64BIT && PARISC) default 1024 if (!64BIT && !PARISC) -- 2.33.0.153.gba50c8fa24-goog