Content-Type: multipart/mixed; boundary="===============9130378816072735867==" MIME-Version: 1.0 From: Fabio Aiuto To: kbuild-all@lists.01.org Subject: Re: [PATCH] extcon: extcon-axp288: use low level P-Unit semaphore lock for axp288 register accesses Date: Fri, 10 Sep 2021 09:13:54 +0200 Message-ID: <20210910071354.GB1437@agape.jhs> In-Reply-To: <3ecef801-7484-95ed-3e76-e7770146e626@redhat.com> List-Id: --===============9130378816072735867== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Hans, On Fri, Sep 10, 2021 at 09:03:42AM +0200, Hans de Goede wrote: > Hi, > > ^ > > 6 errors generated. > = > Ah yes, I should have caught this, we had the same issue with a similar p= atch to > the axp288-fuel-gauge driver. > = > The fix is this: > = > diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig > index c69d40ae5619..aab87c9b35c8 100644 > --- a/drivers/extcon/Kconfig > +++ b/drivers/extcon/Kconfig > @@ -23,7 +23,7 @@ config EXTCON_ADC_JACK > = > config EXTCON_AXP288 > tristate "X-Power AXP288 EXTCON support" > - depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI > + depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI && IOSF_MBI > select USB_ROLE_SWITCH > help > Say Y here to enable support for USB peripheral detection > = > The new depends on is fine since all boards which use the AXP288 should > always have IOSF_MBI enabled anyways. > = > Fabio, can you send a v2 with this Kconfig change added please ? > = > (and please also add my earlier Reviewed-by and Tested-by to the v2) sure will fix and resend > = > = > > = > > = thank you, fabio --===============9130378816072735867==--