Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4507C433F5 for ; Mon, 13 Sep 2021 13:13:54 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED1E460FA0 for ; Mon, 13 Sep 2021 13:13:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ED1E460FA0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 62E0B83917; Mon, 13 Sep 2021 15:13:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="dmxxSeRJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 58B6F8397A; Mon, 13 Sep 2021 15:13:48 +0200 (CEST) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CEBD7838CB for ; Mon, 13 Sep 2021 15:13:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x831.google.com with SMTP id u21so8004028qtw.8 for ; Mon, 13 Sep 2021 06:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3JwtlVt27WRxSKrwCUJE+3WFFs3KHEELmuWZjLBksqk=; b=dmxxSeRJy8R47syDMXa+ddp5ILCyymKfNlSM5cFzOF2rbu8Fb6uoIjeDW336MbhoBf k8JMQvNDHe80QcfE5+N7RVV5eIrDhL0zz68V8eUzC8zwpnXf4mXMwfdDM3wOm/a/Kn38 k9HWaWqTnFyqnByFEg53StKm20Gqm2LWTrTlw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3JwtlVt27WRxSKrwCUJE+3WFFs3KHEELmuWZjLBksqk=; b=TsvivrayWcTsEYE5mNEILEAj/I/foXgd+UgZ3AoSilQbDGJZYkxXuJ7SWj4UBGtxis jUxI/bTl8hkyh9QmOzSnvnKKkyneVZnfYE5Gde0/e+hydAn+xK5NVLXFjiPiKM191FRe 1KQe7YC2rO+aG65TfVztWtnyHqg/wsaYpR1x5gY7GuFjpFQBCCMa0r5ppp2Hp739lrVw B4BWuUVUt8dfPP/t+SsZjpjpZQdDBQsL78tigVvfXEMmaaxuH128d+PttXsqfcR6dEa8 fRsdbxIHDyxv1ksUkjdW8U+SHhAo7hVoz4/doW3Vyu6DRuN7hWwtgJf+pMIw9kiRfIhv G3eA== X-Gm-Message-State: AOAM531gl5O06eUSVR4iAfG2E7YhinqWOckuCw3A30rVX9ENVy5snHTL c4T+FwDGoQqAlEmrxrNA6JVSBg== X-Google-Smtp-Source: ABdhPJwTkCd8RasIeOHaqimUglRIlOVWkSPb1POlrehPJQgGzech+At+wSw69Wz+uLJV4itrFqcTjw== X-Received: by 2002:ac8:5911:: with SMTP id 17mr9173812qty.104.1631538822632; Mon, 13 Sep 2021 06:13:42 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-0166-c2e8-bb10-efce.res6.spectrum.com. [2603:6081:7b01:cbda:166:c2e8:bb10:efce]) by smtp.gmail.com with ESMTPSA id a22sm4086265qtw.59.2021.09.13.06.13.41 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Sep 2021 06:13:42 -0700 (PDT) Date: Mon, 13 Sep 2021 09:13:40 -0400 From: Tom Rini To: Rayagonda Kokatanur Cc: "Priyanka Jain (OSS)" , Bharat Gooty , Roman Bacik , Henrik Christensen , "Z.Q. Hou" , "u-boot@lists.denx.de" Subject: Re: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way reset workaround" Message-ID: <20210913131340.GI12964@bill-the-cat> References: <20210825210510.24766-1-trini@konsulko.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="c0Rcp2AGu/o8LsKL" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --c0Rcp2AGu/o8LsKL Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 13, 2021 at 01:22:10PM +0530, Rayagonda Kokatanur wrote: > On Mon, Sep 13, 2021 at 11:29 AM Priyanka Jain (OSS) > wrote: > > > > > > > > >-----Original Message----- > > >From: U-Boot On Behalf Of Z.Q. Hou > > >Sent: Friday, September 10, 2021 12:13 PM > > >To: Tom Rini ; u-boot@lists.denx.de; > > >rayagonda.kokatanur@broadcom.com > > >Cc: Priyanka Jain > > >Subject: RE: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-wa= y reset > > >workaround" > > > > > >+ author of gic_lpi_syscon driver > > > > > >Hi Rayagonda, > > > > > >Please add the binding for gic_lpi_syscon driver. > > > > > >Thanks, > > >Zhiqiang > > > > > >> -----Original Message----- > > >> From: Tom Rini > > >> Sent: 2021=E5=B9=B48=E6=9C=8826=E6=97=A5 5:05 > > >> To: u-boot@lists.denx.de > > >> Cc: Z.Q. Hou ; Priyanka Jain > > >> > > >> Subject: [PATCH 1/1] Revert "arm64: Layerscape: Survive LPI one-way > > >> reset workaround" > > >> > > >> Ad-hoc bindings that are not part of the upstream device tree / > > >> bindings are not allowed in-tree. Only bindings that are in-progress > > >> with upstream and then re-synced once agreed upon are. > > >> > > >> This reverts commit af288cb291da3abef6be0875527729296f7de7a0. > > >> > > >> Cc: Hou Zhiqiang > > >> Cc: Priyanka Jain > > >> Reported-by: Michael Walle > > >> Signed-off-by: Tom Rini > > >> --- > > >> arch/arm/cpu/armv8/fsl-layerscape/soc.c | 17 +---------------- > > >> arch/arm/dts/fsl-ls1028a.dtsi | 6 ------ > > >> arch/arm/dts/fsl-ls1088a.dtsi | 6 ------ > > >> arch/arm/dts/fsl-ls2080a.dtsi | 6 ------ > > >> arch/arm/dts/fsl-lx2160a.dtsi | 6 ------ > > >> 5 files changed, 1 insertion(+), 40 deletions(-) > > >> > > >> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c > > >> b/arch/arm/cpu/armv8/fsl-layerscape/soc.c > > >> index 42a096854629..166662a64baf 100644 > > >> --- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c > > >> +++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c > > >> @@ -43,22 +43,7 @@ DECLARE_GLOBAL_DATA_PTR; #ifdef > > >CONFIG_GIC_V3_ITS > > >> int ls_gic_rd_tables_init(void *blob) { > > >> - struct fdt_memory lpi_base; > > >> - fdt_addr_t addr; > > >> - fdt_size_t size; > > >> - int offset, ret; > > >> - > > >> - offset =3D fdt_path_offset(gd->fdt_blob, "/syscon@0x80000000"); > > >> - addr =3D fdtdec_get_addr_size_auto_noparent(gd->fdt_blob, offse= t, > > >> "reg", > > >> - 0, &size, false); > > >> - > > >> - lpi_base.start =3D addr; > > >> - lpi_base.end =3D addr + size - 1; > > >> - ret =3D fdtdec_add_reserved_memory(blob, "lpi_rd_table", &lpi_b= ase, > > >> NULL, false); > > >> - if (ret) { > > >> - debug("%s: failed to add reserved memory\n", __func__); > > >> - return ret; > > >> - } > > >> + int ret; > > >> > > >> ret =3D gic_lpi_tables_init(); > > >> if (ret) > > >> diff --git a/arch/arm/dts/fsl-ls1028a.dtsi > > >> b/arch/arm/dts/fsl-ls1028a.dtsi index 50f9b527cde1..53b052ed3271 > > >> 100644 > > >> --- a/arch/arm/dts/fsl-ls1028a.dtsi > > >> +++ b/arch/arm/dts/fsl-ls1028a.dtsi > > >> @@ -44,12 +44,6 @@ > > >> IRQ_TYPE_LEVEL_LOW)>; > > >> }; > > >> > > >> - gic_lpi_base: syscon@0x80000000 { > > >> - compatible =3D "gic-lpi-base"; > > >> - reg =3D <0x0 0x80000000 0x0 0x100000>; > > >> - max-gic-redistributors =3D <2>; > > >> - }; > > >> - > > >> timer { > > >> compatible =3D "arm,armv8-timer"; > > >> interrupts =3D > >> a/arch/arm/dts/fsl-ls1088a.dtsi b/arch/arm/dts/fsl-ls1088a.dtsi index > > >> 64caa600ad77..3a5a50fb8313 100644 > > >> --- a/arch/arm/dts/fsl-ls1088a.dtsi > > >> +++ b/arch/arm/dts/fsl-ls1088a.dtsi > > >> @@ -27,12 +27,6 @@ > > >> interrupts =3D <1 9 0x4>; > > >> }; > > >> > > >> - gic_lpi_base: syscon@0x80000000 { > > >> - compatible =3D "gic-lpi-base"; > > >> - reg =3D <0x0 0x80000000 0x0 0x100000>; > > >> - max-gic-redistributors =3D <8>; > > >> - }; > > >> - > > >> timer { > > >> compatible =3D "arm,armv8-timer"; > > >> interrupts =3D <1 13 0x8>, /* Physical Secure PPI, acti= ve-low */ diff > > >> --git a/arch/arm/dts/fsl-ls2080a.dtsi b/arch/arm/dts/fsl-ls2080a.dtsi > > >> index 7374d580e07e..278daeeb6eea 100644 > > >> --- a/arch/arm/dts/fsl-ls2080a.dtsi > > >> +++ b/arch/arm/dts/fsl-ls2080a.dtsi > > >> @@ -27,12 +27,6 @@ > > >> interrupts =3D <1 9 0x4>; > > >> }; > > >> > > >> - gic_lpi_base: syscon@0x80000000 { > > >> - compatible =3D "gic-lpi-base"; > > >> - reg =3D <0x0 0x80000000 0x0 0x100000>; > > >> - max-gic-redistributors =3D <8>; > > >> - }; > > >> - > > >> timer { > > >> compatible =3D "arm,armv8-timer"; > > >> interrupts =3D <1 13 0x8>, /* Physical Secure PPI, acti= ve-low */ diff > > >> --git a/arch/arm/dts/fsl-lx2160a.dtsi b/arch/arm/dts/fsl-lx2160a.dtsi > > >> index > > >> a6f0e9bc56be..3b5f0d119e76 100644 > > >> --- a/arch/arm/dts/fsl-lx2160a.dtsi > > >> +++ b/arch/arm/dts/fsl-lx2160a.dtsi > > >> @@ -43,12 +43,6 @@ > > >> interrupts =3D <1 9 0x4>; > > >> }; > > >> > > >> - gic_lpi_base: syscon@0x80000000 { > > >> - compatible =3D "gic-lpi-base"; > > >> - reg =3D <0x0 0x80000000 0x0 0x200000>; > > >> - max-gic-redistributors =3D <16>; > > >> - }; > > >> - > > >> timer { > > >> compatible =3D "arm,armv8-timer"; > > >> interrupts =3D <1 13 0x8>, /* Physical Secure PPI, acti= ve-low */ > > > > Tom, > > > > I agree that bindings patch is essential for device-tree changes. > > But merging this patch will break Layerscape Platforms. > > We have requested Rayagonda to submit Binding patch to upstream for rev= iew. > > > > If first patch of binding gets submitted timely, can we defer this patc= h. > > > > Regards > > Priyanka > > >=20 > ++Bharat, Roman and Henrik. Yes, please keep me in the loop on this binding being reviewed upstream. Also, please check the tree for other bindings that haven't been submitted, but also haven't been noticed yet. There is not supposed to be anything outside of the -u-boot.dtsi files that can't be replaced by dropping in a newer set of upstream dts files. And the -u-boot.dtsi files are for u-boot specific bindings (that we're working on upstreaming) or actively in-review bindings upstream. --=20 Tom --c0Rcp2AGu/o8LsKL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmE/ToAACgkQFHw5/5Y0 tyxJkQv9GqnpPqtbuvaxQwmdsBDvV48jVZBrEtRUZgB40MVyDl7D7Ee5YjsdNnMq InWSfjrgK6a1LcSv5TLlyGo0ivdGmWnQxLenGq2C50YHeWV8j1Ei9fl9spAi8sWt pESYoq3wDBS6HbUKJ/xP0qkMDRm1TqxAvoWnHk4SJeYl5QJ8HWs9tWxz7Zdr8erF przPxSWOSRbyKVekWl3ENhMNFfFYtd6wQ+3+hfkCNmwf3B8mVHsXugoRW1DOhRJz K5yzburrTHzI5mHcVOwnrX5an5bE+3SZhevSCfm8WdXkIHbF1gBT6K5OWsIZtCTy /gkEKYumwn2lOH/xhX6b/nEc62eaUxW2QKV00Ib84x1MiEKCP5ANDCyEHJPUtg5Q 3oHxuNL+jYf4WXQdHSmk6CZiNiiJ0VXHI5HciYN0OC+/4DYlkHhg6Mx6caulyF+d HWlnE7R9lSysnIF9HKdG2kbcekRAVbcQmJVoKKZkGOabqkP1wzIhdHyIooWf39Os 2RzdYEvc =jwrm -----END PGP SIGNATURE----- --c0Rcp2AGu/o8LsKL--