Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC90BC433EF for ; Mon, 13 Sep 2021 14:33:05 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39BC660E08 for ; Mon, 13 Sep 2021 14:33:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 39BC660E08 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 927F683AB7; Mon, 13 Sep 2021 16:33:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="FSdKisQa"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 50BFE83AB9; Mon, 13 Sep 2021 16:33:00 +0200 (CEST) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0CA0283AB5 for ; Mon, 13 Sep 2021 16:32:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x735.google.com with SMTP id bk29so10667358qkb.8 for ; Mon, 13 Sep 2021 07:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sS2s2uTiN+t0QTrVfCa8sCiIak837mfPd4bwf9YP49s=; b=FSdKisQazrwDKJnZxYBVdI6a/stNiv/x+wLjZzf0cIEJlfiIJO+qQ+ozTGSsCwuq1Z Fl++CNgNJ45Ekx+kl5R0jTtS9zuvPAlxNeN0AaITCEb/2T1qbh7auVvJlTlmRu2YwWnk F+x6eXxDR53E4LzEwd9PG1mE320eM6lC82v54= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sS2s2uTiN+t0QTrVfCa8sCiIak837mfPd4bwf9YP49s=; b=JDUJGXVkoKVH2VYM6t9z8VDImSbtbKazHCRt+47JX6eNj5V3YUnAPd4Grh33kXSpRo Dz09cNw0n7hgJPVvjLPBykc233p8D/TfJruFOI9gBTxi9sBHh8Kf1+DgGYZfC9hi1mKA Mo+zq8xqVmzG+ecWB56+yVVl1TVkOpbX0w+Hqqpy1t8REVNsxq1wZzQEoRFpX+0byp1e OyNOcITuRt1t4BC5gfO4V7U6Z/POycYpeYdUzT3X9WrYMEw6RPtB0WsPETI1qtTKWs8n nt6pjqJAQvLnpI3glkOoxCnQXuChuIPaQq3A86aExY9ZtFjSW8OocfJuK6r5VYvE931w +XMg== X-Gm-Message-State: AOAM5320QQS7ISzgX8VHgq5idqS+2cRtu6IkYaI+p36FSRxHR3f0V3+4 B9Lx5sJKlJg3RFRZUWwW6hwvVQ== X-Google-Smtp-Source: ABdhPJx0fdarw99ZC8srwfw9H0UTFlNHzxs4oZ2bEBwEJ0zpQRd8Rc8Ad9vo8usNP6N+Mni89GC5ig== X-Received: by 2002:a37:9d92:: with SMTP id g140mr10217344qke.189.1631543574757; Mon, 13 Sep 2021 07:32:54 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-0166-c2e8-bb10-efce.res6.spectrum.com. [2603:6081:7b01:cbda:166:c2e8:bb10:efce]) by smtp.gmail.com with ESMTPSA id t64sm5463036qkd.71.2021.09.13.07.32.53 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Sep 2021 07:32:54 -0700 (PDT) Date: Mon, 13 Sep 2021 10:32:52 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Wolfgang Denk , Simon Glass , Heinrich Schuchardt , u-boot@lists.denx.de Subject: Re: [PATCH 1/2] xyz-modem: Wait infinitely for initial y-modem packet Message-ID: <20210913143252.GN12964@bill-the-cat> References: <20210910204653.3066-1-pali@kernel.org> <1325940.1631529762@gemini.denx.de> <20210913110806.27hc36n6gmhw6uq4@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1NJp9dGL7saVXevp" Content-Disposition: inline In-Reply-To: <20210913110806.27hc36n6gmhw6uq4@pali> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --1NJp9dGL7saVXevp Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 13, 2021 at 01:08:06PM +0200, Pali Roh=E1r wrote: > On Monday 13 September 2021 12:42:42 Wolfgang Denk wrote: > > Dear Pali Roh=E1r, > >=20 > > In message <20210910204653.3066-1-pali@kernel.org> you wrote: > > > Now when command loady can be aborted / cancelled by CTRL+C, change w= ait > > > timeout for initial packet to infinite. This would allow user to not = be > > > hurry when locating file which want to send. Commands loadb and loads > > > already waits infinitely too. > >=20 > > I'm not sure if this is a good idea. > >=20 > > If you use loady in any kind of scripts, this would now hard hang > > the system, while until now it was possible to recover from the > > error. >=20 > Yes, this is a good point. But on the other hand, 'loadb' and 'loads' > commands already have this behavior. So question is if it is better to > have same behavior in all 'load?' commands or each 'load?' would behave > differently... Because for software which transmit files and supports > more protocols (e.g. both x-modem and kermit) it may be a nightmare if > receiver behaves differently... >=20 > > This is a change to the user interface that is not really necessary, > > so I recommend NOT to change the behaviour here, especially as it > > does not hurt. >=20 > Well... there is an issue if you do not start file transfer in the > timeout which current 'loady' command expects. >=20 > If you do not have integrated y-modem support in your terminal you have > to do: >=20 > 1) open terminal and write 'loady' into U-Boot console > 2) disconnect terminal > 3) start y-modem software > 4) choose file to transmit > 5) instruct y-modem software to start transfer So, when does this happen? It's been a long long time since I used minicom, but I know in screen you can do a filter to trigger the transfer, ie: :exec !! /home/trini/bin/load-boot-xymodem.sh is one of the things in my notes and little script is just to sx SPL and then sx --ymodem U-Boot itself. I know tmux is the preferred tool of power users these days but I assume it can do similar. --=20 Tom --1NJp9dGL7saVXevp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmE/YRAACgkQFHw5/5Y0 tyxmxAv/dHfnh+s/PfSt9b13EVu0TTQYeu6vVOovYI2OpEmuKim1gioPqNebRAvP f9Os+KKuUaVxjsj/k8vLcTcwUgH16gG2l8A01fUChzKaw2VtfFFlIi5A9Hgsie6l NND8qc7+lLmMLs8tumEwPg2CvdG1wTNa6yO3f22Ua4CEggOsceeNCt/dBVUSQQXi omUN85AsVFU842ulYTZ6QTcTBPpBLvgkIyuSDZkw8GgHGtwa1y0FtWJqnw10U1uk ggvpSe5TNjMRHO8gTyTlCws0G6ZjVxg5lZhc/H9n+znET0cZst014keiBu8paHw/ sRmMPwcHM+UFV5/iPka/g7wECvFTeOohRIPXCEInohdv35EFCe+/n8+o88EE0AAK lh+h7FVoCG53ZliGJnI/7jTQI/CI9+bhngRL5bDktRz6b1aDbsrLPdKHb335iCya U1Tm3pWbJ0G3g85Eg282vJ7jZbg8hxVax96y8Ekgny2tC6OqyQ+ywZi25bymkbQH 7Ab9nwES =/9nV -----END PGP SIGNATURE----- --1NJp9dGL7saVXevp--