Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CB44C433EF for ; Fri, 17 Sep 2021 22:54:45 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3EC060F6B for ; Fri, 17 Sep 2021 22:54:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D3EC060F6B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6F6F183245; Sat, 18 Sep 2021 00:54:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="jUifD6vw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5BB138323E; Sat, 18 Sep 2021 00:54:02 +0200 (CEST) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6E54683261 for ; Sat, 18 Sep 2021 00:53:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82d.google.com with SMTP id r21so10122944qtw.11 for ; Fri, 17 Sep 2021 15:53:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RFyKxsT1lCWKQkrgmLsKUUg/bqGfYsgwexrNC3CtFj0=; b=jUifD6vwT+kvpVWyZEAfCej0k4lfrkrcblRSgEr9JfVhMdZrfr7ktG0gvXmbpqCdFb fH/hCoXqQzxs9ViN7oRvXGDjtc5+BehSQoV4vSgvSEUN4SQuj/vX7DERUJI2VJm+Nrxo 5O79PSFgphKG+k8ZE+W/wjm+qVsCHSZ6JQt/s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RFyKxsT1lCWKQkrgmLsKUUg/bqGfYsgwexrNC3CtFj0=; b=GjPfCCcJh3DnE55U2EgiS9HyZFRvGYPWul+A22OQXNkOhGNwCTNTZr0KwC5+8jHVbp 4eFJ3m04mQqyDMyisG0x4NuVdt1FBBrLW69ovHMwa517dahYqk8H940QiBhDbqCuGNzR vMmIncG3ZbqlEZEHqZ87dZSoXbrQvkQkt5dGw7g09qAjCVD2kgQua2dD2j3y/so1oT+J 5CSxdKj/7pbO81GG893BsYp4iigzrxN0rXzPY3pTFtNO3fEPfWUf01Mc/l88AkHY6N99 /7OpXDGQOvLnaorivGAgfSDYO08ICegvJXFlE2YWmjNF6UXwCtpKlOGDIIP+v1Fl+uBG uoiA== X-Gm-Message-State: AOAM530/Ybknin314Nt6sOLOqbxyvEWmd4JJjNIvzUYhjz/w3wjK7BEk 4gA8AImR6HeuMmuCSUxk9mbcVg== X-Google-Smtp-Source: ABdhPJxCkKsXnuKvb7+0u3aUKCL+bjhURSHetOoWlozzXRuKI4MdTRy0weJug+tWR9jT70eigEYSUA== X-Received: by 2002:a05:622a:2d1:: with SMTP id a17mr12541376qtx.236.1631919233305; Fri, 17 Sep 2021 15:53:53 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-11d5-faa7-99fc-5b2d.res6.spectrum.com. [2603:6081:7b01:cbda:11d5:faa7:99fc:5b2d]) by smtp.gmail.com with ESMTPSA id q14sm5684970qkl.44.2021.09.17.15.53.52 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Sep 2021 15:53:52 -0700 (PDT) Date: Fri, 17 Sep 2021 18:53:50 -0400 From: Tom Rini To: Dave Gerlach Cc: u-boot@lists.denx.de, Lokesh Vutla , Praneeth Bajjuri , Suman Anna , Nishanth Menon Subject: Re: [PATCH v2 4/5] clk: ti: k3-pll: Change DIV_CTRL programming to read-modify-write Message-ID: <20210917225350.GH8579@bill-the-cat> References: <20210907221658.12428-1-d-gerlach@ti.com> <20210907221658.12428-5-d-gerlach@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="APlYHCtpeOhspHkB" Content-Disposition: inline In-Reply-To: <20210907221658.12428-5-d-gerlach@ti.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --APlYHCtpeOhspHkB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 07, 2021 at 05:16:57PM -0500, Dave Gerlach wrote: > There are three different divider values in the DIV_CTRL register > controlled by the k3-pll driver. Currently the ti_pll_clk_set_rate > function writes the entire register when programming plld, even though > plld only resides in the lower 6 bits. >=20 > Change the plld programming to read-modify-write to only affect the > relevant bits for plld and to preserve the other two divider values > present in the upper 16 bits, otherwise they will always get set to zero > when programming plld. >=20 > Fixes: 0aa2930ca192 ("clk: add support for TI K3 SoC PLL") > Signed-off-by: Dave Gerlach Applied to u-boot/master, thanks! --=20 Tom --APlYHCtpeOhspHkB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFFHH4ACgkQFHw5/5Y0 tyxtOQv8CQcPmhXwRYlzVYlX4NjoVuhPQrZS3IpmR3o9/LepDUICRoHikcFbjkk1 ci5QWaNmHym2CXUkbss4gr9dsfCK7iJeEbcGLFdYK4kwDq4e4nobqB2Gp86GAhoT o81lKgRtS19XIaxMsX2lnaUBXTOwdPtQN9lJkBR89xNfztzKgWprT3mVv4AzbsrN h8lfjnSPQufFxpo3Y2wDkmY9TKwUUGmJLXPfSDVe2uf8+7mBPzZW0LrNlchFXk3e qv0WQGer/sx+2a8pcsi/kJHs4r/42MGDNmivMhjp71ri8zl2zxrjYb6VoiI7TEro Chu7q05WmpUtMzLsYwCBeJXVRp2YwFc2mOZfB95tZpocPNpVk88MmqMbbSFRhxdB Z0ngO/XhqlR5uDOzHPO6PeRhlAseh4fxYAsxxnXsuUrt7CEgMThqA83CEhP47hqm +NlHCa0+3/rd4/xwEYfp2bOw8jDP319fRuBCrW+xv3Nrw/eYP/n/yrH7h6pgC1RJ +Lul8tuS =CfSL -----END PGP SIGNATURE----- --APlYHCtpeOhspHkB--