Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52363C433F5 for ; Thu, 23 Sep 2021 09:42:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3364B61263 for ; Thu, 23 Sep 2021 09:42:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240129AbhIWJn5 (ORCPT ); Thu, 23 Sep 2021 05:43:57 -0400 Received: from elvis.franken.de ([193.175.24.41]:39102 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240221AbhIWJn5 (ORCPT ); Thu, 23 Sep 2021 05:43:57 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mTLFI-00072a-00; Thu, 23 Sep 2021 11:42:24 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 6B7CCC1279; Thu, 23 Sep 2021 11:35:22 +0200 (CEST) Date: Thu, 23 Sep 2021 11:35:22 +0200 From: Thomas Bogendoerfer To: Jackie Liu Cc: chenhuacai@kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH v4] MIPS: loongson64: make CPU_LOONGSON64 depends on MIPS_FP_SUPPORT Message-ID: <20210923093522.GA7289@alpha.franken.de> References: <20210913061908.550030-1-liu.yun@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210913061908.550030-1-liu.yun@linux.dev> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Mon, Sep 13, 2021 at 02:19:08PM +0800, Jackie Liu wrote: > From: Jackie Liu > > mach/loongson64 fails to build when the FPU support is disabled: > > arch/mips/loongson64/cop2-ex.c:45:15: error: implicit declaration of function ‘__is_fpu_owner’; did you mean ‘is_fpu_owner’? [-Werror=implicit-function-declaration] > arch/mips/loongson64/cop2-ex.c:98:30: error: ‘struct thread_struct’ has no member named ‘fpu’ > arch/mips/loongson64/cop2-ex.c:99:30: error: ‘struct thread_struct’ has no member named ‘fpu’ > arch/mips/loongson64/cop2-ex.c:131:43: error: ‘struct thread_struct’ has no member named ‘fpu’ > arch/mips/loongson64/cop2-ex.c:137:38: error: ‘struct thread_struct’ has no member named ‘fpu’ > arch/mips/loongson64/cop2-ex.c:203:30: error: ‘struct thread_struct’ has no member named ‘fpu’ > arch/mips/loongson64/cop2-ex.c:219:30: error: ‘struct thread_struct’ has no member named ‘fpu’ > arch/mips/loongson64/cop2-ex.c:283:38: error: ‘struct thread_struct’ has no member named ‘fpu’ > arch/mips/loongson64/cop2-ex.c:301:38: error: ‘struct thread_struct’ has no member named ‘fpu’ > > Fixes: ef2f826c8f2f ("MIPS: Loongson-3: Enable the COP2 usage") > Suggested-by: Huacai Chen > Reviewed-by: Huacai Chen > Reported-by: k2ci robot > Signed-off-by: Jackie Liu > --- > v1->v2: > move MIPS_FP_SUPPORT from MACH_LOONGSON64 to CPU_LOONGSON64 > > v2->v3: > add Huacai Chen 's suggest label. > > v3->v4: > update Huacai Chen's email address. > > arch/mips/Kconfig | 1 + > 1 file changed, 1 insertion(+) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]