Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id CD7686E5CF for ; Tue, 12 Oct 2021 07:36:33 +0000 (UTC) From: Jigar Bhatt Date: Tue, 12 Oct 2021 13:00:36 +0530 Message-Id: <20211012073036.2414155-1-jigar.bhatt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t v4] tests/i915/i915_pm_dc: Fix condition in dc9-test List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: igt-dev@lists.freedesktop.org Cc: jigar.bhatt@intel.com, petri.latvala@intel.com, nischal.varide@intel.com List-ID: 1.Inside dc9_wait_entry, we do not have DC9 counter, so we rely on dc5/dc6 counter reset to check if display engine was in DC9. Test is passed if live counter is less than the previous counter. Correcting condition igt_wait(read_dc_counter(debugfs_fd, dc_target) < prev_dc, seconds, 100); 2.Moving prev_dc = read_dc_counter(data->debugfs_fd, dc_target); before setup_dc9_dpms avoid 0 reading. Fixes: 2f4e6430a97f04284d1cafb1479e7c1b0b2d596a ("tests/i915/i915_pm_dc: Fix DC9 test") Signed-off-by: Jigar Bhatt Reviewed-by: Petri Latvala --- tests/i915/i915_pm_dc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c index 3a7ce5bf..046c345a 100644 --- a/tests/i915/i915_pm_dc.c +++ b/tests/i915/i915_pm_dc.c @@ -410,7 +410,7 @@ static bool dc9_wait_entry(uint32_t debugfs_fd, int dc_target, int prev_dc, int * since we do not have DC9 counter, * so we rely on dc5/dc6 counter reset to check if display engine was in DC9. */ - return igt_wait(read_dc_counter(debugfs_fd, dc_target) > + return igt_wait(read_dc_counter(debugfs_fd, dc_target) < prev_dc, seconds, 100); } @@ -444,8 +444,8 @@ static void test_dc9_dpms(data_t *data) require_dc_counter(data->debugfs_fd, CHECK_DC5); dc_target = support_dc6(data->debugfs_fd) ? CHECK_DC6 : CHECK_DC5; - setup_dc9_dpms(data, dc_target); prev_dc = read_dc_counter(data->debugfs_fd, dc_target); + setup_dc9_dpms(data, dc_target); dpms_off(data); check_dc9(data, dc_target, prev_dc); dpms_on(data); -- 2.25.1