Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88FDAC433EF for ; Tue, 12 Oct 2021 13:11:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5304B61050 for ; Tue, 12 Oct 2021 13:11:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5304B61050 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X0TZTFs5mHFXzsMgDzkG4dC+Z+Q5vV3L2Yt8xzpfNkk=; b=juHSDO8eJY/aec cUjI4Z0Lsp0m6Bc+aGU9P77T6zZRdK4LcrYT7uRi/b9BtXOvHV5vJhtJSSMlW8t692agXQHxFRwjy XqsTYSrfMGVLWAYfKWDVt3azKlmig+x8lTwG0Gjwq6xR3B1mi7zWHo5CSAZKl1anwv9+UcbbkvT0O 4wkQaHXWKVc/2TezM7+qWYjvU7xB8haTyQ6nPSudVckF3KSmLHB/d6XrwznZKaJQAgI5pFwioglVo B6uGfHlGda6Bw2WNajJS3q+WIOHk46xe8rLCt+5x95V2ES30LncvUwwSK0jO9Jo6vXk6DkxgSivKj PIaNnzvbnZA/AxYYAXYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maHZ0-00Cr0R-2T; Tue, 12 Oct 2021 13:11:26 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maHYu-00Cqzd-Vu for linux-nvme@lists.infradead.org; Tue, 12 Oct 2021 13:11:23 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id C2A0368AFE; Tue, 12 Oct 2021 15:10:57 +0200 (CEST) Date: Tue, 12 Oct 2021 15:10:57 +0200 From: Christoph Hellwig To: Daniel Wagner Cc: Hannes Reinecke , Christoph Hellwig , Sagi Grimberg , Keith Busch , Chaitanya Kulkarni , linux-nvme@lists.infradead.org, Chaitanya Kulkarni Subject: Re: [PATCH 5/7] nvme: expose subsystem type in sysfs attribute 'subtype' Message-ID: <20211012131057.GB11640@lst.de> References: <20210922063525.143045-1-hare@suse.de> <20210922063525.143045-6-hare@suse.de> <20210922080256.sxl437n22f2mcmsq@carbon.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210922080256.sxl437n22f2mcmsq@carbon.lan> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_061121_207209_DC2C5B7A X-CRM114-Status: GOOD ( 14.96 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Sep 22, 2021 at 10:02:56AM +0200, Daniel Wagner wrote: > On Wed, Sep 22, 2021 at 08:35:23AM +0200, Hannes Reinecke wrote: > > +static SUBSYS_ATTR_RO(subtype, S_IRUGO, nvme_subsys_show_subtype); > > + > > #define nvme_subsys_show_str_function(field) \ > > static ssize_t subsys_##field##_show(struct device *dev, \ > > struct device_attribute *attr, char *buf) \ > > @@ -2618,6 +2636,7 @@ static struct attribute *nvme_subsys_attrs[] = { > > &subsys_attr_serial.attr, > > &subsys_attr_firmware_rev.attr, > > &subsys_attr_subsysnqn.attr, > > + &subsys_attr_subtype.attr, > > > Shouldn't this be subsystype to stay consistent with subsysnqn? Hannes? I've aplied the patch for now, but the above seems like a useful fixup to fold in. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme