Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BF16C433F5 for ; Wed, 13 Oct 2021 00:35:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C5F060C4D for ; Wed, 13 Oct 2021 00:35:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235584AbhJMAiA (ORCPT ); Tue, 12 Oct 2021 20:38:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233128AbhJMAh7 (ORCPT ); Tue, 12 Oct 2021 20:37:59 -0400 Received: from mail-qk1-x74a.google.com (mail-qk1-x74a.google.com [IPv6:2607:f8b0:4864:20::74a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B990C061746 for ; Tue, 12 Oct 2021 17:35:57 -0700 (PDT) Received: by mail-qk1-x74a.google.com with SMTP id t2-20020a05620a450200b0045e34e4f9c7so605518qkp.18 for ; Tue, 12 Oct 2021 17:35:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=reply-to:date:message-id:mime-version:subject:from:to:cc; bh=bNMsQGBmtJcsL+f2JEtI6WHNz/oM/2I9pWdaF81Yh3g=; b=ChlnA879mCqQnxov2MNS+l1VdsTIJgCGvHOgT7z9fMUaRX2oxqszjkErc6AMn6wYwm pu3F1wlzdvEuQvlvf74PzFpSWmXluDqygWtteGj8Mh8z0yxBDO7pS8SsTLkbrOr7vjuT fzcIBZJ4r8w6eHanPMcIFsmWg3mDUghkOngqTMDevB5gy8W0dtfUhj7gLeSlK8AIy6V8 cIqVRH/Kxkz+YBiqSezxP5JvFjSQCtmnEMSCp0fb1yRIajWXb681e4jNHiPQk5vQb/Kh dtB5vbD5z6IW/1I4lpEdbWdMMRERQmCYeaw8TFJk+nU4TwAffumQsdSf3QzWHgDJYzfD dqFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:date:message-id:mime-version:subject :from:to:cc; bh=bNMsQGBmtJcsL+f2JEtI6WHNz/oM/2I9pWdaF81Yh3g=; b=1KqW8emKvORtCwmdn5ok1gPPNWt15wh/rm/u+C86Pi2qCyRrmdyejRlgH/fdJkRFO1 7C6fhTLsueQGgh5F39BbgxdJCZn9Y8Y7mtj+VQB4l5y1I8DUxErp5ImTedYRKw/Wr5nn JiliwYes8KeYn3mJ4dE/F+IvfL8zDSKFMpWYRIOgKdzA/o7aU0mqLaovEgOQPChLpXgT AEjj1hkgWcPL9dG/MKIaGK16D10uxW+vTuIWDQShuFR1P8Suwwf9WNsjuCEBcPN7CokF xP3bqMmX2dYN7viigBgENA92FK6chHqxHzg41kK6p2rf3IomBjoYeo+9Tu1VnSaXoXoe X+ZQ== X-Gm-Message-State: AOAM532J536a+FsmBToZ1hSgZ5/KViP81nkviF1eemZGhZDeanVoGJt3 K+DFXQ5KOH4Ysm2bd5T/rJB0cCthfJM= X-Google-Smtp-Source: ABdhPJyRTuR3nWx6ltREyOknYOe+wYccN8lUtdRJBAQdpBFepQlQhMXKfgWmb9OYSRA1ncnMYGSXnpFBcok= X-Received: from seanjc798194.pdx.corp.google.com ([2620:15c:90:200:e55e:31ed:7b83:d4a6]) (user=seanjc job=sendgmr) by 2002:ac8:5e0d:: with SMTP id h13mr25862181qtx.403.1634085356711; Tue, 12 Oct 2021 17:35:56 -0700 (PDT) Reply-To: Sean Christopherson Date: Tue, 12 Oct 2021 17:35:52 -0700 Message-Id: <20211013003554.47705-1-seanjc@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.33.0.1079.g6e70778dc9-goog Subject: [PATCH 0/2] KVM: x86: Revert to fix apic_hw_disabled underflow From: Sean Christopherson To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+9fc046ab2b0cf295a063@syzkaller.appspotmail.com, Tetsuo Handa Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Revert (mostly) a patch from the vCPU RESET cleanup that open coded some APIC shenanigans to avoid stuffing vcpu->arch.apic_base at vCPU creation, and completely overlooked the side effects on apic_hw_disabled. I went for a revert as I think the original behavior is the least awful solution, just somewhat poorly documented. The second patch adds WARNs to detect "overflow", where "overflow" means KVM incorrectly increments apic_hw_disabled. Sean Christopherson (2): Revert "KVM: x86: Open code necessary bits of kvm_lapic_set_base() at vCPU RESET" KVM: x86: WARN if APIC HW/SW disable static keys are non-zero on unload arch/x86/kvm/lapic.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) -- 2.33.0.1079.g6e70778dc9-goog