Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8474C433FE for ; Fri, 15 Oct 2021 17:23:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C017461164 for ; Fri, 15 Oct 2021 17:23:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242340AbhJORZY (ORCPT ); Fri, 15 Oct 2021 13:25:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242348AbhJORZC (ORCPT ); Fri, 15 Oct 2021 13:25:02 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73722C061782 for ; Fri, 15 Oct 2021 10:22:24 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id q193-20020a252aca000000b005ba63482993so12063985ybq.0 for ; Fri, 15 Oct 2021 10:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=3qZZL4q7gSQLhx5UGqjT9ebzZrdH8WkBdFrjH947yQo=; b=StaSBoZiHR3EyDcQiaC3wo96F5TxLygYhJeEXjuSQKdGg/uFybL9coAqda6skNKa1/ H8fDo4iMUdT1JQVheG1jNqSvOEnWloBo82r40zlKrFZYf/LVrQKJAEjiYmZYMt8qfGav Fmmw8VzQW/ArC8hnNcgfatbXub3CkaQJDW8rTvnczzJ9Jiaf2F+0yDsxQYlVflc01SHc L9VT5r4G9XqXnW9SmoAyluPVGe1EOtyIs2d0UAlsCOcpcodboa7ECIlhzSGn92vfOrda qIVKgFUoEqffuKDLl7PV4I+DO7juTtTbzh6Td73U7U7AB/wNlCuIhpTAD5pZEc2EqhSU oCPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=3qZZL4q7gSQLhx5UGqjT9ebzZrdH8WkBdFrjH947yQo=; b=be3x9rJjZVTXH0ijurbt9wvejcZGDWLuZb2IUv2jquW9QYUOqYF7catv0NDWxz8dq9 EU4QXNwq8L0fjrmcwyGYcT5rQtW+u5Bdg6nH3A+Md3t/8qTJa5WK+d2SIKsVdqkH+DNF vicqiVBBniiJLONKz3nPMXI99aZ6kIUV8aUmHYGsMg1G9gECfU05voOdsNs785jUoh7K ONTkiMy+HMoFtPumGhmX25jcBV84DwB64XPnc9zSpgaUG6ETz7BwFlztxnf5niFHUPor xd+ZOdKISLmAdPuZ1zqym6TX35KyyE0UVpYyDUY0GdaMMGbLNSmUP9eSd9EyUjs/J5oR E/Fg== X-Gm-Message-State: AOAM530ZWTtRYEwmJv3ilvhnLFo//BQk+2db9Ihri6thfnAZfM+2QDj2 JNqkoRs6A2lAfzInvtVC83u5ZM6dJ+mc X-Google-Smtp-Source: ABdhPJyeqqip7OkTfcwULOAWPWB82HEh7RrGKGHXSPL6EryOsOno6pftEz+UnRvUr5qVyLdElW9ZzrXvitXl X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:202:69bc:7451:58ad:6585]) (user=irogers job=sendgmr) by 2002:a25:6884:: with SMTP id d126mr13929568ybc.533.1634318543629; Fri, 15 Oct 2021 10:22:23 -0700 (PDT) Date: Fri, 15 Oct 2021 10:21:30 -0700 In-Reply-To: <20211015172132.1162559-1-irogers@google.com> Message-Id: <20211015172132.1162559-20-irogers@google.com> Mime-Version: 1.0 References: <20211015172132.1162559-1-irogers@google.com> X-Mailer: git-send-email 2.33.0.1079.g6e70778dc9-goog Subject: [PATCH v2 19/21] perf metric: Switch fprintf to pr_err. From: Ian Rogers To: Andi Kleen , Jiri Olsa , Jin Yao , Namhyung Kim , John Garry , Kajol Jain , "Paul A . Clarke" , Arnaldo Carvalho de Melo , Riccardo Mancini , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Kees Cook , Sami Tolvanen , Nick Desaulniers , Andrew Morton , Jacob Keller , Zhen Lei , ToastC , Joakim Zhang , Felix Fietkau , Jiapeng Chong , Song Liu , Fabian Hemmer , Alexander Antonov , Nicholas Fraser , Adrian Hunter , Denys Zagorui , Wan Jiabing , Thomas Richter , Sumanth Korikkar , Heiko Carstens , Changbin Du , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Kilroy Cc: Stephane Eranian , Ian Rogers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-perf-users@vger.kernel.org There's no clear reason for the inconsistency that stems from the initial commit. Acked-by: Andi Kleen Signed-off-by: Ian Rogers --- tools/perf/util/metricgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c index 988f9e95dded..b6ba1317973e 100644 --- a/tools/perf/util/metricgroup.c +++ b/tools/perf/util/metricgroup.c @@ -1172,7 +1172,7 @@ static int metricgroup__add_metric_list(const char *list, bool metric_no_group, ret = metricgroup__add_metric(p, metric_no_group, metric_list, map); if (ret == -EINVAL) - fprintf(stderr, "Cannot find metric or group `%s'\n", p); + pr_err("Cannot find metric or group `%s'\n", p); if (ret) break; -- 2.33.0.1079.g6e70778dc9-goog