Content-Type: multipart/mixed; boundary="===============8213486596442543928=="
MIME-Version: 1.0
From: Beau Belgrave <beaub@linux.microsoft.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v4 02/10] user_events: Add minimal support for trace_event into ftrace
Date: Mon, 08 Nov 2021 08:59:16 -0800
Message-ID: <20211108165916.GA1607@kbox>
In-Reply-To: <20211108113225.664c0594e0ca100e458de92b@kernel.org>
List-Id: <oe-kbuild-all.lists.linux.dev>

--===============8213486596442543928==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 08, 2021 at 11:32:25AM +0900, Masami Hiramatsu wrote:
> On Fri, 5 Nov 2021 05:34:31 +0800
> kernel test robot <lkp@intel.com> wrote:
> =

> > Hi Beau,
> > =

> > Thank you for the patch! Yet something to improve:
> > =

> > [auto build test ERROR on rostedt-trace/for-next]
> > [also build test ERROR on shuah-kselftest/next linux/master linus/maste=
r v5.15 next-20211104]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch]
> > =

> > url:    https://github.com/0day-ci/linux/commits/Beau-Belgrave/user_eve=
nts-Enable-user-processes-to-create-and-write-to-trace-events/20211105-0106=
50
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-t=
race.git for-next
> > config: powerpc-allmodconfig (attached as .config)
> > compiler: powerpc-linux-gcc (GCC) 11.2.0
> > reproduce (this is a W=3D1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/s=
bin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://github.com/0day-ci/linux/commit/da0961ad45aa1192b47b8=
a80de6b17437434ae4a
> >         git remote add linux-review https://github.com/0day-ci/linux
> >         git fetch --no-tags linux-review Beau-Belgrave/user_events-Enab=
le-user-processes-to-create-and-write-to-trace-events/20211105-010650
> >         git checkout da0961ad45aa1192b47b8a80de6b17437434ae4a
> >         # save the attached .config to linux build tree
> >         mkdir build_dir
> >         COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.c=
ross O=3Dbuild_dir ARCH=3Dpowerpc SHELL=3D/bin/bash kernel/trace/
> > =

> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > =

> > All errors (new ones prefixed by >>):
> > =

> >    kernel/trace/trace_events_user.c: In function 'user_event_parse':
> > >> kernel/trace/trace_events_user.c:665:9: error: too few arguments to =
function 'dyn_event_add'
> >      665 |         dyn_event_add(&user->devent);
> >          |         ^~~~~~~~~~~~~
> >    In file included from kernel/trace/trace_events_user.c:23:
> >    kernel/trace/trace_dynevent.h:79:19: note: declared here
> >       79 | static inline int dyn_event_add(struct dyn_event *ev,
> >          |                   ^~~~~~~~~~~~~
> =

> You need to pass &user->call too :)
> =

> Thank you,
> =

> -- =

> Masami Hiramatsu <mhiramat@kernel.org>

:)

Yep, these so far have been based on perf/core branch of tip, I've moved the
next iteration over to for-next branch off of linux-trace to ensure alignme=
nt.

Thanks,
-Beau
--===============8213486596442543928==--